Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1184331 > unrolled thread

[PATCH 1/2] mm/cma_debug: fix debugging alloc/free interface

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] mm/cma_debug: fix debugging alloc/free interface Joonsoo Kim <js1304@gmail.com> - 2015-07-15 08:40 +0200
    Re: [PATCH 1/2] mm/cma_debug: fix debugging alloc/free interface Michal Nazarewicz <mina86@mina86.com> - 2015-07-15 14:10 +0200

#1184331 — [PATCH 1/2] mm/cma_debug: fix debugging alloc/free interface

CMA has alloc/free interface for debugging. It is intended that alloc/free
occurs in specific CMA region, but, currently, alloc/free interface is
on root dir due to the bug so we can't select CMA region where alloc/free
happens.

This patch fixes this problem by making alloc/free interface per
CMA region.

Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
---
 mm/cma_debug.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/cma_debug.c b/mm/cma_debug.c
index 7621ee3..22190a7 100644
--- a/mm/cma_debug.c
+++ b/mm/cma_debug.c
@@ -170,10 +170,10 @@ static void cma_debugfs_add_one(struct cma *cma, int idx)
 
 	tmp = debugfs_create_dir(name, cma_debugfs_root);
 
-	debugfs_create_file("alloc", S_IWUSR, cma_debugfs_root, cma,
+	debugfs_create_file("alloc", S_IWUSR, tmp, cma,
 				&cma_alloc_fops);
 
-	debugfs_create_file("free", S_IWUSR, cma_debugfs_root, cma,
+	debugfs_create_file("free", S_IWUSR, tmp, cma,
 				&cma_free_fops);
 
 	debugfs_create_file("base_pfn", S_IRUGO, tmp,
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1184728

On Wed, Jul 15 2015, Joonsoo Kim wrote:
> CMA has alloc/free interface for debugging. It is intended that alloc/free
> occurs in specific CMA region, but, currently, alloc/free interface is
> on root dir due to the bug so we can't select CMA region where alloc/free
> happens.
>
> This patch fixes this problem by making alloc/free interface per
> CMA region.
>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

Acked-by: Michal Nazarewicz <mina86@mina86.com>

> ---
>  mm/cma_debug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/cma_debug.c b/mm/cma_debug.c
> index 7621ee3..22190a7 100644
> --- a/mm/cma_debug.c
> +++ b/mm/cma_debug.c
> @@ -170,10 +170,10 @@ static void cma_debugfs_add_one(struct cma *cma, int idx)
>  
>  	tmp = debugfs_create_dir(name, cma_debugfs_root);
>  
> -	debugfs_create_file("alloc", S_IWUSR, cma_debugfs_root, cma,
> +	debugfs_create_file("alloc", S_IWUSR, tmp, cma,
>  				&cma_alloc_fops);
>  
> -	debugfs_create_file("free", S_IWUSR, cma_debugfs_root, cma,
> +	debugfs_create_file("free", S_IWUSR, tmp, cma,
>  				&cma_free_fops);
>  
>  	debugfs_create_file("base_pfn", S_IRUGO, tmp,
> -- 
> 1.9.1
>

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web