Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1184424 > unrolled thread

Re: [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver Paul Bolle <pebolle@tiscali.nl> - 2015-07-15 10:40 +0200
    Re: [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver Peter Hung <hpeter@gmail.com> - 2015-07-15 11:00 +0200
      Re: [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver Johan Hovold <johan@kernel.org> - 2015-07-15 12:00 +0200

#1184424 — Re: [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver

Just a few nits, I'm afraid.

On di, 2015-07-14 at 11:13 +0800, Peter Hung wrote:
> --- /dev/null
> +++ b/drivers/usb/serial/f81534.c

> +int f81534_gpio_request(struct gpio_chip *chip, unsigned offset)
> +{
> +	[...]
> +}

static?

> +void f81534_gpio_free(struct gpio_chip *chip, unsigned offset)
> +{
> +	[...]
> +}

Ditto.

> +static struct gpio_chip f81534_gpio_chip_templete = {
> +	[...]
> +	.request = f81534_gpio_request,
> +	.free = f81534_gpio_free,
> +	[...]
> +};

> +int f81534_ioctl_set_rs485(struct usb_serial_port *port,
> +			   struct serial_rs485 __user *arg)
> +{
> +	[...]
> +}

Ditto.

> +static int f81534_ioctl(struct tty_struct *tty, unsigned int cmd,
> +			unsigned long arg)
> +{
> +	[...]
> +	case TIOCSRS485:
> +		return f81534_ioctl_set_rs485(port,
> +					      (struct serial_rs485 __user *)
> +					      arg);
> +	[...]
> +}

> +int f81534_prepare_write_buffer(struct usb_serial_port *port,
> +						void *dest, size_t size)
> +{
> +	[...]
> +}

Ditto.

> +static struct usb_serial_driver f81534_device = {
> +	[...]
> +	.prepare_write_buffer = f81534_prepare_write_buffer,
> +	.[...]
> +};
> +
> +static struct usb_serial_driver *const serial_drivers[] = {
> +	&f81534_device, NULL
> +};
> +

If you drop this empty line ...

> +module_usb_serial_driver(serial_drivers, id_table);

and add an empty line here, things look neater.

> +MODULE_DESCRIPTION(DRIVER_DESC);
> +MODULE_AUTHOR("Peter Hong <Peter_Hong@fintek.com.tw>");
> +MODULE_AUTHOR("Tom Tsai <Tom_Tsai@fintek.com.tw>");
> +MODULE_LICENSE("GPL");

Thanks,


Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1184427

Hi Paul & Johan

Paul Bolle 於 2015/7/15 下午 04:36 寫道:
> Just a few nits, I'm afraid.
>> +int f81534_gpio_request(struct gpio_chip *chip, unsigned offset)
>> +{
>> +	[...]
>> +}
>
> static?

Thanks Paul for point this out.

And sorry for Johan. It's seems to make a new patch V5. I'll merge
some minor fix with newer patch.
-- 
With Best Regards,
Peter Hung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1184607

On Wed, Jul 15, 2015 at 04:55:19PM +0800, Peter Hung wrote:
> Hi Paul & Johan
> 
> Paul Bolle 於 2015/7/15 下午 04:36 寫道:
> > Just a few nits, I'm afraid.
> >> +int f81534_gpio_request(struct gpio_chip *chip, unsigned offset)
> >> +{
> >> +	[...]
> >> +}
> >
> > static?
> 
> Thanks Paul for point this out.
> 
> And sorry for Johan. It's seems to make a new patch V5. I'll merge
> some minor fix with newer patch.

No problem, I'll wait for v5.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web