Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1186207 > unrolled thread
| Started by | Sasha Levin <sasha.levin@oracle.com> |
|---|---|
| First post | 2015-07-16 21:40 +0200 |
| Last post | 2015-07-16 21:40 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
[PATCH] mm: trace tlb flush after disabling preemption in try_to_unmap_flush Sasha Levin <sasha.levin@oracle.com> - 2015-07-16 21:40 +0200
| From | Sasha Levin <sasha.levin@oracle.com> |
|---|---|
| Date | 2015-07-16 21:40 +0200 |
| Subject | [PATCH] mm: trace tlb flush after disabling preemption in try_to_unmap_flush |
| Message-ID | <pMXaG-7Oc-1@gated-at.bofh.it> |
Commit "mm: send one IPI per CPU to TLB flush all entries after unmapping pages" added a trace_tlb_flush() while preemption was still enabled. This means that we'll access smp_processor_id() which in turn will get us quite a few warnings. Fix it by moving the trace to where the preemption is disabled, one line down. Signed-off-by: Sasha Levin <sasha.levin@oracle.com> --- The diff is all lies: I've moved trace_tlb_flush() one line down rather than get_cpu() a line up ;) mm/rmap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/rmap.c b/mm/rmap.c index 30812e9..63ba46c 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -613,9 +613,10 @@ void try_to_unmap_flush(void) if (!tlb_ubc->flush_required) return; + cpu = get_cpu(); + trace_tlb_flush(TLB_REMOTE_SHOOTDOWN, -1UL); - cpu = get_cpu(); if (cpumask_test_cpu(cpu, &tlb_ubc->cpumask)) percpu_flush_tlb_batch_pages(&tlb_ubc->cpumask); -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to top | Article view | linux.kernel
csiph-web