Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1186081 > unrolled thread

Re: [PATCH] staging: rtl8188eu: Fix style errors and warnings

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] staging: rtl8188eu: Fix style errors and warnings Greg KH <gregkh@linuxfoundation.org> - 2015-07-16 19:20 +0200
    Re: [PATCH] staging: rtl8188eu: Fix style errors and warnings Joe Perches <joe@perches.com> - 2015-07-16 21:20 +0200

#1186081 — Re: [PATCH] staging: rtl8188eu: Fix style errors and warnings

On Thu, Jul 16, 2015 at 09:41:36AM +0200, Guillaume Bienkowski wrote:
> Fix spaces before comma and indentation.

That's two different things, so this should be two different patches
please.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1186199

On Thu, 2015-07-16 at 10:11 -0700, Greg KH wrote:
> On Thu, Jul 16, 2015 at 09:41:36AM +0200, Guillaume Bienkowski wrote:
> > Fix spaces before comma and indentation.
> 
> That's two different things, so this should be two different patches
> please.

I think it'd be better to do all the whitespace changes
in a single go:

$ git ls-files drivers/staging/rtl8188eu | \
  xargs ./scripts/checkpatch.pl -f --fix-inplace --types=spacing,space_before_tab,pointer_location,trailing_whitespace,bracket_space --strict

and submit the git diff with "whitespace style changes"
after verifying that objdiff shows no changes.

 64 files changed, 1240 insertions(+), 1240 deletions(-)

It's ~330KB patch though.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web