Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1185451 > unrolled thread

[GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3

Started byKrzysztof Kozlowski <k.kozlowski@samsung.com>
First post2015-07-16 04:50 +0200
Last post2015-07-21 07:30 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-16 04:50 +0200
    RE: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3 Kukjin Kim <kgene@kernel.org> - 2015-07-21 07:10 +0200
      Re: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-21 07:20 +0200
        Re: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-21 07:30 +0200

#1185451 — [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3

FromKrzysztof Kozlowski <k.kozlowski@samsung.com>
Date2015-07-16 04:50 +0200
Subject[GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3
Message-ID<pMHpf-1R5-5@gated-at.bofh.it>
Dear Kukjin,

Exynos mach-code related improvements. Description along with a tag.
You can find them also on the lists with my reviewed-by.

Best regards,
Krzysztof


The following changes since commit 1c4c7159ed2468f3ac4ce5a7f08d79663d381a93:

  Merge tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 (2015-07-05 16:24:54 -0700)

are available in the git repository at:


  https://github.com/krzk/linux.git tags/samsung-mach-4.3

for you to fetch changes up to 70f83b6716ea0e5944071c12ff1716f93a9c2d8d:

  cpufreq: exynos: remove Exynos5250 specific cpufreq driver support (2015-07-16 10:39:56 +0900)

----------------------------------------------------------------
Improvements for Exynos based boards:
1. Switch to generic cpufreq-dt driver for Exynos5250. The old driver
   is removed.
2. Fix memory leak in cpufreq error path.
3. Cleanups: remove duplicated define with bootloader's sleep magic
   constant, staticize local function, drop 'owner' from
   platform driver, fix cast of iomem to ERR_PTR.

----------------------------------------------------------------
Bartlomiej Zolnierkiewicz (1):
      cpufreq: exynos: remove Exynos5250 specific cpufreq driver support

Krzysztof Kozlowski (4):
      ARM: EXYNOS: pmu: Make local function static
      ARM: EXYNOS: Remove duplicated define of SLEEP_MAGIC
      ARM: EXYNOS: pmu: Drop owner assignment
      ARM: EXYNOS: Use IOMEM_ERR_PTR when function returns iomem

Shailendra Verma (1):
      cpufreq: exynos: Fix for memory leak in case SOC name does not match

Thomas Abraham (3):
      clk: samsung: exynos5250: add cpu clock configuration data and instantiate cpu clock
      ARM: dts: Exynos5250: add CPU OPP and regulator supply property
      ARM: Exynos: switch to using generic cpufreq driver for Exynos5250

 arch/arm/boot/dts/exynos5250-arndale.dts  |   4 +
 arch/arm/boot/dts/exynos5250-smdk5250.dts |   4 +
 arch/arm/boot/dts/exynos5250-snow.dts     |   4 +
 arch/arm/boot/dts/exynos5250-spring.dts   |   4 +
 arch/arm/boot/dts/exynos5250.dtsi         |  22 ++++
 arch/arm/mach-exynos/common.h             |   6 +
 arch/arm/mach-exynos/exynos.c             |   1 +
 arch/arm/mach-exynos/firmware.c           |   2 -
 arch/arm/mach-exynos/platsmp.c            |   2 +-
 arch/arm/mach-exynos/pmu.c                |   3 +-
 arch/arm/mach-exynos/suspend.c            |   4 +-
 drivers/clk/samsung/clk-exynos5250.c      |  31 +++++
 drivers/cpufreq/Kconfig.arm               |  11 --
 drivers/cpufreq/Makefile                  |   1 -
 drivers/cpufreq/exynos-cpufreq.c          |   9 +-
 drivers/cpufreq/exynos-cpufreq.h          |  17 ---
 drivers/cpufreq/exynos5250-cpufreq.c      | 210 ------------------------------
 include/dt-bindings/clock/exynos5250.h    |   1 +
 18 files changed, 84 insertions(+), 252 deletions(-)
 delete mode 100644 drivers/cpufreq/exynos5250-cpufreq.c
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1188671

FromKukjin Kim <kgene@kernel.org>
Date2015-07-21 07:10 +0200
Message-ID<pOxYt-6Ux-9@gated-at.bofh.it>
In reply to#1185451
Krzysztof Kozlowski wrote:
> 
> Dear Kukjin,
> 
> Exynos mach-code related improvements. Description along with a tag.
> You can find them also on the lists with my reviewed-by.
> 
> Best regards,
> Krzysztof
> 
> 
> The following changes since commit 1c4c7159ed2468f3ac4ce5a7f08d79663d381a93:
> 
>   Merge tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 (2015-
> 07-05 16:24:54 -0700)
> 
> are available in the git repository at:
> 
> 
>   https://github.com/krzk/linux.git tags/samsung-mach-4.3
> 
> for you to fetch changes up to 70f83b6716ea0e5944071c12ff1716f93a9c2d8d:
> 
>   cpufreq: exynos: remove Exynos5250 specific cpufreq driver support (2015-07-16 10:39:56 +0900)
> 
> ----------------------------------------------------------------
> Improvements for Exynos based boards:
> 1. Switch to generic cpufreq-dt driver for Exynos5250. The old driver
>    is removed.
> 2. Fix memory leak in cpufreq error path.
> 3. Cleanups: remove duplicated define with bootloader's sleep magic
>    constant, staticize local function, drop 'owner' from
>    platform driver, fix cast of iomem to ERR_PTR.
> 
> ----------------------------------------------------------------
> Bartlomiej Zolnierkiewicz (1):
>       cpufreq: exynos: remove Exynos5250 specific cpufreq driver support
> 
> Krzysztof Kozlowski (4):
>       ARM: EXYNOS: pmu: Make local function static
>       ARM: EXYNOS: Remove duplicated define of SLEEP_MAGIC
>       ARM: EXYNOS: pmu: Drop owner assignment
>       ARM: EXYNOS: Use IOMEM_ERR_PTR when function returns iomem
> 
> Shailendra Verma (1):
>       cpufreq: exynos: Fix for memory leak in case SOC name does not match
> 
> Thomas Abraham (3):
>       clk: samsung: exynos5250: add cpu clock configuration data and instantiate cpu clock
>       ARM: dts: Exynos5250: add CPU OPP and regulator supply property
>       ARM: Exynos: switch to using generic cpufreq driver for Exynos5250
> 
>  arch/arm/boot/dts/exynos5250-arndale.dts  |   4 +
>  arch/arm/boot/dts/exynos5250-smdk5250.dts |   4 +
>  arch/arm/boot/dts/exynos5250-snow.dts     |   4 +
>  arch/arm/boot/dts/exynos5250-spring.dts   |   4 +
>  arch/arm/boot/dts/exynos5250.dtsi         |  22 ++++
>  arch/arm/mach-exynos/common.h             |   6 +
>  arch/arm/mach-exynos/exynos.c             |   1 +
>  arch/arm/mach-exynos/firmware.c           |   2 -
>  arch/arm/mach-exynos/platsmp.c            |   2 +-
>  arch/arm/mach-exynos/pmu.c                |   3 +-
>  arch/arm/mach-exynos/suspend.c            |   4 +-
>  drivers/clk/samsung/clk-exynos5250.c      |  31 +++++
>  drivers/cpufreq/Kconfig.arm               |  11 --
>  drivers/cpufreq/Makefile                  |   1 -
>  drivers/cpufreq/exynos-cpufreq.c          |   9 +-
>  drivers/cpufreq/exynos-cpufreq.h          |  17 ---
>  drivers/cpufreq/exynos5250-cpufreq.c      | 210 ------------------------------
>  include/dt-bindings/clock/exynos5250.h    |   1 +
>  18 files changed, 84 insertions(+), 252 deletions(-)
>  delete mode 100644 drivers/cpufreq/exynos5250-cpufreq.c
> --

Applied above changes into fixes/non-critical, next/cleanup-samsung,
next/dt-samsung and next/cpufreq-clk-samsung according to the change.

BTW since I can't see any ack from cpufreq guy for the patch "cpufreq:
exynos: Fix for memory leak in case SOC name does not match" so I couldn't.

Thanks,
Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1188673

FromKrzysztof Kozlowski <k.kozlowski@samsung.com>
Date2015-07-21 07:20 +0200
Message-ID<pOy8a-762-13@gated-at.bofh.it>
In reply to#1188671
2015-07-21 14:02 GMT+09:00 Kukjin Kim <kgene@kernel.org>:
> Krzysztof Kozlowski wrote:
>>
>> Dear Kukjin,
>>
>> Exynos mach-code related improvements. Description along with a tag.
>> You can find them also on the lists with my reviewed-by.
>>
>> Best regards,
>> Krzysztof
>>
>>
>> The following changes since commit 1c4c7159ed2468f3ac4ce5a7f08d79663d381a93:
>>
>>   Merge tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 (2015-
>> 07-05 16:24:54 -0700)
>>
>> are available in the git repository at:
>>
>>
>>   https://github.com/krzk/linux.git tags/samsung-mach-4.3
>>
>> for you to fetch changes up to 70f83b6716ea0e5944071c12ff1716f93a9c2d8d:
>>
>>   cpufreq: exynos: remove Exynos5250 specific cpufreq driver support (2015-07-16 10:39:56 +0900)
>>
>> ----------------------------------------------------------------
>> Improvements for Exynos based boards:
>> 1. Switch to generic cpufreq-dt driver for Exynos5250. The old driver
>>    is removed.
>> 2. Fix memory leak in cpufreq error path.
>> 3. Cleanups: remove duplicated define with bootloader's sleep magic
>>    constant, staticize local function, drop 'owner' from
>>    platform driver, fix cast of iomem to ERR_PTR.
>>
>> ----------------------------------------------------------------
>> Bartlomiej Zolnierkiewicz (1):
>>       cpufreq: exynos: remove Exynos5250 specific cpufreq driver support
>>
>> Krzysztof Kozlowski (4):
>>       ARM: EXYNOS: pmu: Make local function static
>>       ARM: EXYNOS: Remove duplicated define of SLEEP_MAGIC
>>       ARM: EXYNOS: pmu: Drop owner assignment
>>       ARM: EXYNOS: Use IOMEM_ERR_PTR when function returns iomem
>>
>> Shailendra Verma (1):
>>       cpufreq: exynos: Fix for memory leak in case SOC name does not match
>>
>> Thomas Abraham (3):
>>       clk: samsung: exynos5250: add cpu clock configuration data and instantiate cpu clock
>>       ARM: dts: Exynos5250: add CPU OPP and regulator supply property
>>       ARM: Exynos: switch to using generic cpufreq driver for Exynos5250
>>
>>  arch/arm/boot/dts/exynos5250-arndale.dts  |   4 +
>>  arch/arm/boot/dts/exynos5250-smdk5250.dts |   4 +
>>  arch/arm/boot/dts/exynos5250-snow.dts     |   4 +
>>  arch/arm/boot/dts/exynos5250-spring.dts   |   4 +
>>  arch/arm/boot/dts/exynos5250.dtsi         |  22 ++++
>>  arch/arm/mach-exynos/common.h             |   6 +
>>  arch/arm/mach-exynos/exynos.c             |   1 +
>>  arch/arm/mach-exynos/firmware.c           |   2 -
>>  arch/arm/mach-exynos/platsmp.c            |   2 +-
>>  arch/arm/mach-exynos/pmu.c                |   3 +-
>>  arch/arm/mach-exynos/suspend.c            |   4 +-
>>  drivers/clk/samsung/clk-exynos5250.c      |  31 +++++
>>  drivers/cpufreq/Kconfig.arm               |  11 --
>>  drivers/cpufreq/Makefile                  |   1 -
>>  drivers/cpufreq/exynos-cpufreq.c          |   9 +-
>>  drivers/cpufreq/exynos-cpufreq.h          |  17 ---
>>  drivers/cpufreq/exynos5250-cpufreq.c      | 210 ------------------------------
>>  include/dt-bindings/clock/exynos5250.h    |   1 +
>>  18 files changed, 84 insertions(+), 252 deletions(-)
>>  delete mode 100644 drivers/cpufreq/exynos5250-cpufreq.c
>> --
>
> Applied above changes into fixes/non-critical, next/cleanup-samsung,
> next/dt-samsung and next/cpufreq-clk-samsung according to the change.

Thanks!

>
> BTW since I can't see any ack from cpufreq guy for the patch "cpufreq:
> exynos: Fix for memory leak in case SOC name does not match" so I couldn't.

Indeed, my mistake. This was acked by Lukasz Majewski and Viresh
Kumar. My commit message should be fixed. Can you apply it with these
missing acks?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1188677

FromKrzysztof Kozlowski <k.kozlowski@samsung.com>
Date2015-07-21 07:30 +0200
Message-ID<pOyhQ-7hc-3@gated-at.bofh.it>
In reply to#1188673
2015-07-21 14:13 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>:
> 2015-07-21 14:02 GMT+09:00 Kukjin Kim <kgene@kernel.org>:
>> Krzysztof Kozlowski wrote:
>>>
>>> Dear Kukjin,
>>>
>>> Exynos mach-code related improvements. Description along with a tag.
>>> You can find them also on the lists with my reviewed-by.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>>
>>> The following changes since commit 1c4c7159ed2468f3ac4ce5a7f08d79663d381a93:
>>>
>>>   Merge tag 'ext4_for_linus_stable' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 (2015-
>>> 07-05 16:24:54 -0700)
>>>
>>> are available in the git repository at:
>>>
>>>
>>>   https://github.com/krzk/linux.git tags/samsung-mach-4.3
>>>
>>> for you to fetch changes up to 70f83b6716ea0e5944071c12ff1716f93a9c2d8d:
>>>
>>>   cpufreq: exynos: remove Exynos5250 specific cpufreq driver support (2015-07-16 10:39:56 +0900)
>>>
>>> ----------------------------------------------------------------
>>> Improvements for Exynos based boards:
>>> 1. Switch to generic cpufreq-dt driver for Exynos5250. The old driver
>>>    is removed.
>>> 2. Fix memory leak in cpufreq error path.
>>> 3. Cleanups: remove duplicated define with bootloader's sleep magic
>>>    constant, staticize local function, drop 'owner' from
>>>    platform driver, fix cast of iomem to ERR_PTR.
>>>
>>> ----------------------------------------------------------------
>>> Bartlomiej Zolnierkiewicz (1):
>>>       cpufreq: exynos: remove Exynos5250 specific cpufreq driver support
>>>
>>> Krzysztof Kozlowski (4):
>>>       ARM: EXYNOS: pmu: Make local function static
>>>       ARM: EXYNOS: Remove duplicated define of SLEEP_MAGIC
>>>       ARM: EXYNOS: pmu: Drop owner assignment
>>>       ARM: EXYNOS: Use IOMEM_ERR_PTR when function returns iomem
>>>
>>> Shailendra Verma (1):
>>>       cpufreq: exynos: Fix for memory leak in case SOC name does not match
>>>
>>> Thomas Abraham (3):
>>>       clk: samsung: exynos5250: add cpu clock configuration data and instantiate cpu clock
>>>       ARM: dts: Exynos5250: add CPU OPP and regulator supply property
>>>       ARM: Exynos: switch to using generic cpufreq driver for Exynos5250
>>>
>>>  arch/arm/boot/dts/exynos5250-arndale.dts  |   4 +
>>>  arch/arm/boot/dts/exynos5250-smdk5250.dts |   4 +
>>>  arch/arm/boot/dts/exynos5250-snow.dts     |   4 +
>>>  arch/arm/boot/dts/exynos5250-spring.dts   |   4 +
>>>  arch/arm/boot/dts/exynos5250.dtsi         |  22 ++++
>>>  arch/arm/mach-exynos/common.h             |   6 +
>>>  arch/arm/mach-exynos/exynos.c             |   1 +
>>>  arch/arm/mach-exynos/firmware.c           |   2 -
>>>  arch/arm/mach-exynos/platsmp.c            |   2 +-
>>>  arch/arm/mach-exynos/pmu.c                |   3 +-
>>>  arch/arm/mach-exynos/suspend.c            |   4 +-
>>>  drivers/clk/samsung/clk-exynos5250.c      |  31 +++++
>>>  drivers/cpufreq/Kconfig.arm               |  11 --
>>>  drivers/cpufreq/Makefile                  |   1 -
>>>  drivers/cpufreq/exynos-cpufreq.c          |   9 +-
>>>  drivers/cpufreq/exynos-cpufreq.h          |  17 ---
>>>  drivers/cpufreq/exynos5250-cpufreq.c      | 210 ------------------------------
>>>  include/dt-bindings/clock/exynos5250.h    |   1 +
>>>  18 files changed, 84 insertions(+), 252 deletions(-)
>>>  delete mode 100644 drivers/cpufreq/exynos5250-cpufreq.c
>>> --
>>
>> Applied above changes into fixes/non-critical, next/cleanup-samsung,
>> next/dt-samsung and next/cpufreq-clk-samsung according to the change.

Cc-ed Bartlomiej,

One issue found: splitting DTS change for Exynos 5250 cpufreq to
separate branch will break bisectability. The commit "ARM: dts:
Exynos5250: add CPU OPP and regulator supply property":
1. MUST be put after "clk: samsung: exynos5250: add cpu clock
configuration data and instantiate cpu clock" to prevent build
failures,
2. should be put before "ARM: Exynos: switch to using generic cpufreq
driver for Exynos5250" to prevent lost cpufreq functionality.

Doing otherwise would lose bisectability which is really unfortunate
when you can simply avoid it. This should remain in the same branch -
next/cpufreq-clk-samsung.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web