Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1183446 > unrolled thread
| Started by | James Hogan <james.hogan@imgtec.com> |
|---|---|
| First post | 2015-07-14 10:40 +0200 |
| Last post | 2015-07-14 10:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [patch 1/1] metag/irq: Use access helper irq_data_get_affinity_mask() James Hogan <james.hogan@imgtec.com> - 2015-07-14 10:40 +0200
Re: [patch 1/1] metag/irq: Use access helper irq_data_get_affinity_mask() Thomas Gleixner <tglx@linutronix.de> - 2015-07-14 10:40 +0200
| From | James Hogan <james.hogan@imgtec.com> |
|---|---|
| Date | 2015-07-14 10:40 +0200 |
| Subject | Re: [patch 1/1] metag/irq: Use access helper irq_data_get_affinity_mask() |
| Message-ID | <pM3US-8kr-3@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Hi,
On 13/07/15 21:43, Thomas Gleixner wrote:
> From: Jiang Liu <jiang.liu@linux.intel.com>
>
> This is a preparatory patch for moving irq_data struct members.
>
> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
> Cc: James Hogan <james.hogan@imgtec.com>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Looks reasonable. Do you want this to go through metag tree?
If not,
Acked-by: James Hogan <james.hogan@imgtec.com>
Cheers
James
> ---
> arch/metag/kernel/irq.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> Index: tip/arch/metag/kernel/irq.c
> ===================================================================
> --- tip.orig/arch/metag/kernel/irq.c
> +++ tip/arch/metag/kernel/irq.c
> @@ -270,23 +270,25 @@ void migrate_irqs(void)
>
> for_each_active_irq(i) {
> struct irq_data *data = irq_get_irq_data(i);
> + struct cpumask *mask;
> unsigned int newcpu;
>
> if (irqd_is_per_cpu(data))
> continue;
>
> - if (!cpumask_test_cpu(cpu, data->affinity))
> + mask = irq_data_get_affinity_mask(data);
> + if (!cpumask_test_cpu(cpu, mask))
> continue;
>
> - newcpu = cpumask_any_and(data->affinity, cpu_online_mask);
> + newcpu = cpumask_any_and(mask, cpu_online_mask);
>
> if (newcpu >= nr_cpu_ids) {
> pr_info_ratelimited("IRQ%u no longer affine to CPU%u\n",
> i, cpu);
>
> - cpumask_setall(data->affinity);
> + cpumask_setall(mask);
> }
> - irq_set_affinity(i, data->affinity);
> + irq_set_affinity(i, mask);
> }
> }
> #endif /* CONFIG_HOTPLUG_CPU */
>
>
[toc] | [next] | [standalone]
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Date | 2015-07-14 10:40 +0200 |
| Subject | Re: [patch 1/1] metag/irq: Use access helper irq_data_get_affinity_mask() |
| Message-ID | <pM3US-8kr-9@gated-at.bofh.it> |
| In reply to | #1183446 |
On Tue, 14 Jul 2015, James Hogan wrote: > On 13/07/15 21:43, Thomas Gleixner wrote: > > From: Jiang Liu <jiang.liu@linux.intel.com> > > > > This is a preparatory patch for moving irq_data struct members. > > > > Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com> > > Cc: James Hogan <james.hogan@imgtec.com> > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > > Looks reasonable. Do you want this to go through metag tree? Yes please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web