Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1182711 > unrolled thread

[PATCH] Staging: android: ion: Fix Style Issue

Started byCraig <craig.inches@xayto.net>
First post2015-07-13 12:50 +0200
Last post2015-07-13 14:40 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] Staging: android: ion: Fix Style Issue Craig <craig.inches@xayto.net> - 2015-07-13 12:50 +0200
    Re: [PATCH] Staging: android: ion: Fix Style Issue Joe Perches <joe@perches.com> - 2015-07-13 13:50 +0200
    Re: [PATCH] Staging: android: ion: Fix Style Issue Dan Carpenter <dan.carpenter@oracle.com> - 2015-07-13 14:40 +0200

#1182711 — [PATCH] Staging: android: ion: Fix Style Issue

FromCraig <craig.inches@xayto.net>
Date2015-07-13 12:50 +0200
Subject[PATCH] Staging: android: ion: Fix Style Issue
Message-ID<pLJt8-3Xa-7@gated-at.bofh.it>
Modified style issue in ion.c. Missing empty line after a definition

Signed-off-by: Craig <craig.inches@xayto.net>
---
 drivers/staging/android/ion/ion.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 6f48112..e44f5e6 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
 	struct ion_buffer *buffer;
 	struct dma_buf *dmabuf;
 	bool valid_handle;
+
 	DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
 
 	mutex_lock(&client->lock);
-- 
2.3.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1182749

FromJoe Perches <joe@perches.com>
Date2015-07-13 13:50 +0200
Message-ID<pLKpc-4vn-5@gated-at.bofh.it>
In reply to#1182711
On Mon, 2015-07-13 at 17:29 +0000, Craig wrote:
> Modified style issue in ion.c. Missing empty line after a definition
> 
> Signed-off-by: Craig <craig.inches@xayto.net>
> ---
>  drivers/staging/android/ion/ion.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 6f48112..e44f5e6 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -1106,6 +1106,7 @@ struct dma_buf *ion_share_dma_buf(struct ion_client *client,
>  	struct ion_buffer *buffer;
>  	struct dma_buf *dmabuf;
>  	bool valid_handle;
> +
>  	DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
>  
>  	mutex_lock(&client->lock);

checkpatch false positive.

Fixed in checkpatch by
https://lkml.org/lkml/2015/7/1/383

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1182767

FromDan Carpenter <dan.carpenter@oracle.com>
Date2015-07-13 14:40 +0200
Message-ID<pLLbA-50E-5@gated-at.bofh.it>
In reply to#1182711
Nope.  It is a false postive.  Also use your full/legal name.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web