Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1182723 > unrolled thread
| Started by | Alexander Kuleshov <kuleshovmail@gmail.com> |
|---|---|
| First post | 2015-07-13 13:10 +0200 |
| Last post | 2015-07-14 10:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] gpu/drm/amdgpu: Include <linux/debugfs.h> only if CONFIG_DEBUG_FS is set Alexander Kuleshov <kuleshovmail@gmail.com> - 2015-07-13 13:10 +0200
Re: [PATCH] gpu/drm/amdgpu: Include <linux/debugfs.h> only if CONFIG_DEBUG_FS is set Alex Deucher <alexdeucher@gmail.com> - 2015-07-14 07:20 +0200
Re: [PATCH] gpu/drm/amdgpu: Include <linux/debugfs.h> only if CONFIG_DEBUG_FS is set Alexander Kuleshov <kuleshovmail@gmail.com> - 2015-07-14 10:20 +0200
| From | Alexander Kuleshov <kuleshovmail@gmail.com> |
|---|---|
| Date | 2015-07-13 13:10 +0200 |
| Subject | [PATCH] gpu/drm/amdgpu: Include <linux/debugfs.h> only if CONFIG_DEBUG_FS is set |
| Message-ID | <pLJMt-4iL-5@gated-at.bofh.it> |
We have no need to include <linux/debugfs.h> if the CONFIG_DEBUG_FS option is not set. Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index ba46be3..23dbfa4 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -27,7 +27,6 @@ */ #include <linux/console.h> #include <linux/slab.h> -#include <linux/debugfs.h> #include <drm/drmP.h> #include <drm/drm_crtc_helper.h> #include <drm/amdgpu_drm.h> @@ -44,2 +43,2 @@ #include "vi.h" #include "bif/bif_4_1_d.h" +#ifdef CONFIG_DEBUG_FS +#include <linux/debugfs.h> +#endif + static int amdgpu_debugfs_regs_init(struct amdgpu_device *adev); static void amdgpu_debugfs_regs_cleanup(struct amdgpu_device *adev); -- 2.5.0-rc1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Alex Deucher <alexdeucher@gmail.com> |
|---|---|
| Date | 2015-07-14 07:20 +0200 |
| Subject | Re: [PATCH] gpu/drm/amdgpu: Include <linux/debugfs.h> only if CONFIG_DEBUG_FS is set |
| Message-ID | <pM0Nk-6x5-11@gated-at.bofh.it> |
| In reply to | #1182723 |
On Mon, Jul 13, 2015 at 7:03 AM, Alexander Kuleshov <kuleshovmail@gmail.com> wrote: > We have no need to include <linux/debugfs.h> if the CONFIG_DEBUG_FS option > is not set. > This patch breaks the build with debugfs enabled. Alex > Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index ba46be3..23dbfa4 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -27,7 +27,6 @@ > */ > #include <linux/console.h> > #include <linux/slab.h> > -#include <linux/debugfs.h> > #include <drm/drmP.h> > #include <drm/drm_crtc_helper.h> > #include <drm/amdgpu_drm.h> > @@ -44,2 +43,2 @@ > #include "vi.h" > #include "bif/bif_4_1_d.h" > > +#ifdef CONFIG_DEBUG_FS > +#include <linux/debugfs.h> > +#endif > + > static int amdgpu_debugfs_regs_init(struct amdgpu_device *adev); > static void amdgpu_debugfs_regs_cleanup(struct amdgpu_device *adev); > > -- > 2.5.0-rc1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Alexander Kuleshov <kuleshovmail@gmail.com> |
|---|---|
| Date | 2015-07-14 10:20 +0200 |
| Subject | Re: [PATCH] gpu/drm/amdgpu: Include <linux/debugfs.h> only if CONFIG_DEBUG_FS is set |
| Message-ID | <pM3Bw-8dT-3@gated-at.bofh.it> |
| In reply to | #1183356 |
Hello Alex,
2015-07-14 11:11 GMT+06:00 Alex Deucher <alexdeucher@gmail.com>:
>
> This patch breaks the build with debugfs enabled.
>
I've tried to built with CONFIG_DEBUG_FS={y/n} and it builds
successfully. Did I miss something?
Maybe I need to enable/disable anything else CONFIG_*?
Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web