Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1180505 > unrolled thread

[PATCH RFC V1 0/3] da9062: Add DA9062 RTC support using the existing DA9063 RTC driver

Started byS Twiss <stwiss.opensource@diasemi.com>
First post2015-07-09 10:00 +0200
Last post2015-07-09 11:10 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH RFC V1 0/3]  da9062: Add DA9062 RTC support using the existing DA9063 RTC driver S Twiss <stwiss.opensource@diasemi.com> - 2015-07-09 10:00 +0200
    Re: [PATCH RFC V1 0/3] da9062: Add DA9062 RTC support using the  existing DA9063 RTC driver Geert Uytterhoeven <geert@linux-m68k.org> - 2015-07-09 10:10 +0200
      RE: [PATCH RFC V1 0/3] da9062: Add DA9062 RTC support using the  existing DA9063 RTC driver "Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com> - 2015-07-09 10:50 +0200
        Re: [PATCH RFC V1 0/3] da9062: Add DA9062 RTC support using the  existing DA9063 RTC driver Geert Uytterhoeven <geert@linux-m68k.org> - 2015-07-09 11:10 +0200

#1180505 — [PATCH RFC V1 0/3] da9062: Add DA9062 RTC support using the existing DA9063 RTC driver

FromS Twiss <stwiss.opensource@diasemi.com>
Date2015-07-09 10:00 +0200
Subject[PATCH RFC V1 0/3] da9062: Add DA9062 RTC support using the existing DA9063 RTC driver
Message-ID<pKeUq-5Qy-9@gated-at.bofh.it>
From: S Twiss <stwiss.opensource@diasemi.com>

This patch set adds RTC support for the Dialog DA9062 Power Management IC.
Changes are made to the existing DA9063 RTC component so that functionality
in this device driver can be re-used to support the DA9062 RTC.

This following patch set is the proposed method for re-using existing kernel
RTC drivers for chips whose RTC blocks are functionally similar to the
DA9063 RTC.

There is already a precedence for reuse of this type in the kernel, see
linux-mainline/v4.1 drivers/rtc/rtc-pm8xxx.c +34
This patch set will follow that example.

The main points for the MFD core and device tree changes are as follows.

- Alteration of the DA9063 RTC Kconfig needs to be updated to depend on
  both MFD_DA9063 "or" MFD_DA9062. There is no explicit DA9062 RTC Kconfig.
- The DA9062 MFD core should add a new RTC resource as usual and an entry
  in the mfd_cell to support a component name and of_compatible for
  "da9062-rtc" and "dlg,da9062-rtc".
- The device tree binding support should include a compatible string for
  "dlg,da9062-rtc"

The main points for the RTC changes are as follows:

A generic structure is used (called da9063_compatible_rtc_regmap) to hold
all generic registers and bitmasks for use with this type of RTC component.

Functions in the DA9063 RTC will be refactored to use this compatibility
struct and all accesses to generic registers/masks will be made through
this table look-up instead of using defines from the register header files
directly

Linkage between the DA9062 MFD and the DA9063 RTC driver is created through
the use of an of_match_table entry in the platform_driver structure.
A re-work of da9063_rtc_probe() is necessary to use the of_match_node() and
dev_get_regmap() functions: this will provide initialisation of the generic
registers and masks and allow access to the regmap according to the correct
device tree specification.

The addition of a of_device_id table for DA9063 and DA9062 default data
is created. This method of initialisation for the DA9063 RTC component
works well for different chip types, and is only slightly complicated when
distinguishing the difference between support for DA9063-AD and DA9063-BB.

In this patch set the following is provided:
 - [PATCH V1 1/3]: MFD changes in DA9062 to support RTC
 - [PATCH V1 2/3]: Update existing DA9063 RTC to add DA9062 support
 - [PATCH V1 3/3]: Device tree bindings for DA9062 RTC component

This patch applies against linux-next and next-20150708 

Thank you,
Steve Twiss, Dialog Semiconductor Ltd.

S Twiss (3):
  mfd: da9062: Support for the DA9063 RTC in the DA9062 core
  rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver
  devicetree: da9062: Add device tree bindings for DA9062 RTC

 Documentation/devicetree/bindings/mfd/da9062.txt |   9 +
 drivers/mfd/da9062-core.c                        |  11 +
 drivers/rtc/Kconfig                              |   6 +-
 drivers/rtc/rtc-da9063.c                         | 435 ++++++++++++++++-------
 4 files changed, 330 insertions(+), 131 deletions(-)

-- 
end-of-patch for PATCH RFC V1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1180511 — Re: [PATCH RFC V1 0/3] da9062: Add DA9062 RTC support using the existing DA9063 RTC driver

FromGeert Uytterhoeven <geert@linux-m68k.org>
Date2015-07-09 10:10 +0200
SubjectRe: [PATCH RFC V1 0/3] da9062: Add DA9062 RTC support using the existing DA9063 RTC driver
Message-ID<pKf45-69s-13@gated-at.bofh.it>
In reply to#1180505
Hi Steve,

On Thu, Jul 9, 2015 at 9:45 AM, S Twiss <stwiss.opensource@diasemi.com> wrote:
> From: S Twiss <stwiss.opensource@diasemi.com>
>
> This patch set adds RTC support for the Dialog DA9062 Power Management IC.
> Changes are made to the existing DA9063 RTC component so that functionality
> in this device driver can be re-used to support the DA9062 RTC.

[...]

> S Twiss (3):
>   mfd: da9062: Support for the DA9063 RTC in the DA9062 core

"DA9062 RTC"?

>   rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver
>   devicetree: da9062: Add device tree bindings for DA9062 RTC

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1180552 — RE: [PATCH RFC V1 0/3] da9062: Add DA9062 RTC support using the existing DA9063 RTC driver

From"Opensource [Steve Twiss]" <stwiss.opensource@diasemi.com>
Date2015-07-09 10:50 +0200
SubjectRE: [PATCH RFC V1 0/3] da9062: Add DA9062 RTC support using the existing DA9063 RTC driver
Message-ID<pKfGO-6mA-1@gated-at.bofh.it>
In reply to#1180511
T24gMDkgSnVseSAyMDE1IDA5OjAyLCBHZWVydCBVeXR0ZXJob2V2ZW4gd3JvdGU6DQoNCj4gU3Vi
amVjdDogUmU6IFtQQVRDSCBSRkMgVjEgMC8zXSBkYTkwNjI6IEFkZCBEQTkwNjIgUlRDIHN1cHBv
cnQgdXNpbmcgdGhlDQo+IGV4aXN0aW5nIERBOTA2MyBSVEMgZHJpdmVyDQo+IA0KPiBIaSBTdGV2
ZSwNCj4gDQo+IE9uIFRodSwgSnVsIDksIDIwMTUgYXQgOTo0NSBBTSwgUyBUd2lzcyA8c3R3aXNz
Lm9wZW5zb3VyY2VAZGlhc2VtaS5jb20+DQo+IHdyb3RlOg0KPiA+IEZyb206IFMgVHdpc3MgPHN0
d2lzcy5vcGVuc291cmNlQGRpYXNlbWkuY29tPg0KPiA+DQo+ID4gVGhpcyBwYXRjaCBzZXQgYWRk
cyBSVEMgc3VwcG9ydCBmb3IgdGhlIERpYWxvZyBEQTkwNjIgUG93ZXIgTWFuYWdlbWVudCBJQy4N
Cj4gPiBDaGFuZ2VzIGFyZSBtYWRlIHRvIHRoZSBleGlzdGluZyBEQTkwNjMgUlRDIGNvbXBvbmVu
dCBzbyB0aGF0IGZ1bmN0aW9uYWxpdHkNCj4gPiBpbiB0aGlzIGRldmljZSBkcml2ZXIgY2FuIGJl
IHJlLXVzZWQgdG8gc3VwcG9ydCB0aGUgREE5MDYyIFJUQy4NCj4gDQo+IFsuLi5dDQo+IA0KPiA+
IFMgVHdpc3MgKDMpOg0KPiA+ICAgbWZkOiBkYTkwNjI6IFN1cHBvcnQgZm9yIHRoZSBEQTkwNjMg
UlRDIGluIHRoZSBEQTkwNjIgY29yZQ0KPiANCj4gIkRBOTA2MiBSVEMiPw0KPiANCg0KSGkgR2Vl
cnQsDQoNCkl0J3MgdGhlIHN1cHBvcnQgZm9yIHRoZSAiREE5MDYzIFJUQyAqZHJpdmVyKiBpbiB0
aGUgREE5MDYyIE1GRCBkcml2ZXIgY29yZSIuDQoNCkknbSByZS13b3JraW5nIHRoZSBEQTkwNjMg
UlRDIGRyaXZlciB0byBzdXBwb3J0IERBOTA2MiBSVEMgaGFyZHdhcmUuIFRoaXMgd2lsbCBtYWtl
DQp0aGUgbmFtZSAiREE5MDYzIFJUQyBkcml2ZXIiIGludGVyY2hhbmdlYWJsZSB3aXRoICJEQTkw
NjIgUlRDIGRyaXZlciIsIGJlY2F1c2UgaWYgdGhpcw0KcGF0Y2ggZ29lcyB0aHJvdWdoIHRoZXkg
d2lsbCBib3RoIGJlIHVzaW5nIHRoZSBvcmlnaW5hbCAiREE5MDYzIFJUQyBkcml2ZXIiLg0KDQpD
b25mdXNlZD8gIDotLw0KDQpJIHN1cHBvc2UgSSBjb3VsZCBhbHNvIGhhdmUgY2FsbGVkIHRoaXMg
cGF0Y2ggInN1cHBvcnQgZm9yIHRoZSBEQTkwNjIgUlRDIEgvVyBpbiB0aGUNCkRBOTA2MiBNRkQg
ZHJpdmVyIGNvcmUiLg0KDQpUaGlzIGNvbWVzIGZyb20gYSBwcmV2aW91cyB0aHJlYWQgaGVyZToN
Cmh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDE1LzUvMTMvNDA2DQpodHRwczovL2xrbWwub3JnL2xr
bWwvMjAxNS81LzEzLzUyOA0KDQpSZWdhcmRzLA0KU3RldmUNCg0KWy4uLl0NCg==
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1180572 — Re: [PATCH RFC V1 0/3] da9062: Add DA9062 RTC support using the existing DA9063 RTC driver

FromGeert Uytterhoeven <geert@linux-m68k.org>
Date2015-07-09 11:10 +0200
SubjectRe: [PATCH RFC V1 0/3] da9062: Add DA9062 RTC support using the existing DA9063 RTC driver
Message-ID<pKg0b-6Iq-27@gated-at.bofh.it>
In reply to#1180552
On Thu, Jul 9, 2015 at 10:42 AM, Opensource [Steve Twiss]
<stwiss.opensource@diasemi.com> wrote:
>> > S Twiss (3):
>> >   mfd: da9062: Support for the DA9063 RTC in the DA9062 core
>>
>> "DA9062 RTC"?
>>
>
> Hi Geert,
>
> It's the support for the "DA9063 RTC *driver* in the DA9062 MFD driver core".

Ah, I read "core" as in "hardware IP core".

And as the full patch description for [1/3] doesn't say "da9063" elsewhere,
I thought it was a typo.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web