Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1180523 > unrolled thread

Re: [1/2] RTC: Add core rtc support for Gemini Soc devices

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [1/2] RTC: Add core rtc support for Gemini Soc devices Arnd Bergmann <arnd@arndb.de> - 2015-07-09 10:10 +0200
    Re: [1/2] RTC: Add core rtc support for Gemini Soc devices Hans Ulli Kroll <ulli.kroll@googlemail.com> - 2015-07-09 14:00 +0200
      Gemini Soc timers Roman Yeryomin <roman@advem.lv> - 2015-07-09 15:10 +0200
        Re: Gemini Soc timers Linus Walleij <linus.walleij@linaro.org> - 2015-07-10 10:50 +0200

#1180523 — Re: [1/2] RTC: Add core rtc support for Gemini Soc devices

On Thursday 09 July 2015 01:29:39 Roman Yeryomin wrote:
> 
> OK, here are the minimal changes required (see attachment). Tested on 
> 4.1.1
> Let me know if you want me to submit it in some other way.
> 

The changes look ok to me. Please submit them as two separate
patches (1. set up and use timer3, 2. register sched_clock) according
to the Documentation/SubmittingPatches description.

Thanks,

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1180661

Hi

On Thu, 9 Jul 2015, Arnd Bergmann wrote:

> On Thursday 09 July 2015 01:29:39 Roman Yeryomin wrote:
> > 
> > OK, here are the minimal changes required (see attachment). Tested on 
> > 4.1.1
> > Let me know if you want me to submit it in some other way.
> > 
> 
> The changes look ok to me. Please submit them as two separate
> patches (1. set up and use timer3, 2. register sched_clock) according
> to the Documentation/SubmittingPatches description.
> 
> Thanks,
> 
> 	Arnd
> 

have you seen this thread ...
[PATCH 00/18] ARM: Migrate clockevent drivers to 'set-state
http://permalink.gmane.org/gmane.linux.ports.arm.kernel/423992

arch/arm/mach-gemini/time.c              | 69 ++++++++++++------------ 

Two or more weeks ago I send a patchset fixing this problem.
At this time Arnd was in holiday and until today I was very busy at work.

I can rework my patches on top of Viresh's patchset

and Roman please fix the subject.

Ulli
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1180739 — Gemini Soc timers

On 2015-07-09 14:58, Hans Ulli Kroll wrote:
> Hi
> 
> On Thu, 9 Jul 2015, Arnd Bergmann wrote:
> 
>> On Thursday 09 July 2015 01:29:39 Roman Yeryomin wrote:
>> >
>> > OK, here are the minimal changes required (see attachment). Tested on
>> > 4.1.1
>> > Let me know if you want me to submit it in some other way.
>> >
>> 
>> The changes look ok to me. Please submit them as two separate
>> patches (1. set up and use timer3, 2. register sched_clock) according
>> to the Documentation/SubmittingPatches description.
>> 
>> Thanks,
>> 
>> 	Arnd
>> 
> 
> have you seen this thread ...
> [PATCH 00/18] ARM: Migrate clockevent drivers to 'set-state
> http://permalink.gmane.org/gmane.linux.ports.arm.kernel/423992
> 
> arch/arm/mach-gemini/time.c              | 69 ++++++++++++------------
> 
> Two or more weeks ago I send a patchset fixing this problem.
> At this time Arnd was in holiday and until today I was very busy at 
> work.

Sorry, I didn't see your patches.
Arnd requested minimal changes and until yesterday I was very busy too.

> I can rework my patches on top of Viresh's patchset

It looks that this patchset doesn't conflict with the fix needed.

> and Roman please fix the subject.

done


Regards,
Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1181394 — Re: Gemini Soc timers

On Thu, Jul 9, 2015 at 6:48 PM, Roman Yeryomin <roman@advem.lv> wrote:
> [Me]
>> As usual they are just keeping it out of mainline, and this
>> is adding sched_clock() and other goodies so should
>> probably be upstreamed ASAP.
>
>
> This is what I initially submitted here.

Ah. I missed part of the start of the discussion it seems.

> But Arnd wanted to see a smaller patch which only fixes gemini timer issue
> (t.i. shed clock being 100Hz instead of 25MHz).
> Also I've submitted 4.1 support yesterday, but patches didn't change much
> comparing to 3.18

On the other hand I think the bigger patch is OK actually.

I rewrote the timer support some time back and did not get
anyone to test it properly at the time, so the patch went in
untested. So this is a fix.

I think this should be applied as-is since you can actually
test the whole thing on real hardware, and also add:

Fixes: f3372c01816e "ARM: gemini: convert to GENERIC_CLOCKEVENTS"
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

> I would love to see all those patches/drivers in mainline - tell me where do
> I submit all that :)

I recently looked at some of the patch stacks in OpenWRT and
get a bit sad that the stuff did not go upstream, so I am ready
to help in any way I can.

Anything GPIO related I am ready to help in reviewing/applying
and I will also help out with ARM32 if I can. Sadly I do not have
a Gemini system.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web