Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1181785 > unrolled thread
| Started by | "Tirdea, Irina" <irina.tirdea@intel.com> |
|---|---|
| First post | 2015-07-10 19:40 +0200 |
| Last post | 2015-07-10 19:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
RE: [PATCH v3 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler "Tirdea, Irina" <irina.tirdea@intel.com> - 2015-07-10 19:40 +0200
Re: [PATCH v3 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com> - 2015-07-10 19:50 +0200
| From | "Tirdea, Irina" <irina.tirdea@intel.com> |
|---|---|
| Date | 2015-07-10 19:40 +0200 |
| Subject | RE: [PATCH v3 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler |
| Message-ID | <pKKrf-t8-5@gated-at.bofh.it> |
> -----Original Message-----
> From: Jonathan Cameron [mailto:jic23@kernel.org]
> Sent: 05 July, 2015 15:08
> To: Tirdea, Irina; Wolfram Sang; linux-iio@vger.kernel.org; linux-i2c@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org; Pandruvada, Srinivas; Peter Meerwald
> Subject: Re: [PATCH v3 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler
>
> On 03/07/15 10:33, Irina Tirdea wrote:
> > Some i2c busses (e.g.: Synopsys DesignWare I2C adapter) need to
> > enable/disable the bus at each i2c transfer and must wait for
> > the enable/disable to happen before sending the data.
> >
> > When reading data in the trigger handler, the bmg160 driver does
> > one i2c transfer for each axis. This has an impact on the frequency
> > of the gyroscope at high sample rates due to additional delays
> > introduced by the i2c bus at each transfer.
> >
> > Reading all axis values in one i2c transfer reduces the delays
> > introduced by the i2c bus. Uses i2c_smbus_read_i2c_block_data_or_emulated
> > that will fallback to reading each axis as a separate word in case i2c
> > block read is not supported.
> >
> > Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> Acked-by: Jonathan Cameron <jic23@kernel.org>
>
Thanks Jonathan!
> Obviously you'll ideally pick up Ack's from the driver authors /maintainers
> as well.
>
Srinivas, are you OK with these changes for bmc150, bmg160 and kxcjk-1013?
Thanks,
Irina
> Jonathan
> > ---
> > drivers/iio/gyro/bmg160.c | 18 ++++++++----------
> > 1 file changed, 8 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/iio/gyro/bmg160.c b/drivers/iio/gyro/bmg160.c
> > index 4b423f2..04e15e9 100644
> > --- a/drivers/iio/gyro/bmg160.c
> > +++ b/drivers/iio/gyro/bmg160.c
> > @@ -784,6 +784,7 @@ static const struct iio_event_spec bmg160_event = {
> > .sign = 's', \
> > .realbits = 16, \
> > .storagebits = 16, \
> > + .endianness = IIO_LE, \
> > }, \
> > .event_spec = &bmg160_event, \
> > .num_event_specs = 1 \
> > @@ -822,19 +823,16 @@ static irqreturn_t bmg160_trigger_handler(int irq, void *p)
> > struct iio_poll_func *pf = p;
> > struct iio_dev *indio_dev = pf->indio_dev;
> > struct bmg160_data *data = iio_priv(indio_dev);
> > - int bit, ret, i = 0;
> > + int ret = 0;
> >
> > mutex_lock(&data->mutex);
> > - for (bit = 0; bit < AXIS_MAX; bit++) {
> > - ret = i2c_smbus_read_word_data(data->client,
> > - BMG160_AXIS_TO_REG(bit));
> > - if (ret < 0) {
> > - mutex_unlock(&data->mutex);
> > - goto err;
> > - }
> > - data->buffer[i++] = ret;
> > - }
> > + ret = i2c_smbus_read_i2c_block_data_or_emulated(data->client,
> > + BMG160_REG_XOUT_L,
> > + AXIS_MAX * 2,
> > + (u8 *)data->buffer);
> > mutex_unlock(&data->mutex);
> > + if (ret < 0)
> > + goto err;
> >
> > iio_push_to_buffers_with_timestamp(indio_dev, data->buffer,
> > data->timestamp);
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com> |
|---|---|
| Date | 2015-07-10 19:50 +0200 |
| Message-ID | <pKKAW-wN-31@gated-at.bofh.it> |
| In reply to | #1181785 |
T24gRnJpLCAyMDE1LTA3LTEwIGF0IDE3OjMxICswMDAwLCBUaXJkZWEsIElyaW5hIHdyb3RlOg0K PiANCj4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+IEZyb206IEpvbmF0aGFuIENh bWVyb24gW21haWx0bzpqaWMyM0BrZXJuZWwub3JnXQ0KPiA+IFNlbnQ6IDA1IEp1bHksIDIwMTUg MTU6MDgNCj4gPiBUbzogVGlyZGVhLCBJcmluYTsgV29sZnJhbSBTYW5nOyBsaW51eC1paW9Admdl ci5rZXJuZWwub3JnOyBsaW51eC1pMmNAdmdlci5rZXJuZWwub3JnDQo+ID4gQ2M6IGxpbnV4LWtl cm5lbEB2Z2VyLmtlcm5lbC5vcmc7IFBhbmRydXZhZGEsIFNyaW5pdmFzOyBQZXRlciBNZWVyd2Fs ZA0KPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjMgNi84XSBpaW86IGd5cm86IGJtZzE2MDogb3B0 aW1pemUgaTJjIHRyYW5zZmVycyBpbiB0cmlnZ2VyIGhhbmRsZXINCj4gPiANCj4gPiBPbiAwMy8w Ny8xNSAxMDozMywgSXJpbmEgVGlyZGVhIHdyb3RlOg0KPiA+ID4gU29tZSBpMmMgYnVzc2VzIChl LmcuOiBTeW5vcHN5cyBEZXNpZ25XYXJlIEkyQyBhZGFwdGVyKSBuZWVkIHRvDQo+ID4gPiBlbmFi bGUvZGlzYWJsZSB0aGUgYnVzIGF0IGVhY2ggaTJjIHRyYW5zZmVyIGFuZCBtdXN0IHdhaXQgZm9y DQo+ID4gPiB0aGUgZW5hYmxlL2Rpc2FibGUgdG8gaGFwcGVuIGJlZm9yZSBzZW5kaW5nIHRoZSBk YXRhLg0KPiA+ID4NCj4gPiA+IFdoZW4gcmVhZGluZyBkYXRhIGluIHRoZSB0cmlnZ2VyIGhhbmRs ZXIsIHRoZSBibWcxNjAgZHJpdmVyIGRvZXMNCj4gPiA+IG9uZSBpMmMgdHJhbnNmZXIgZm9yIGVh Y2ggYXhpcy4gVGhpcyBoYXMgYW4gaW1wYWN0IG9uIHRoZSBmcmVxdWVuY3kNCj4gPiA+IG9mIHRo ZSBneXJvc2NvcGUgYXQgaGlnaCBzYW1wbGUgcmF0ZXMgZHVlIHRvIGFkZGl0aW9uYWwgZGVsYXlz DQo+ID4gPiBpbnRyb2R1Y2VkIGJ5IHRoZSBpMmMgYnVzIGF0IGVhY2ggdHJhbnNmZXIuDQo+ID4g Pg0KPiA+ID4gUmVhZGluZyBhbGwgYXhpcyB2YWx1ZXMgaW4gb25lIGkyYyB0cmFuc2ZlciByZWR1 Y2VzIHRoZSBkZWxheXMNCj4gPiA+IGludHJvZHVjZWQgYnkgdGhlIGkyYyBidXMuIFVzZXMgaTJj X3NtYnVzX3JlYWRfaTJjX2Jsb2NrX2RhdGFfb3JfZW11bGF0ZWQNCj4gPiA+IHRoYXQgd2lsbCBm YWxsYmFjayB0byByZWFkaW5nIGVhY2ggYXhpcyBhcyBhIHNlcGFyYXRlIHdvcmQgaW4gY2FzZSBp MmMNCj4gPiA+IGJsb2NrIHJlYWQgaXMgbm90IHN1cHBvcnRlZC4NCj4gPiA+DQo+ID4gPiBTaWdu ZWQtb2ZmLWJ5OiBJcmluYSBUaXJkZWEgPGlyaW5hLnRpcmRlYUBpbnRlbC5jb20+DQo+ID4gQWNr ZWQtYnk6IEpvbmF0aGFuIENhbWVyb24gPGppYzIzQGtlcm5lbC5vcmc+DQo+ID4gDQo+IA0KPiBU aGFua3MgSm9uYXRoYW4hDQo+IA0KPiA+IE9idmlvdXNseSB5b3UnbGwgaWRlYWxseSBwaWNrIHVw IEFjaydzIGZyb20gdGhlIGRyaXZlciBhdXRob3JzIC9tYWludGFpbmVycw0KPiA+IGFzIHdlbGwu DQo+ID4gDQo+IA0KPiBTcmluaXZhcywgYXJlIHlvdSBPSyB3aXRoIHRoZXNlIGNoYW5nZXMgZm9y IGJtYzE1MCwgYm1nMTYwIGFuZCBreGNqay0xMDEzPw0KPiANClllcy4NCg0KQWNrZWQtYnk6IFNy aW5pdmFzIFBhbmRydXZhZGEgPHNyaW5pdmFzLnBhbmRydXZhZGFAbGludXguaW50ZWwuY29tPg0K DQo+IFRoYW5rcywNCj4gSXJpbmENCj4gDQo+ID4gSm9uYXRoYW4NCj4gPiA+IC0tLQ0KPiA+ID4g IGRyaXZlcnMvaWlvL2d5cm8vYm1nMTYwLmMgfCAxOCArKysrKysrKy0tLS0tLS0tLS0NCj4gPiA+ ICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkNCj4gPiA+ DQo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9paW8vZ3lyby9ibWcxNjAuYyBiL2RyaXZlcnMv aWlvL2d5cm8vYm1nMTYwLmMNCj4gPiA+IGluZGV4IDRiNDIzZjIuLjA0ZTE1ZTkgMTAwNjQ0DQo+ ID4gPiAtLS0gYS9kcml2ZXJzL2lpby9neXJvL2JtZzE2MC5jDQo+ID4gPiArKysgYi9kcml2ZXJz L2lpby9neXJvL2JtZzE2MC5jDQo+ID4gPiBAQCAtNzg0LDYgKzc4NCw3IEBAIHN0YXRpYyBjb25z dCBzdHJ1Y3QgaWlvX2V2ZW50X3NwZWMgYm1nMTYwX2V2ZW50ID0gew0KPiA+ID4gIAkJLnNpZ24g PSAncycsCQkJCQkJXA0KPiA+ID4gIAkJLnJlYWxiaXRzID0gMTYsCQkJCQlcDQo+ID4gPiAgCQku c3RvcmFnZWJpdHMgPSAxNiwJCQkJCVwNCj4gPiA+ICsJCS5lbmRpYW5uZXNzID0gSUlPX0xFLAkJ CQkJXA0KPiA+ID4gIAl9LAkJCQkJCQkJXA0KPiA+ID4gIAkuZXZlbnRfc3BlYyA9ICZibWcxNjBf ZXZlbnQsCQkJCQlcDQo+ID4gPiAgCS5udW1fZXZlbnRfc3BlY3MgPSAxCQkJCQkJXA0KPiA+ID4g QEAgLTgyMiwxOSArODIzLDE2IEBAIHN0YXRpYyBpcnFyZXR1cm5fdCBibWcxNjBfdHJpZ2dlcl9o YW5kbGVyKGludCBpcnEsIHZvaWQgKnApDQo+ID4gPiAgCXN0cnVjdCBpaW9fcG9sbF9mdW5jICpw ZiA9IHA7DQo+ID4gPiAgCXN0cnVjdCBpaW9fZGV2ICppbmRpb19kZXYgPSBwZi0+aW5kaW9fZGV2 Ow0KPiA+ID4gIAlzdHJ1Y3QgYm1nMTYwX2RhdGEgKmRhdGEgPSBpaW9fcHJpdihpbmRpb19kZXYp Ow0KPiA+ID4gLQlpbnQgYml0LCByZXQsIGkgPSAwOw0KPiA+ID4gKwlpbnQgcmV0ID0gMDsNCj4g PiA+DQo+ID4gPiAgCW11dGV4X2xvY2soJmRhdGEtPm11dGV4KTsNCj4gPiA+IC0JZm9yIChiaXQg PSAwOyBiaXQgPCBBWElTX01BWDsgYml0KyspIHsNCj4gPiA+IC0JCXJldCA9IGkyY19zbWJ1c19y ZWFkX3dvcmRfZGF0YShkYXRhLT5jbGllbnQsDQo+ID4gPiAtCQkJCQkgICAgICAgQk1HMTYwX0FY SVNfVE9fUkVHKGJpdCkpOw0KPiA+ID4gLQkJaWYgKHJldCA8IDApIHsNCj4gPiA+IC0JCQltdXRl eF91bmxvY2soJmRhdGEtPm11dGV4KTsNCj4gPiA+IC0JCQlnb3RvIGVycjsNCj4gPiA+IC0JCX0N Cj4gPiA+IC0JCWRhdGEtPmJ1ZmZlcltpKytdID0gcmV0Ow0KPiA+ID4gLQl9DQo+ID4gPiArCXJl dCA9IGkyY19zbWJ1c19yZWFkX2kyY19ibG9ja19kYXRhX29yX2VtdWxhdGVkKGRhdGEtPmNsaWVu dCwNCj4gPiA+ICsJCQkJCQkJQk1HMTYwX1JFR19YT1VUX0wsDQo+ID4gPiArCQkJCQkJCUFYSVNf TUFYICogMiwNCj4gPiA+ICsJCQkJCQkJKHU4ICopZGF0YS0+YnVmZmVyKTsNCj4gPiA+ICAJbXV0 ZXhfdW5sb2NrKCZkYXRhLT5tdXRleCk7DQo+ID4gPiArCWlmIChyZXQgPCAwKQ0KPiA+ID4gKwkJ Z290byBlcnI7DQo+ID4gPg0KPiA+ID4gIAlpaW9fcHVzaF90b19idWZmZXJzX3dpdGhfdGltZXN0 YW1wKGluZGlvX2RldiwgZGF0YS0+YnVmZmVyLA0KPiA+ID4gIAkJCQkJICAgZGF0YS0+dGltZXN0 YW1wKTsNCj4gPiA+DQo+IA0KDQo= -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web