Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1181379 > unrolled thread
| Started by | Paul Bolle <pebolle@tiscali.nl> |
|---|---|
| First post | 2015-07-10 10:40 +0200 |
| Last post | 2015-07-10 19:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver Paul Bolle <pebolle@tiscali.nl> - 2015-07-10 10:40 +0200
Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver Scott Wood <scottwood@freescale.com> - 2015-07-10 19:40 +0200
| From | Paul Bolle <pebolle@tiscali.nl> |
|---|---|
| Date | 2015-07-10 10:40 +0200 |
| Subject | Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver |
| Message-ID | <pKC0G-3Bu-27@gated-at.bofh.it> |
On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote:
> --- /dev/null
> +++ b/drivers/soc/fsl/qbman/Kconfig
> @@ -0,0 +1,33 @@
> +menuconfig FSL_DPA
> + bool "Freescale DPAA support"
> + depends on FSL_SOC || COMPILE_TEST
Are you sure about COMPILE_TEST?
> + default n
> + help
> + FSL Data-Path Acceleration Architecture drivers
> +
> + These are not the actual Ethernet driver(s)
> +
> +if FSL_DPA
[...]
> +config FSL_BMAN
> + tristate "BMan device management"
> + default n
> + help
> + FSL DPAA BMan driver
> +
> +endif # FSL_DPA
Because with FSL_BMAN set to 'm' testing things with
make -C ../../../.. M=$PWD bman.ko
will not actually compile on x86_64:
make: Entering directory '[...]'
CC [M] [...]/drivers/soc/fsl/qbman/bman.o
In file included from [...]/drivers/soc/fsl/qbman/bman_priv.h:33:0,
from [...]/drivers/soc/fsl/qbman/bman.c:31:
[...]/drivers/soc/fsl/qbman/dpaa_sys.h: In function ‘mfatb’:
[...]/drivers/soc/fsl/qbman/dpaa_sys.h:134:8: error: implicit declaration of function ‘mfspr’ [-Werror=implicit-function-declaration]
hi = mfspr(SPRN_ATBU);
^
[...]/drivers/soc/fsl/qbman/dpaa_sys.h:134:14: error: ‘SPRN_ATBU’ undeclared (first use in this function)
hi = mfspr(SPRN_ATBU);
^
[...]/drivers/soc/fsl/qbman/dpaa_sys.h:134:14: note: each undeclared identifier is reported only once for each function it appears in
[...]/drivers/soc/fsl/qbman/dpaa_sys.h:135:14: error: ‘SPRN_ATBL’ undeclared (first use in this function)
lo = mfspr(SPRN_ATBL);
^
[...]/drivers/soc/fsl/qbman/bman.c: In function ‘__bm_in’:
[...]/drivers/soc/fsl/qbman/bman.c:168:9: error: implicit declaration of function ‘in_be32’ [-Werror=implicit-function-declaration]
return in_be32((void *)bm + offset);
^
[...]/drivers/soc/fsl/qbman/bman.c: In function ‘__bm_out’:
[...]/drivers/soc/fsl/qbman/bman.c:172:2: error: implicit declaration of function ‘out_be32’ [-Werror=implicit-function-declaration]
out_be32((void *)bm + offset, val);
^
[...]/drivers/soc/fsl/qbman/bman.c: In function ‘of_fsl_bman_probe’:
[...]/drivers/soc/fsl/qbman/bman.c:463:17: error: ‘NO_IRQ’ undeclared (first use in this function)
if (err_irq == NO_IRQ) {
^
cc1: some warnings being treated as errors
scripts/Makefile.build:264: recipe for target '[...]/drivers/soc/fsl/qbman/bman.o' failed
make[1]: *** [[...]/drivers/soc/fsl/qbman/bman.o] Error 1
Makefile:1568: recipe for target 'bman.ko' failed
make: *** [bman.ko] Error 2
make: Leaving directory '[...]'
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Scott Wood <scottwood@freescale.com> |
|---|---|
| Date | 2015-07-10 19:40 +0200 |
| Message-ID | <pKKrh-t8-41@gated-at.bofh.it> |
| In reply to | #1181379 |
On Fri, 2015-07-10 at 10:38 +0200, Paul Bolle wrote:
> On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote:
> > --- /dev/null
> > +++ b/drivers/soc/fsl/qbman/Kconfig
> > @@ -0,0 +1,33 @@
> > +menuconfig FSL_DPA
> > + bool "Freescale DPAA support"
> > + depends on FSL_SOC || COMPILE_TEST
>
> Are you sure about COMPILE_TEST?
>
> > + default n
> > + help
> > + FSL Data-Path Acceleration Architecture drivers
> > +
> > + These are not the actual Ethernet driver(s)
> > +
> > +if FSL_DPA
>
> [...]
>
> > +config FSL_BMAN
> > + tristate "BMan device management"
> > + default n
> > + help
> > + FSL DPAA BMan driver
> > +
> > +endif # FSL_DPA
>
> Because with FSL_BMAN set to 'm' testing things with
> make -C ../../../.. M=$PWD bman.ko
>
> will not actually compile on x86_64:
>
> make: Entering directory '[...]'
> CC [M] [...]/drivers/soc/fsl/qbman/bman.o
> In file included from [...]/drivers/soc/fsl/qbman/bman_priv.h:33:0,
> from [...]/drivers/soc/fsl/qbman/bman.c:31:
> [...]/drivers/soc/fsl/qbman/dpaa_sys.h: In function ‘mfatb’:
> [...]/drivers/soc/fsl/qbman/dpaa_sys.h:134:8: error: implicit declaration
> of function ‘mfspr’ [-Werror=implicit-function-declaration]
> hi = mfspr(SPRN_ATBU);
> ^
> [...]/drivers/soc/fsl/qbman/dpaa_sys.h:134:14: error: ‘SPRN_ATBU’
> undeclared (first use in this function)
> hi = mfspr(SPRN_ATBU);
> ^
> [...]/drivers/soc/fsl/qbman/dpaa_sys.h:134:14: note: each undeclared
> identifier is reported only once for each function it appears in
> [...]/drivers/soc/fsl/qbman/dpaa_sys.h:135:14: error: ‘SPRN_ATBL’
> undeclared (first use in this function)
> lo = mfspr(SPRN_ATBL);
> ^
> [...]/drivers/soc/fsl/qbman/bman.c: In function ‘__bm_in’:
> [...]/drivers/soc/fsl/qbman/bman.c:168:9: error: implicit declaration of
> function ‘in_be32’ [-Werror=implicit-function-declaration]
> return in_be32((void *)bm + offset);
> ^
> [...]/drivers/soc/fsl/qbman/bman.c: In function ‘__bm_out’:
> [...]/drivers/soc/fsl/qbman/bman.c:172:2: error: implicit declaration of
> function ‘out_be32’ [-Werror=implicit-function-declaration]
> out_be32((void *)bm + offset, val);
These PPCisms will need to be fixed. LS1043A is an ARM chip with DPAA 1.0.
> ^
> [...]/drivers/soc/fsl/qbman/bman.c: In function ‘of_fsl_bman_probe’:
> [...]/drivers/soc/fsl/qbman/bman.c:463:17: error: ‘NO_IRQ’ undeclared
> (first use in this function)
> if (err_irq == NO_IRQ) {
This isn't even a PPCism. It's just wrong. Compare to zero instead.
-Scott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web