Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1180316 > unrolled thread

Re: [PATCH] hugetlb:Make the function vma_shareable bool

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] hugetlb:Make the function vma_shareable bool David Rientjes <rientjes@google.com> - 2015-07-09 02:00 +0200

#1180316 — Re: [PATCH] hugetlb:Make the function vma_shareable bool

On Wed, 1 Jul 2015, nick wrote:

> David,
> This was already acknowledged, however I am over 150 different patches lying
> around on my system for various fixes/cleanups in many different subsystems
> and based on my rep people seem to be just ignoring them. If someone looks 
> at them first they should go through. Below is a patch for fixing a bug in
> the Intel network drivers.

./scripts/get_maintainer.pl suggests this should go to 
Jeff Kirsher <jeffrey.t.kirsher@intel.com> for review.

It looks like a cleanup that would only suppress output to the kernel log, 
so might be better to just make this function void.

You might also have luck with the "TRIVIAL PATCHES" section of 
./MAINTAINERS for things like this.

> Nick
> From 950ace789c2cc371233ea0204e9baccfea7630bc Mon Sep 17 00:00:00 2001
> From: Nicholas Krause <xerofoify@gmail.com>
> Date: Mon, 29 Jun 2015 22:55:22 -0400
> Subject: [PATCH] i40e:Return -ENODEV if hardware has no support for certain
>  required features in the function i40e_init_pf_fcoe
> 
> This makes the function i40e_init_pf_fcoe correctly return -ENODEV
> as a error return for when the underlying hardware does not have
> support for FCOE or DCB rather then 0 to it's callers in order
> to comply with checks run by these particular function's callers
> to find out if the underlying hardware supports these features.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c
> index c8b621e..24a44dd 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c
> @@ -273,7 +273,8 @@ out:
>   * i40e_fcoe_sw_init - sets up the HW for FCoE
>   * @pf: pointer to PF
>   *
> - * Returns 0 if FCoE is supported otherwise the error code
> + * Returns 0 if FCoE is supported otherwise  -ENODEV if
> + * the hardware does not support it
>   **/
>  int i40e_init_pf_fcoe(struct i40e_pf *pf)
>  {
> @@ -287,13 +288,13 @@ int i40e_init_pf_fcoe(struct i40e_pf *pf)
>  
>  	if (!pf->hw.func_caps.fcoe) {
>  		dev_info(&pf->pdev->dev, "FCoE capability is disabled\n");
> -		return 0;
> +		return -ENODEV;
>  	}
>  
>  	if (!pf->hw.func_caps.dcb) {
>  		dev_warn(&pf->pdev->dev,
>  			 "Hardware is not DCB capable not enabling FCoE.\n");
> -		return 0;
> +		return -ENODEV;
>  	}
>  
>  	/* enable FCoE hash filter */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web