Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1178332 > unrolled thread

Re: [PATCH 3/6] Input: pixcir_i2c_ts - allow using with GPIO expanders

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 3/6] Input: pixcir_i2c_ts - allow using with GPIO expanders Roger Quadros <rogerq@ti.com> - 2015-07-07 13:00 +0200

#1178332 — Re: [PATCH 3/6] Input: pixcir_i2c_ts - allow using with GPIO expanders

On 07/07/15 03:30, Dmitry Torokhov wrote:
> We are using threaded interrupt handler and thus are allowed to sleep.
> Let's switch over to gpiod_get_value_cansleep() so that we do not get
> ugly warnings in case GPIO controller might sleep when accessing GPIO.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Acked-by: Roger Quadros <rogerq@ti.com>

cheers,
-roger

> ---
>   drivers/input/touchscreen/pixcir_i2c_ts.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c
> index 9093aa9..8965d7c 100644
> --- a/drivers/input/touchscreen/pixcir_i2c_ts.c
> +++ b/drivers/input/touchscreen/pixcir_i2c_ts.c
> @@ -171,7 +171,7 @@ static irqreturn_t pixcir_ts_isr(int irq, void *dev_id)
>   		/* report it */
>   		pixcir_ts_report(tsdata, &report);
>
> -		if (gpiod_get_value(tsdata->gpio_attb)) {
> +		if (gpiod_get_value_cansleep(tsdata->gpio_attb)) {
>   			if (report.num_touches) {
>   				/*
>   				 * Last report with no finger up?
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web