Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1178287 > unrolled thread

Re: [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature Paul Bolle <pebolle@tiscali.nl> - 2015-07-07 11:40 +0200
    Re: [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature Olaf Hering <olaf@aepfle.de> - 2015-07-07 12:20 +0200
      Re: [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature Olaf Hering <olaf@aepfle.de> - 2015-07-07 13:00 +0200

#1178287 — Re: [PATCH 6/7] hvsock: introduce Hyper-V VM Sockets feature

Just two nits.

On ma, 2015-07-06 at 07:47 -0700, Dexuan Cui wrote:
> --- /dev/null
> +++ b/net/hv_sock/Kconfig

> +config HYPERV_SOCK
> +	tristate "Microsoft Hyper-V Socket (EXPERIMENTAL)"
> +	depends on HYPERV
> +	default m
> +	help
> +	  Hyper-V Socket is a socket protocol similar to TCP, allowing
> +	  communication between a Linux guest and the host.
> +
> +	  To compile this driver as a module, choose M here: the module
> +	  will be called hv_sock. If unsure, say N.

It's a bit odd to advise to say N if one is unsure and set the default
to 'm' at the same time.

> --- /dev/null
> +++ b/net/hv_sock/af_hvsock.c

> +static int hvsock_init(void)
> +{
> +	[...]
> +}
> +
> +static void hvsock_exit(void)
> +{
> +	[...]
> +}
> +
> +module_init(hvsock_init);
> +module_exit(hvsock_exit);

Any specific reason not to mark these functions __init and __exit?

Thanks,


Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1178307

On Tue, Jul 07, Paul Bolle wrote:

> On ma, 2015-07-06 at 07:47 -0700, Dexuan Cui wrote:
> > --- /dev/null
> > +++ b/net/hv_sock/Kconfig
> 
> > +config HYPERV_SOCK
> > +	tristate "Microsoft Hyper-V Socket (EXPERIMENTAL)"
> > +	depends on HYPERV
> > +	default m

> It's a bit odd to advise to say N if one is unsure and set the default
> to 'm' at the same time.

The 'default' line has to be removed IMO.

Olaf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1178355

On Tue, Jul 07, Dexuan Cui wrote:

> OK, removing the line seems better than 'default n', though both reproduce
> the same "# CONFIG_HYPERV_SOCK is not set".

Perhaps "default VMBUS" (or whatever syntax is needed) may be the way to
enable it conditionally.

Olaf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web