Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1176849 > unrolled thread

[PATCH] cris: arch-v10: kernel: kgdb: let is_dyn_brkp as extern variable

Back to article view | Back to linux.kernel

Contents

  [PATCH] cris: arch-v10: kernel: kgdb: let is_dyn_brkp as extern variable Chen Gang <xili_gchen_5257@hotmail.com> - 2015-07-05 10:30 +0200
    Re: [PATCH] cris: arch-v10: kernel: kgdb: let is_dyn_brkp as extern  variable Chen Gang <xili_gchen_5257@hotmail.com> - 2015-07-07 00:30 +0200

#1176849 — [PATCH] cris: arch-v10: kernel: kgdb: let is_dyn_brkp as extern variable

For upstream cris toolchain (gcc is 6.0, gas and ld are 2.25.51), they
can not recognize the static variable between embedded global asm code
and local C code.

So let it as extern variable to let the related code pass building, it
is harmless for real world using (although it is not quite well for
coding styles).

The related error (with allmodconfig under cris for next-20150702):

  arch/cris/arch-v10/kernel/built-in.o: In function `kgdb_handle_breakpoint':
  (.text+0x2aca): undefined reference to `is_dyn_brkp'
  arch/cris/arch-v10/kernel/built-in.o: In function `is_static':
  kgdb.c:(.text+0x2ada): undefined reference to `is_dyn_brkp'


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 arch/cris/arch-v10/kernel/kgdb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/cris/arch-v10/kernel/kgdb.c b/arch/cris/arch-v10/kernel/kgdb.c
index 22d846b..3553406 100644
--- a/arch/cris/arch-v10/kernel/kgdb.c
+++ b/arch/cris/arch-v10/kernel/kgdb.c
@@ -351,7 +351,7 @@ char internal_stack[INTERNAL_STACK_SIZE];
    breakpoint to be handled. A static breakpoint uses the content of register
    BRP as it is whereas a dynamic breakpoint requires subtraction with 2
    in order to execute the instruction. The first breakpoint is static. */
-static unsigned char is_dyn_brkp = 0;
+unsigned char is_dyn_brkp;
 
 /********************************* String library ****************************/
 /* Single-step over library functions creates trap loops. */
-- 
1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1177944 — Re: [PATCH] cris: arch-v10: kernel: kgdb: let is_dyn_brkp as extern variable

On 7/6/15 18:31, Valdis.Kletnieks@vt.edu wrote:
> On Mon, 06 Jul 2015 15:49:20 +0800, Chen Gang said:
>> On 07/06/2015 02:25 AM, Valdis.Kletnieks@vt.edu wrote:
>>> On Sun, 05 Jul 2015 06:07:54 +0800, Chen Gang said:
>>>> For upstream cris toolchain (gcc is 6.0
>>>
>>> typo?
>>>
>>
>> Do you mean "toolchain" -> "tool chain"?
> 
> No, I was wondering where a gcc 6.0 managed to escape when 5.1 just got
> released about 2 weeks ago....
> 

OK, thanks. At present, gcc 6.0 is the latest in master branch.

After check fedora released toolchain (gcc 4.9.1, binutils 2.25), it has
no issue (support static variable in our case). So this patch can be
dropped, and I shall try:

 - Use the same configuration parameters of fedora released toolchain to
   build the upstream latest cross toolchain again, and try.

 - If it still has issue (not support static variable), I shall try to
   fix it.


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web