Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1179868 > unrolled thread

[PATCH RESEND] iio: adc: rockchip_saradc: add missing MODULE_* data

Back to article view | Back to linux.kernel

Contents

  [PATCH RESEND] iio: adc: rockchip_saradc: add missing MODULE_* data Heiko Stuebner <heiko@sntech.de> - 2015-07-08 16:20 +0200
    Re: [PATCH RESEND] iio: adc: rockchip_saradc: add missing MODULE_*  data Jonathan Cameron <jic23@kernel.org> - 2015-07-11 19:40 +0200
      Re: [PATCH RESEND] iio: adc: rockchip_saradc: add missing MODULE_* data Jonathan Cameron <jic23@kernel.org> - 2015-07-13 11:30 +0200

#1179868 — [PATCH RESEND] iio: adc: rockchip_saradc: add missing MODULE_* data

The module-data is currently missing. This includes the license-information
which makes the driver taint the kernel and miss symbols when compiled as
module.

Fixes: 44d6f2ef94f9 ("iio: adc: add driver for Rockchip saradc")
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 drivers/iio/adc/rockchip_saradc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
index 8d4e019..9c311c1 100644
--- a/drivers/iio/adc/rockchip_saradc.c
+++ b/drivers/iio/adc/rockchip_saradc.c
@@ -349,3 +349,7 @@ static struct platform_driver rockchip_saradc_driver = {
 };
 
 module_platform_driver(rockchip_saradc_driver);
+
+MODULE_AUTHOR("Heiko Stuebner <heiko@sntech.de>");
+MODULE_DESCRIPTION("Rockchip SARADC driver");
+MODULE_LICENSE("GPL v2");
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1182196 — Re: [PATCH RESEND] iio: adc: rockchip_saradc: add missing MODULE_* data

On 08/07/15 15:17, Heiko Stuebner wrote:
> The module-data is currently missing. This includes the license-information
> which makes the driver taint the kernel and miss symbols when compiled as
> module.
> 
> Fixes: 44d6f2ef94f9 ("iio: adc: add driver for Rockchip saradc")
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Sorry Heiko,

Not entirely sure why I haven't picked this up before.

Anyhow, now applied to the fixes-for-4.2 branch of iio.git
and marked for stable.  I need to catch up with a bit of a
backlog, but should get a pull request out to Greg sometime
early next week.

Jonathan
> ---
>  drivers/iio/adc/rockchip_saradc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> index 8d4e019..9c311c1 100644
> --- a/drivers/iio/adc/rockchip_saradc.c
> +++ b/drivers/iio/adc/rockchip_saradc.c
> @@ -349,3 +349,7 @@ static struct platform_driver rockchip_saradc_driver = {
>  };
>  
>  module_platform_driver(rockchip_saradc_driver);
> +
> +MODULE_AUTHOR("Heiko Stuebner <heiko@sntech.de>");
> +MODULE_DESCRIPTION("Rockchip SARADC driver");
> +MODULE_LICENSE("GPL v2");
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1182626

On 11 July 2015 19:59:31 BST, "Heiko Stübner" <heiko@sntech.de> wrote:
>Hi Jonathan,
>
>Am Samstag, 11. Juli 2015, 18:32:42 schrieb Jonathan Cameron:
>> On 08/07/15 15:17, Heiko Stuebner wrote:
>> > The module-data is currently missing. This includes the
>> > license-information
>> > which makes the driver taint the kernel and miss symbols when
>compiled as
>> > module.
>> > 
>> > Fixes: 44d6f2ef94f9 ("iio: adc: add driver for Rockchip saradc")
>> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
>> 
>> Sorry Heiko,
>> 
>> Not entirely sure why I haven't picked this up before.
>> 
>> Anyhow, now applied to the fixes-for-4.2 branch of iio.git
>> and marked for stable.  I need to catch up with a bit of a
>> backlog, but should get a pull request out to Greg sometime
>> early next week.
>
>really no problem. I track my patches and generally simply keep
>pestering 
>people for as long as it takes ;-)
>
Very sensible!
>Heiko

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web