Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1176852 > unrolled thread

[PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV_LOOKUP

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV_LOOKUP Chen Gang <xili_gchen_5257@hotmail.com> - 2015-07-05 10:30 +0200
    Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on  CLKDEV_LOOKUP Chen Gang <xili_gchen_5257@hotmail.com> - 2015-07-06 04:40 +0200

#1176852 — [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV_LOOKUP

It needs clk_add_alias() from clk drivers, which is implemented in
"drivers/clk/clkdev.c" which depends on CLKDEV_LOOKUP.

Normally, archs and clk driver its own will decide whether select
CLKDEV_LOOKUP, and common drivers will decide whether depend on it.

The related error (with allmodconfig under cris for next-20150702):

  drivers/built-in.o: In function `board_staging_register_clock':
  drivers/staging/board/board.c:131: undefined reference to `clk_add_alias'


Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
 drivers/staging/board/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/board/Kconfig b/drivers/staging/board/Kconfig
index b8ee818..4ff5a79 100644
--- a/drivers/staging/board/Kconfig
+++ b/drivers/staging/board/Kconfig
@@ -1,6 +1,6 @@
 config STAGING_BOARD
 	bool "Staging Board Support"
-	depends on OF_ADDRESS
+	depends on OF_ADDRESS && CLKDEV_LOOKUP
 	help
 	  Select to enable per-board staging support code.
 
-- 
1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1177096 — Re: [PATCH] staging: board: Kconfig: Let STAGING_BOARD depend on CLKDEV_LOOKUP

On 07/06/2015 06:48 AM, Stephen Rothwell wrote:
> Hi all,
> 
> On Sun, 5 Jul 2015 18:57:51 +0200 Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>>
>> On Sat, Jul 4, 2015 at 11:35 PM, Chen Gang <xili_gchen_5257@hotmail.com> wrote:
>>> It needs clk_add_alias() from clk drivers, which is implemented in
>>> "drivers/clk/clkdev.c" which depends on CLKDEV_LOOKUP.
>>>
>>> Normally, archs and clk driver its own will decide whether select
>>> CLKDEV_LOOKUP, and common drivers will decide whether depend on it.
>>>
>>> The related error (with allmodconfig under cris for next-20150702):
>>>
>>>   drivers/built-in.o: In function `board_staging_register_clock':
>>>   drivers/staging/board/board.c:131: undefined reference to `clk_add_alias'
>>>
>>>
>>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>>
>> Fix available for the last 15 days:
>>
>> https://lkml.org/lkml/2015/6/20/215
> 
> I added Chen's patch to my fixes tree today (only because I couldn't
> easily find a copy of Paul's patch (sorry Paul) i.e. how does one get a
> full mail message from lkml.org?  Or Geert, maybe that is not the best
> place to link to.
> 

For me, I still suggest to use Paul's patch (if it is OK, too). He sent
the patch more than 10 days, and was still waiting patiently.

There will be a little more work, but I guess, it is necessary.

And I shall try to send another patches for Linux kernel. :-)

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web