Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1176885 > unrolled thread

Re: [PATCH 16/41] clocksource: pxa: Migrate to new 'set-state' interface

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 16/41] clocksource: pxa: Migrate to new 'set-state' interface Robert Jarzmik <robert.jarzmik@free.fr> - 2015-07-05 10:50 +0200
    Re: [PATCH 16/41] clocksource: pxa: Migrate to new 'set-state'  interface Viresh Kumar <viresh.kumar@linaro.org> - 2015-07-05 11:00 +0200

#1176885 — Re: [PATCH 16/41] clocksource: pxa: Migrate to new 'set-state' interface

Viresh Kumar <viresh.kumar@linaro.org> writes:

> @@ -88,26 +88,12 @@ pxa_osmr0_set_next_event(unsigned long delta, struct clock_event_device *dev)
>  	return (signed)(next - oscr) <= MIN_OSCR_DELTA ? -ETIME : 0;
>  }
>  
> -static void
> -pxa_osmr0_set_mode(enum clock_event_mode mode, struct clock_event_device *dev)
> +static int pxa_osmr0_shutdown(struct clock_event_device *evt)
>  {
> -	switch (mode) {
> -	case CLOCK_EVT_MODE_ONESHOT:
> -		timer_writel(timer_readl(OIER) & ~OIER_E0, OIER);
> -		timer_writel(OSSR_M0, OSSR);
> -		break;
> -
> -	case CLOCK_EVT_MODE_UNUSED:
> -	case CLOCK_EVT_MODE_SHUTDOWN:
> -		/* initializing, released, or preparing for suspend */
> -		timer_writel(timer_readl(OIER) & ~OIER_E0, OIER);
> -		timer_writel(OSSR_M0, OSSR);
> -		break;
> -
> -	case CLOCK_EVT_MODE_RESUME:
> -	case CLOCK_EVT_MODE_PERIODIC:
> -		break;
> -	}
> +	/* initializing, released, or preparing for suspend */
> +	timer_writel(timer_readl(OIER) & ~OIER_E0, OIER);
> +	timer_writel(OSSR_M0, OSSR);
> +	return 0;
For consistency, please leave an empty line before that return statement.

> @@ -147,13 +133,14 @@ static void pxa_timer_resume(struct clock_event_device *cedev)
>  #endif
>  
>  static struct clock_event_device ckevt_pxa_osmr0 = {
> -	.name		= "osmr0",
> -	.features	= CLOCK_EVT_FEAT_ONESHOT,
> -	.rating		= 200,
> -	.set_next_event	= pxa_osmr0_set_next_event,
> -	.set_mode	= pxa_osmr0_set_mode,
> -	.suspend	= pxa_timer_suspend,
> -	.resume		= pxa_timer_resume,
> +	.name			= "osmr0",
> +	.features		= CLOCK_EVT_FEAT_ONESHOT,
> +	.rating			= 200,
> +	.set_next_event		= pxa_osmr0_set_next_event,
> +	.set_state_shutdown	= pxa_osmr0_shutdown,
> +	.set_state_oneshot	= pxa_osmr0_shutdown,
A bit weird to have a "set_state_oneshot" function to point to a function called
"X_shutdown". As I don't have a clear idea on what's this new interface for,
I'll just hope it's the intended purpose. The code does look equivalent to me
anyway.

Apart from the cosmetic comment, once it is fixed :
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1176905 — Re: [PATCH 16/41] clocksource: pxa: Migrate to new 'set-state' interface

Hi Robert,

On 04-07-15, 17:42, Robert Jarzmik wrote:
> > +	/* initializing, released, or preparing for suspend */
> > +	timer_writel(timer_readl(OIER) & ~OIER_E0, OIER);
> > +	timer_writel(OSSR_M0, OSSR);
> > +	return 0;
> For consistency, please leave an empty line before that return statement.

Its already applied by Daniel now, and the change is too trivial to
request for an update to his tree. Maybe we should leave it as is for
now.

> > @@ -147,13 +133,14 @@ static void pxa_timer_resume(struct clock_event_device *cedev)
> >  #endif
> >  
> >  static struct clock_event_device ckevt_pxa_osmr0 = {
> > -	.name		= "osmr0",
> > -	.features	= CLOCK_EVT_FEAT_ONESHOT,
> > -	.rating		= 200,
> > -	.set_next_event	= pxa_osmr0_set_next_event,
> > -	.set_mode	= pxa_osmr0_set_mode,
> > -	.suspend	= pxa_timer_suspend,
> > -	.resume		= pxa_timer_resume,
> > +	.name			= "osmr0",
> > +	.features		= CLOCK_EVT_FEAT_ONESHOT,
> > +	.rating			= 200,
> > +	.set_next_event		= pxa_osmr0_set_next_event,
> > +	.set_state_shutdown	= pxa_osmr0_shutdown,
> > +	.set_state_oneshot	= pxa_osmr0_shutdown,
> A bit weird to have a "set_state_oneshot" function to point to a function called
> "X_shutdown".

What's weird (or looks weird) is that we stop the timer when requested
to switch to oneshot mode. But that's what we really wanted, because
set_next_event is the one that will program the timer in oneshot mode.

> As I don't have a clear idea on what's this new interface for,

It just provides per-state API's for what's being done in set_mode()
earlier.

> I'll just hope it's the intended purpose. The code does look equivalent to me
> anyway.
> 
> Apart from the cosmetic comment, once it is fixed :
> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Thanks.

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web