Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1176428 > unrolled thread
| Started by | Antoine Tenart <antoine.tenart@free-electrons.com> |
|---|---|
| First post | 2015-07-03 11:20 +0200 |
| Last post | 2015-07-03 16:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 4/4] phy: berlin-usb: rename table copied from SATA PHY Antoine Tenart <antoine.tenart@free-electrons.com> - 2015-07-03 11:20 +0200
Re: [PATCH 4/4] phy: berlin-usb: rename table copied from SATA PHY Thomas Hebb <tommyhebb@gmail.com> - 2015-07-03 16:40 +0200
| From | Antoine Tenart <antoine.tenart@free-electrons.com> |
|---|---|
| Date | 2015-07-03 11:20 +0200 |
| Subject | Re: [PATCH 4/4] phy: berlin-usb: rename table copied from SATA PHY |
| Message-ID | <pI5iy-6Fa-29@gated-at.bofh.it> |
Thomas,
On Thu, Jul 02, 2015 at 01:04:30AM -0400, Thomas Hebb wrote:
> We're not in a SATA PHY driver, so the of_match table shouldn't have
> "sata" in its name.
There is already a patch fixing this (which was sent last week):
https://lkml.org/lkml/2015/6/24/103
You can drop this one from the series.
Antoine
>
> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
> Suggested-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
> drivers/phy/phy-berlin-usb.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
> index 335e06d..7143cd3 100644
> --- a/drivers/phy/phy-berlin-usb.c
> +++ b/drivers/phy/phy-berlin-usb.c
> @@ -152,7 +152,7 @@ static struct phy_ops phy_berlin_usb_ops = {
> .owner = THIS_MODULE,
> };
>
> -static const struct of_device_id phy_berlin_sata_of_match[] = {
> +static const struct of_device_id phy_berlin_usb_of_match[] = {
> {
> .compatible = "marvell,berlin2-usb-phy",
> .data = &phy_berlin_pll_dividers[0],
> @@ -163,12 +163,12 @@ static const struct of_device_id phy_berlin_sata_of_match[] = {
> },
> { },
> };
> -MODULE_DEVICE_TABLE(of, phy_berlin_sata_of_match);
> +MODULE_DEVICE_TABLE(of, phy_berlin_usb_of_match);
>
> static int phy_berlin_usb_probe(struct platform_device *pdev)
> {
> const struct of_device_id *match =
> - of_match_device(phy_berlin_sata_of_match, &pdev->dev);
> + of_match_device(phy_berlin_usb_of_match, &pdev->dev);
> struct phy_berlin_usb_priv *priv;
> struct resource *res;
> struct phy *phy;
> @@ -208,7 +208,7 @@ static struct platform_driver phy_berlin_usb_driver = {
> .driver = {
> .name = "phy-berlin-usb",
> .owner = THIS_MODULE,
> - .of_match_table = phy_berlin_sata_of_match,
> + .of_match_table = phy_berlin_usb_of_match,
> },
> };
> module_platform_driver(phy_berlin_usb_driver);
> --
> 2.4.4
>
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Thomas Hebb <tommyhebb@gmail.com> |
|---|---|
| Date | 2015-07-03 16:40 +0200 |
| Message-ID | <pIaid-1dJ-11@gated-at.bofh.it> |
| In reply to | #1176428 |
On 07/03/2015 05:18 AM, Antoine Tenart wrote:
> Thomas,
>
> On Thu, Jul 02, 2015 at 01:04:30AM -0400, Thomas Hebb wrote:
>> We're not in a SATA PHY driver, so the of_match table shouldn't have
>> "sata" in its name.
>
> There is already a patch fixing this (which was sent last week):
>
> https://lkml.org/lkml/2015/6/24/103
>
> You can drop this one from the series.
>
> Antoine
Acknowledged. Sorry for the noise.
-Tom
>>
>> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
>> Suggested-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>> ---
>> drivers/phy/phy-berlin-usb.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
>> index 335e06d..7143cd3 100644
>> --- a/drivers/phy/phy-berlin-usb.c
>> +++ b/drivers/phy/phy-berlin-usb.c
>> @@ -152,7 +152,7 @@ static struct phy_ops phy_berlin_usb_ops = {
>> .owner = THIS_MODULE,
>> };
>>
>> -static const struct of_device_id phy_berlin_sata_of_match[] = {
>> +static const struct of_device_id phy_berlin_usb_of_match[] = {
>> {
>> .compatible = "marvell,berlin2-usb-phy",
>> .data = &phy_berlin_pll_dividers[0],
>> @@ -163,12 +163,12 @@ static const struct of_device_id phy_berlin_sata_of_match[] = {
>> },
>> { },
>> };
>> -MODULE_DEVICE_TABLE(of, phy_berlin_sata_of_match);
>> +MODULE_DEVICE_TABLE(of, phy_berlin_usb_of_match);
>>
>> static int phy_berlin_usb_probe(struct platform_device *pdev)
>> {
>> const struct of_device_id *match =
>> - of_match_device(phy_berlin_sata_of_match, &pdev->dev);
>> + of_match_device(phy_berlin_usb_of_match, &pdev->dev);
>> struct phy_berlin_usb_priv *priv;
>> struct resource *res;
>> struct phy *phy;
>> @@ -208,7 +208,7 @@ static struct platform_driver phy_berlin_usb_driver = {
>> .driver = {
>> .name = "phy-berlin-usb",
>> .owner = THIS_MODULE,
>> - .of_match_table = phy_berlin_sata_of_match,
>> + .of_match_table = phy_berlin_usb_of_match,
>> },
>> };
>> module_platform_driver(phy_berlin_usb_driver);
>> --
>> 2.4.4
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web