Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1176424 > unrolled thread

Re: config PROC_CHILDREN

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: config PROC_CHILDREN Iago López Galeiras <iago@endocode.com> - 2015-07-03 11:20 +0200
    Re: config PROC_CHILDREN Iago López Galeiras <iago@endocode.com> - 2015-07-08 16:20 +0200

#1176424 — Re: config PROC_CHILDREN

Hi Jean,

The purpose of this option is enabling /proc/<pid>/task/<tid>/children without
having to enable CHECKPOINT_RESTORE, which is hidden behind EXPERT.

Regarding its lack of help, documentation is in already in place[1] but perhaps
that's not clear for the user because as you say the Kconfig help text is missing.

I suggest adding something like:

    Provides a fast way to retrieve first level children pids of a task. See
    <file:Documentation/filesystems/proc.txt> for more information.

Do you think that's enough?

Thanks.

[1]: https://www.kernel.org/doc/Documentation/filesystems/proc.txt

On 07/03/2015 09:39 AM, Jean Delvare wrote:
> Hi Iago,
> 
> You just introduced a Linux kernel configuration option named
> PROC_CHILDREN. It is user-visible but has no help. This is bad.
> 
> As this option appears to be selected automatically as needed, I'm not
> sure why you made it visible?
> 
> Please either hide the option, or add a help text to let the user make
> a sane decision.
> 
> Thanks,
> 

-- 

Iago López Galeiras
Software developer @ Endocode AG
iago@endocode.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1179874

On 07/04/2015 07:07 PM, Jean Delvare wrote:
> Hi Iago,
> 
> Please don't top-post.
> 
> On Fri, 3 Jul 2015 11:10:45 +0200, Iago López Galeiras wrote:
>> Hi Jean,
>>
>> The purpose of this option is enabling /proc/<pid>/task/<tid>/children without
>> having to enable CHECKPOINT_RESTORE, which is hidden behind EXPERT.
>>
>> Regarding its lack of help, documentation is in already in place[1] but perhaps
>> that's not clear for the user because as you say the Kconfig help text is missing.
>>
>> I suggest adding something like:
>>
>>     Provides a fast way to retrieve first level children pids of a task. See
>>     <file:Documentation/filesystems/proc.txt> for more information.
>>
>> Do you think that's enough?
> 
> That's a start, the reference to Documentation/filesystems/proc.txt is
> good but I think we can do better. You need to help the user make the
> decision. Why should he/she say Y or N? The user should NOT have to look
> at an external documentation file if the answer is N. I would suggest
> the following:
> 
> Say Y if running any user-space software which takes benefit from this
> interface. For example, rkt is such a piece of software.

That makes it more clear for the user. Thanks!

> That being said, I am curious... Is this interface so expensive that it
> really deserves a separate option, instead of always enabling it? This
> seems to be a fairly generic feature that a lot of scripts and tools
> could benefit from (starting with pstree I suppose.)

I don't think I have enough information to answer that question. I'll CC Cyrill
Gorcunov and Andrew Morton.

-- 

Iago López Galeiras
Software developer @ Endocode AG
iago@endocode.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web