Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1176427 > unrolled thread
| Started by | Alban Bedel <albeu@free.fr> |
|---|---|
| First post | 2015-07-03 11:20 +0200 |
| Last post | 2015-07-05 10:40 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0/2] MIPS: ath79: Move the GPIO driver to drivers/gpio Alban Bedel <albeu@free.fr> - 2015-07-03 11:20 +0200
[PATCH 1/2] MIPS: ath79: Remove the unused GPIO function API Alban Bedel <albeu@free.fr> - 2015-07-03 11:20 +0200
Re: [PATCH 1/2] MIPS: ath79: Remove the unused GPIO function API Sergey Ryazanov <ryazanov.s.a@gmail.com> - 2015-07-05 10:40 +0200
| From | Alban Bedel <albeu@free.fr> |
|---|---|
| Date | 2015-07-03 11:20 +0200 |
| Subject | [PATCH 0/2] MIPS: ath79: Move the GPIO driver to drivers/gpio |
| Message-ID | <pI5ix-6Fa-17@gated-at.bofh.it> |
Hi all, as requested when I posted the ATH79 OF support serie, here is the move of the GPIO driver to the GPIO drivers directory. While at it I also removed the custom pinmux API as it not used by any board. Alban Alban Bedel (2): MIPS: ath79: Remove the unused GPIO function API MIPS: ath79: Move the GPIO driver to drivers/gpio arch/mips/ath79/Makefile | 2 +- arch/mips/ath79/common.h | 3 - arch/mips/ath79/gpio.c | 279 ---------------------------------------------- drivers/gpio/Makefile | 1 + drivers/gpio/gpio-ath79.c | 236 +++++++++++++++++++++++++++++++++++++++ 5 files changed, 238 insertions(+), 283 deletions(-) delete mode 100644 arch/mips/ath79/gpio.c create mode 100644 drivers/gpio/gpio-ath79.c -- 2.0.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Alban Bedel <albeu@free.fr> |
|---|---|
| Date | 2015-07-03 11:20 +0200 |
| Subject | [PATCH 1/2] MIPS: ath79: Remove the unused GPIO function API |
| Message-ID | <pI5iy-6Fa-33@gated-at.bofh.it> |
| In reply to | #1176427 |
To prepare moving the GPIO driver to drivers/gpio remove the
platform specific pinmux API. As it is not used by any board,
and such functionality should better be implemented using the
pinmux subsystem just removing it seems to be the best option.
Signed-off-by: Alban Bedel <albeu@free.fr>
---
arch/mips/ath79/common.h | 3 ---
arch/mips/ath79/gpio.c | 43 -------------------------------------------
2 files changed, 46 deletions(-)
diff --git a/arch/mips/ath79/common.h b/arch/mips/ath79/common.h
index e5ea712..ca7cc19 100644
--- a/arch/mips/ath79/common.h
+++ b/arch/mips/ath79/common.h
@@ -25,9 +25,6 @@ unsigned long ath79_get_sys_clk_rate(const char *id);
void ath79_ddr_ctrl_init(void);
void ath79_ddr_wb_flush(unsigned int reg);
-void ath79_gpio_function_enable(u32 mask);
-void ath79_gpio_function_disable(u32 mask);
-void ath79_gpio_function_setup(u32 set, u32 clear);
void ath79_gpio_init(void);
#endif /* __ATH79_COMMON_H */
diff --git a/arch/mips/ath79/gpio.c b/arch/mips/ath79/gpio.c
index f59ccb2..c3c92eb 100644
--- a/arch/mips/ath79/gpio.c
+++ b/arch/mips/ath79/gpio.c
@@ -24,8 +24,6 @@
#include <linux/of_device.h>
#include <asm/mach-ath79/ar71xx_regs.h>
-#include <asm/mach-ath79/ath79.h>
-#include "common.h"
static void __iomem *ath79_gpio_base;
static u32 ath79_gpio_count;
@@ -139,47 +137,6 @@ static struct gpio_chip ath79_gpio_chip = {
.base = 0,
};
-static void __iomem *ath79_gpio_get_function_reg(void)
-{
- u32 reg = 0;
-
- if (soc_is_ar71xx() ||
- soc_is_ar724x() ||
- soc_is_ar913x() ||
- soc_is_ar933x())
- reg = AR71XX_GPIO_REG_FUNC;
- else if (soc_is_ar934x())
- reg = AR934X_GPIO_REG_FUNC;
- else
- BUG();
-
- return ath79_gpio_base + reg;
-}
-
-void ath79_gpio_function_setup(u32 set, u32 clear)
-{
- void __iomem *reg = ath79_gpio_get_function_reg();
- unsigned long flags;
-
- spin_lock_irqsave(&ath79_gpio_lock, flags);
-
- __raw_writel((__raw_readl(reg) & ~clear) | set, reg);
- /* flush write */
- __raw_readl(reg);
-
- spin_unlock_irqrestore(&ath79_gpio_lock, flags);
-}
-
-void ath79_gpio_function_enable(u32 mask)
-{
- ath79_gpio_function_setup(mask, 0);
-}
-
-void ath79_gpio_function_disable(u32 mask)
-{
- ath79_gpio_function_setup(0, mask);
-}
-
static const struct of_device_id ath79_gpio_of_match[] = {
{ .compatible = "qca,ar7100-gpio" },
{ .compatible = "qca,ar9340-gpio" },
--
2.0.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Sergey Ryazanov <ryazanov.s.a@gmail.com> |
|---|---|
| Date | 2015-07-05 10:40 +0200 |
| Subject | Re: [PATCH 1/2] MIPS: ath79: Remove the unused GPIO function API |
| Message-ID | <pINCX-wQ-29@gated-at.bofh.it> |
| In reply to | #1176429 |
2015-07-03 12:11 GMT+03:00 Alban Bedel <albeu@free.fr>: > To prepare moving the GPIO driver to drivers/gpio remove the > platform specific pinmux API. As it is not used by any board, > and such functionality should better be implemented using the > pinmux subsystem just removing it seems to be the best option. > For reference: OpenWRT uses this functions to activate UART. -- Sergey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web