Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1175816 > unrolled thread

Re: [PATCH RFC 1/5] kdbus: fix typos in kdbus_conn_quota_inc()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH RFC 1/5] kdbus: fix typos in kdbus_conn_quota_inc() David Herrmann <dh.herrmann@gmail.com> - 2015-07-02 10:40 +0200
    Re: [PATCH RFC 1/5] kdbus: fix typos in kdbus_conn_quota_inc() Sergei Zviagintsev <sergei@s15v.net> - 2015-07-02 12:00 +0200

#1175816 — Re: [PATCH RFC 1/5] kdbus: fix typos in kdbus_conn_quota_inc()

Hi

On Sun, Jun 28, 2015 at 3:17 PM, Sergei Zviagintsev <sergei@s15v.net> wrote:
> Signed-off-by: Sergei Zviagintsev <sergei@s15v.net>
> ---
>  ipc/kdbus/connection.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

(I'm a fan of putting the actual typo-corrections into the
commit-msg-body, like: "allocations -> allocation" and "slice ->
slices", which makes reviewing such patches a lot easier.)

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>

Thanks
David

> diff --git a/ipc/kdbus/connection.c b/ipc/kdbus/connection.c
> index 9993753d11de..df072487e23c 100644
> --- a/ipc/kdbus/connection.c
> +++ b/ipc/kdbus/connection.c
> @@ -646,7 +646,7 @@ int kdbus_conn_quota_inc(struct kdbus_conn *c, struct kdbus_user *u,
>          * allocation schemes. Furthermore, resource utilization should be
>          * maximized, so only minimal resources stay reserved. However, we need
>          * to adapt to a dynamic number of users, as we cannot know how many
> -        * users will talk to a connection. Therefore, the current allocations
> +        * users will talk to a connection. Therefore, the current allocation
>          * works like this:
>          * We limit the number of bytes in a destination's pool per sending
>          * user. The space available for a user is 33% of the unused pool space
> @@ -688,7 +688,7 @@ int kdbus_conn_quota_inc(struct kdbus_conn *c, struct kdbus_user *u,
>
>         /*
>          * Pool owner slices are un-accounted slices; they can claim more
> -        * than 50% of the queue. However, the slice we're dealing with here
> +        * than 50% of the queue. However, the slices we're dealing with here
>          * belong to the incoming queue, hence they are 'accounted' slices
>          * to which the 50%-limit applies.
>          */
> --
> 1.8.3.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1175878

Hi,

On Thu, Jul 02, 2015 at 10:31:48AM +0200, David Herrmann wrote:
> Hi
> 
> On Sun, Jun 28, 2015 at 3:17 PM, Sergei Zviagintsev <sergei@s15v.net> wrote:
> > Signed-off-by: Sergei Zviagintsev <sergei@s15v.net>
> > ---
> >  ipc/kdbus/connection.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> (I'm a fan of putting the actual typo-corrections into the
> commit-msg-body, like: "allocations -> allocation" and "slice ->
> slices", which makes reviewing such patches a lot easier.)

Thank you for the comment. I will resend this with adjusted commit
message along with other patches in v2.

> 
> Reviewed-by: David Herrmann <dh.herrmann@gmail.com>

Should I include this Reviewed-by tag into v2 of this patch myself, or
you will perform review process again?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web