Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1174108 > unrolled thread

[Patch v3 1/1] media: am437x-vpfe: Requested frame size and fmt overwritten by current sensor setting

Started byBenoit Parrot <bparrot@ti.com>
First post2015-06-29 23:20 +0200
Last post2015-07-07 13:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [Patch v3 1/1] media: am437x-vpfe: Requested frame size and fmt overwritten by current sensor setting Benoit Parrot <bparrot@ti.com> - 2015-06-29 23:20 +0200
    Re: [Patch v3 1/1] media: am437x-vpfe: Requested frame size and fmt  overwritten by current sensor setting "Lad, Prabhakar" <prabhakar.csengg@gmail.com> - 2015-07-07 13:20 +0200

#1174108 — [Patch v3 1/1] media: am437x-vpfe: Requested frame size and fmt overwritten by current sensor setting

FromBenoit Parrot <bparrot@ti.com>
Date2015-06-29 23:20 +0200
Subject[Patch v3 1/1] media: am437x-vpfe: Requested frame size and fmt overwritten by current sensor setting
Message-ID<pGOD7-6zP-3@gated-at.bofh.it>
Upon a S_FMT the input/requested frame size and pixel format is
overwritten by the current sub-device settings.
Fix this so application can actually set the frame size and format.

Fixes: 417d2e507edc ("[media] media: platform: add VPFE capture driver support for AM437X")
Cc: <stable@vger.kernel.org> # v4.0+
Signed-off-by: Benoit Parrot <bparrot@ti.com>
---
Changes since v2:
- fix the stable commit reference syntax

 drivers/media/platform/am437x/am437x-vpfe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/am437x/am437x-vpfe.c b/drivers/media/platform/am437x/am437x-vpfe.c
index eb25c43da126..0fa62c50f62d 100644
--- a/drivers/media/platform/am437x/am437x-vpfe.c
+++ b/drivers/media/platform/am437x/am437x-vpfe.c
@@ -1584,7 +1584,7 @@ static int vpfe_s_fmt(struct file *file, void *priv,
 		return -EBUSY;
 	}
 
-	ret = vpfe_try_fmt(file, priv, fmt);
+	ret = vpfe_try_fmt(file, priv, &format);
 	if (ret)
 		return ret;
 
-- 
1.8.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1178366 — Re: [Patch v3 1/1] media: am437x-vpfe: Requested frame size and fmt overwritten by current sensor setting

From"Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date2015-07-07 13:20 +0200
SubjectRe: [Patch v3 1/1] media: am437x-vpfe: Requested frame size and fmt overwritten by current sensor setting
Message-ID<pJz4S-4Y0-33@gated-at.bofh.it>
In reply to#1174108
On Mon, Jun 29, 2015 at 10:19 PM, Benoit Parrot <bparrot@ti.com> wrote:
> Upon a S_FMT the input/requested frame size and pixel format is
> overwritten by the current sub-device settings.
> Fix this so application can actually set the frame size and format.
>
> Fixes: 417d2e507edc ("[media] media: platform: add VPFE capture driver support for AM437X")
> Cc: <stable@vger.kernel.org> # v4.0+
> Signed-off-by: Benoit Parrot <bparrot@ti.com>

Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Cheers,
--Prabhakar Lad

> ---
> Changes since v2:
> - fix the stable commit reference syntax
>
>  drivers/media/platform/am437x/am437x-vpfe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/am437x/am437x-vpfe.c b/drivers/media/platform/am437x/am437x-vpfe.c
> index eb25c43da126..0fa62c50f62d 100644
> --- a/drivers/media/platform/am437x/am437x-vpfe.c
> +++ b/drivers/media/platform/am437x/am437x-vpfe.c
> @@ -1584,7 +1584,7 @@ static int vpfe_s_fmt(struct file *file, void *priv,
>                 return -EBUSY;
>         }
>
> -       ret = vpfe_try_fmt(file, priv, fmt);
> +       ret = vpfe_try_fmt(file, priv, &format);
>         if (ret)
>                 return ret;
>
> --
> 1.8.5.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web