Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1172580 > unrolled thread
| Started by | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| First post | 2015-06-26 06:10 +0200 |
| Last post | 2015-06-26 06:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-06-26 06:10 +0200
Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators Juston Li <juston.h.li@gmail.com> - 2015-06-26 06:20 +0200
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| Date | 2015-06-26 06:10 +0200 |
| Subject | Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators |
| Message-ID | <pFt7I-4sx-9@gated-at.bofh.it> |
On Thu, Jun 25, 2015 at 09:26:00AM -0700, Juston Li wrote: > On Thu, Jun 25, 2015 at 4:56 AM, Sudip Mukherjee > <sudipm.mukherjee@gmail.com> wrote: > > On Wed, Jun 24, 2015 at 09:25:12AM -0700, Juston Li wrote: <snip> > > > 2) Considering that you are giving consitent space around operators, then > > i think you have missed few operators like '|','&',':' in this > > patch. > > > > These were the only instances the checkpatch.pl error came up. This patch > only fixes even spacing around a specific operator. Other operators either > have even or no spacing around them with PATCH 11/19 fixing any operators > with spacing around required. This leaves operators that checkpatch deems > spacing as optional which I left as a separate issue to be addressed of making > optional spacing of operators consistent with each other. Usually I use the checkpatch which is in linux-next. That will be the latest version. If you compare, last commit on checkpatch of staging tree was on April 16th, where as last commit in linux-next is on June 19th. And if you use this checkpatch you will see these warnings also. :) regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Juston Li <juston.h.li@gmail.com> |
|---|---|
| Date | 2015-06-26 06:20 +0200 |
| Subject | Re: [PATCH v3 11/19] staging: sm750fb: consistent spacing around operators |
| Message-ID | <pFtho-4DE-3@gated-at.bofh.it> |
| In reply to | #1172580 |
On Thu, Jun 25, 2015 at 9:05 PM, Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote: > Usually I use the checkpatch which is in linux-next. That will be the > latest version. If you compare, last commit on checkpatch of staging > tree was on April 16th, where as last commit in linux-next is on > June 19th. And if you use this checkpatch you will see these warnings > also. :) Thanks for the tip, I'll use the latest checkpatch and fix the warnings. Your help has been much appreciated Regards Juston -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web