Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1171767 > unrolled thread

[PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

Started byJavier Martinez Canillas <javier.martinez@collabora.co.uk>
First post2015-06-25 02:30 +0200
Last post2015-06-25 10:50 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM Javier Martinez Canillas <javier.martinez@collabora.co.uk> - 2015-06-25 02:30 +0200
    Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM Lee Jones <lee.jones@linaro.org> - 2015-06-25 10:40 +0200
      Re: [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM Javier Martinez Canillas <javier.martinez@collabora.co.uk> - 2015-06-25 10:50 +0200

#1171767 — [PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM

FromJavier Martinez Canillas <javier.martinez@collabora.co.uk>
Date2015-06-25 02:30 +0200
Subject[PATCH 2/3] mfd: Remove MFD_CROS_EC depends on X86 || ARM
Message-ID<pF3df-zY-1@gated-at.bofh.it>
A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:

(MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM)

This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
that dependency was removed since there isn't a reason why the option can
not be selected on other architectures. So now the above warning will not
happen and the MFD_CROS_EC dependency can be removed since is not needed.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---

 drivers/mfd/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index d3235e6f1953..653815950aa2 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -94,7 +94,6 @@ config MFD_AXP20X
 
 config MFD_CROS_EC
 	tristate "ChromeOS Embedded Controller"
-	depends on X86 || ARM
 	select MFD_CORE
 	select CHROME_PLATFORMS
 	select CROS_EC_PROTO
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1171949

FromLee Jones <lee.jones@linaro.org>
Date2015-06-25 10:40 +0200
Message-ID<pFaRt-3s2-21@gated-at.bofh.it>
In reply to#1171767
On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:

> A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:
> 
> (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM)
> 
> This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
> that dependency was removed since there isn't a reason why the option can
> not be selected on other architectures. So now the above warning will not
> happen and the MFD_CROS_EC dependency can be removed since is not needed.
> 
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
> 
>  drivers/mfd/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

Applied for v4.3, thanks.

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index d3235e6f1953..653815950aa2 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -94,7 +94,6 @@ config MFD_AXP20X
>  
>  config MFD_CROS_EC
>  	tristate "ChromeOS Embedded Controller"
> -	depends on X86 || ARM
>  	select MFD_CORE
>  	select CHROME_PLATFORMS
>  	select CROS_EC_PROTO

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1171951

FromJavier Martinez Canillas <javier.martinez@collabora.co.uk>
Date2015-06-25 10:50 +0200
Message-ID<pFb17-3Dh-3@gated-at.bofh.it>
In reply to#1171949
Hello Lee,

On 06/25/2015 10:38 AM, Lee Jones wrote:
> On Thu, 25 Jun 2015, Javier Martinez Canillas wrote:
> 
>> A dependency on X86 || ARM for MFD_CROS_EC was added to fix the warning:
>> 
>> (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet direct dependencies (X86 || ARM)
>> 
>> This happened because CHROME_PLATFORMS had a dependency on X86 || ARM but
>> that dependency was removed since there isn't a reason why the option can
>> not be selected on other architectures. So now the above warning will not
>> happen and the MFD_CROS_EC dependency can be removed since is not needed.
>> 
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> ---
>> 
>>  drivers/mfd/Kconfig | 1 -
>>  1 file changed, 1 deletion(-)
> 
> Applied for v4.3, thanks.
> 

Thanks a lot.

Olof,

Could you please ack patch 1/3 so Lee can pick it through the mfd tree?
Since both patches 1/3 and 2/3 are needed to fix the build warning for
!X86 and !ARM architectures.

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web