Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1171683 > unrolled thread
| Started by | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| First post | 2015-06-24 23:30 +0200 |
| Last post | 2015-06-25 03:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] ARM64: smp: Silence suspicious RCU usage with ipi tracepoints Peter Zijlstra <peterz@infradead.org> - 2015-06-24 23:30 +0200
Re: [PATCH] ARM64: smp: Silence suspicious RCU usage with ipi tracepoints Stephen Boyd <sboyd@codeaurora.org> - 2015-06-25 00:10 +0200
Re: [PATCH] ARM64: smp: Silence suspicious RCU usage with ipi tracepoints Steven Rostedt <rostedt@goodmis.org> - 2015-06-25 03:10 +0200
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Date | 2015-06-24 23:30 +0200 |
| Subject | Re: [PATCH] ARM64: smp: Silence suspicious RCU usage with ipi tracepoints |
| Message-ID | <pF0p4-4YX-7@gated-at.bofh.it> |
On Wed, Jun 24, 2015 at 01:14:18PM -0700, Stephen Boyd wrote: > John Stultz reported an RCU splat on ARM with ipi trace events > enabled. It looks like the same problem exists on ARM64. > > At this point in the IPI handling path we haven't called > irq_enter() yet, so RCU doesn't know that we're about to exit > idle and properly warns that we're using RCU from an idle CPU. > Use trace_ipi_entry_rcuidle() instead of trace_ipi_entry() so > that RCU is informed about our exit from idle. I have a problem with $subject. It says 'silence', whereas afaict this fixes an actual bug, so it should be 'fixes'. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Stephen Boyd <sboyd@codeaurora.org> |
|---|---|
| Date | 2015-06-25 00:10 +0200 |
| Subject | Re: [PATCH] ARM64: smp: Silence suspicious RCU usage with ipi tracepoints |
| Message-ID | <pF11M-5Zy-3@gated-at.bofh.it> |
| In reply to | #1171683 |
On 06/24/2015 02:29 PM, Peter Zijlstra wrote: > On Wed, Jun 24, 2015 at 01:14:18PM -0700, Stephen Boyd wrote: >> John Stultz reported an RCU splat on ARM with ipi trace events >> enabled. It looks like the same problem exists on ARM64. >> >> At this point in the IPI handling path we haven't called >> irq_enter() yet, so RCU doesn't know that we're about to exit >> idle and properly warns that we're using RCU from an idle CPU. >> Use trace_ipi_entry_rcuidle() instead of trace_ipi_entry() so >> that RCU is informed about our exit from idle. > I have a problem with $subject. It says 'silence', whereas afaict this > fixes an actual bug, so it should be 'fixes'. Fair enough. I can resend or whoever applies this patch can s/Silence/Fix/ on the $subject. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Date | 2015-06-25 03:10 +0200 |
| Message-ID | <pF3PX-1xZ-7@gated-at.bofh.it> |
| In reply to | #1171683 |
On Wed, 24 Jun 2015 23:29:30 +0200 Peter Zijlstra <peterz@infradead.org> wrote: > On Wed, Jun 24, 2015 at 01:14:18PM -0700, Stephen Boyd wrote: > > John Stultz reported an RCU splat on ARM with ipi trace events > > enabled. It looks like the same problem exists on ARM64. > > > > At this point in the IPI handling path we haven't called > > irq_enter() yet, so RCU doesn't know that we're about to exit > > idle and properly warns that we're using RCU from an idle CPU. > > Use trace_ipi_entry_rcuidle() instead of trace_ipi_entry() so > > that RCU is informed about our exit from idle. > > I have a problem with $subject. It says 'silence', whereas afaict this > fixes an actual bug, so it should be 'fixes'. Agreed, otherwise Acked-by: Steven Rostedt <rostedt@goodmis.org> -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web