Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1170252 > unrolled thread

Re: [PATCH 08/08] ARM: shmobile: Remove CMT renesas,channels-mask from DTS

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 08/08] ARM: shmobile: Remove CMT renesas,channels-mask from DTS Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2015-06-23 00:40 +0200
    Re: [PATCH 08/08] ARM: shmobile: Remove CMT renesas,channels-mask  from DTS Magnus Damm <magnus.damm@gmail.com> - 2015-06-23 04:50 +0200
      Re: [PATCH 08/08] ARM: shmobile: Remove CMT renesas,channels-mask from DTS Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2015-06-26 00:00 +0200

#1170252 — Re: [PATCH 08/08] ARM: shmobile: Remove CMT renesas,channels-mask from DTS

Hi Magnus,

Thank you for the patch.

On Sunday 21 June 2015 17:10:33 Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
> 
> Update the DTS to remove the now deprecated "renesas,channels-mask"
> property.
> 
> The channel information is now kept in the device driver and can easily
> be determined based on the compat string.

Unless I've missed something (which is entirely possibly given the late hour), 
the channel mask is only stored in the driver for the Gen2 CMT instances.

> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> ---
> 
>  arch/arm/boot/dts/r8a73a4.dtsi |    3 ---
>  arch/arm/boot/dts/r8a7740.dtsi |    3 ---
>  arch/arm/boot/dts/r8a7790.dtsi |    6 ------
>  arch/arm/boot/dts/r8a7791.dtsi |    6 ------
>  arch/arm/boot/dts/r8a7793.dtsi |    6 ------
>  arch/arm/boot/dts/r8a7794.dtsi |    6 ------
>  arch/arm/boot/dts/sh73a0.dtsi  |    3 ---
>  7 files changed, 33 deletions(-)

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1170345 — Re: [PATCH 08/08] ARM: shmobile: Remove CMT renesas,channels-mask from DTS

Hi Laurent,

On Tue, Jun 23, 2015 at 7:40 AM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Hi Magnus,
>
> Thank you for the patch.
>
> On Sunday 21 June 2015 17:10:33 Magnus Damm wrote:
>> From: Magnus Damm <damm+renesas@opensource.se>
>>
>> Update the DTS to remove the now deprecated "renesas,channels-mask"
>> property.
>>
>> The channel information is now kept in the device driver and can easily
>> be determined based on the compat string.
>
> Unless I've missed something (which is entirely possibly given the late hour),
> the channel mask is only stored in the driver for the Gen2 CMT instances.

The case for sh73a0 and r8a7740 is also covered by some of the earlier
patches in this series. So unless I'm mistaken the series should cover
all current in-tree CMT DT users that we have. I'm not aware of any
out-of-tree users.

You are right that there are more unused compat strings documented, so
those will break. I would be tempted in phasing those out somehow.
Also, I did not spend much time cleaning up the non R-Car Gen2 cases,
so in general that needs some love.

Thanks!

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1172486

Hi Magnus,

On Tuesday 23 June 2015 11:46:45 Magnus Damm wrote:
> On Tue, Jun 23, 2015 at 7:40 AM, Laurent Pinchart wrote:
> > On Sunday 21 June 2015 17:10:33 Magnus Damm wrote:
> >> From: Magnus Damm <damm+renesas@opensource.se>
> >> 
> >> Update the DTS to remove the now deprecated "renesas,channels-mask"
> >> property.
> >> 
> >> The channel information is now kept in the device driver and can easily
> >> be determined based on the compat string.
> > 
> > Unless I've missed something (which is entirely possibly given the late
> > hour), the channel mask is only stored in the driver for the Gen2 CMT
> > instances.
>
> The case for sh73a0 and r8a7740 is also covered by some of the earlier
> patches in this series.

My bad, I've missed that. We should be good then.

> So unless I'm mistaken the series should cover all current in-tree CMT DT
> users that we have. I'm not aware of any out-of-tree users.
> 
> You are right that there are more unused compat strings documented, so
> those will break. I would be tempted in phasing those out somehow.
> Also, I did not spend much time cleaning up the non R-Car Gen2 cases,
> so in general that needs some love.

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web