Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1169893 > unrolled thread

[PATCH v2 1/2] staging: comedi: no space before tabs

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 1/2] staging: comedi: no space before tabs Luis de Bethencourt <luis@debethencourt.com> - 2015-06-22 14:30 +0200
    Re: [PATCH v2 1/2] staging: comedi: no space before tabs Ian Abbott <abbotti@mev.co.uk> - 2015-06-22 14:50 +0200
      Re: [PATCH v2 1/2] staging: comedi: no space before tabs Luis de Bethencourt <luis@debethencourt.com> - 2015-06-22 15:10 +0200

#1169893 — [PATCH v2 1/2] staging: comedi: no space before tabs

Warning found by checkpatch.pl
WARNING: please, no space before tabs
/drivers/staging/comedi/drivers/das16m1.c:83
+  404-407 ^I8254$

Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
---
 drivers/staging/comedi/drivers/das16m1.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/comedi/drivers/das16m1.c b/drivers/staging/comedi/drivers/das16m1.c
index 1adf6a7..a991c97 100644
--- a/drivers/staging/comedi/drivers/das16m1.c
+++ b/drivers/staging/comedi/drivers/das16m1.c
@@ -69,18 +69,18 @@ irq can be omitted, although the cmd interface will not work without it.
 
     "cio-das16/m1"
 
-  0	a/d bits 0-3, mux		start 12 bit
-  1	a/d bits 4-11		unused
-  2	status		control
-  3	di 4 bit		do 4 bit
-  4	unused			clear interrupt
-  5	interrupt, pacer
-  6	channel/gain queue address
-  7	channel/gain queue data
-  89ab	8254
-  cdef	8254
-  400	8255
-  404-407 	8254
+  0		a/d bits 0-3, mux		start 12 bit
+  1		a/d bits 4-11		unused
+  2		status		control
+  3		di 4 bit		do 4 bit
+  4		unused			clear interrupt
+  5		interrupt, pacer
+  6		channel/gain queue address
+  7		channel/gain queue data
+  89ab		8254
+  cdef		8254
+  400		8255
+  404-407	8254
 
 */
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1169917

On 22/06/15 13:31, Luis de Bethencourt wrote:
> Warning found by checkpatch.pl
> WARNING: please, no space before tabs
> /drivers/staging/comedi/drivers/das16m1.c:83
> +  404-407 ^I8254$
>
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> ---
>   drivers/staging/comedi/drivers/das16m1.c | 24 ++++++++++++------------
>   1 file changed, 12 insertions(+), 12 deletions(-)

Like for your "Author string" patch for das08_cs.c, it would be nice to 
mention the module name in the subject line in this patch and in patch 2 
of the series, especially as these changes are for a specific module, 
not the whole of comedi.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1169929

On Mon, Jun 22, 2015 at 01:40:07PM +0100, Ian Abbott wrote:
> On 22/06/15 13:31, Luis de Bethencourt wrote:
> >Warning found by checkpatch.pl
> >WARNING: please, no space before tabs
> >/drivers/staging/comedi/drivers/das16m1.c:83
> >+  404-407 ^I8254$
> >
> >Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> >---
> >  drivers/staging/comedi/drivers/das16m1.c | 24 ++++++++++++------------
> >  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> Like for your "Author string" patch for das08_cs.c, it would be nice
> to mention the module name in the subject line in this patch and in
> patch 2 of the series, especially as these changes are for a
> specific module, not the whole of comedi.
> 

Makes sense. I should've gone ahead and done it sooner. Fixed now.

Thanks for the review,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web