Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1169844 > unrolled thread

Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before  the open parenthesis '('" errors Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-06-22 13:20 +0200
    Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before  the open parenthesis '('" errors Greg Donald <gdonald@gmail.com> - 2015-06-22 13:30 +0200

#1169844 — Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

On Sat, Jun 20, 2015 at 03:56:08PM -0500, Greg Donald wrote:
> Fix checkpatch.pl "space required before the open parenthesis '('" errors
> 
> Signed-off-by: Greg Donald <gdonald@gmail.com>
> ---
>  .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c    | 97 ++++++++++------------
>  1 file changed, 44 insertions(+), 53 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> index c2588f8..df20979 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
<snip>
> @@ -127,8 +127,7 @@ void HTDebugHTCapability(u8 *CapIE, u8 *TitleString )
>  	static u8	EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};	// For 11n EWC definition, 2007.07.17, by Emily
>  	PHT_CAPABILITY_ELE		pCapELE;
>  
> -	if(!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap)))
> -	{
> +	if (!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap))) {
							  ^^^^^^^
this becomes a different kind of change than what is mentioned in your
commit message.
You are also adding space after ',' later in your patch.
please do only one kind of change in one patch.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1169846

Umm.. you have to fix more than one error if there's more than one
error on or very near the same line you are already fixing, else
checkpatch.pl complains that your patch has errors.  Not to mention
Greg KH has never complained:

http://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/log/?qt=grep&q=gdonald



On Mon, Jun 22, 2015 at 6:10 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On Sat, Jun 20, 2015 at 03:56:08PM -0500, Greg Donald wrote:
>> Fix checkpatch.pl "space required before the open parenthesis '('" errors
>>
>> Signed-off-by: Greg Donald <gdonald@gmail.com>
>> ---
>>  .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c    | 97 ++++++++++------------
>>  1 file changed, 44 insertions(+), 53 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
>> index c2588f8..df20979 100644
>> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
>> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> <snip>
>> @@ -127,8 +127,7 @@ void HTDebugHTCapability(u8 *CapIE, u8 *TitleString )
>>       static u8       EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};       // For 11n EWC definition, 2007.07.17, by Emily
>>       PHT_CAPABILITY_ELE              pCapELE;
>>
>> -     if(!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap)))
>> -     {
>> +     if (!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap))) {
>                                                           ^^^^^^^
> this becomes a different kind of change than what is mentioned in your
> commit message.
> You are also adding space after ',' later in your patch.
> please do only one kind of change in one patch.
>
> regards
> sudip



-- 
Greg Donald
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web