Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1169738 > unrolled thread
| Started by | Maninder Singh <maninder1.s@samsung.com> |
|---|---|
| First post | 2015-06-22 09:00 +0200 |
| Last post | 2015-06-22 09:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
Re: [RFC PATCH v2] packet: remove handling of tx_ring Maninder Singh <maninder1.s@samsung.com> - 2015-06-22 09:00 +0200
Re: [RFC PATCH v2] packet: remove handling of tx_ring Frans Klaver <fransklaver@gmail.com> - 2015-06-22 09:10 +0200
| From | Maninder Singh <maninder1.s@samsung.com> |
|---|---|
| Date | 2015-06-22 09:00 +0200 |
| Subject | Re: [RFC PATCH v2] packet: remove handling of tx_ring |
| Message-ID | <pE3S2-4xB-3@gated-at.bofh.it> |
SGkgRnJhbnMsDQoNCj4+IHYxID0gcmVwbGFjZSBpZigpL0JVRyB3aXRoIEJVR19PTigpIGZvciB0 eF9yaW5nLg0KPj4NCj4+IHYyID0NCj4NCj5JIHdvdWxkIGtlZXAgdGhpcyBiZWxvdyB0aGUgLS0t LiBUaGVyZSdzIGxpdHRsZSBoaXN0b3JpY2FsIHVzZSBmb3INCj50aGlzIHZlcnNpb24gaW5mb3Jt YXRpb24gd2hlbiBpdCBnZXRzIG1lcmdlZC4NCj4NCj4+IHJlbW92ZSBoYW5kbGluZyBvZiB0eF9y aW5nIGluIHByYl9zZXR1cF9yZXRpcmVfYmxrX3RpbWVyDQo+PiBmb3IgVFBBQ0tFVF9WMyBiZWNh dXNlIGluaXRfcHJiX2JkcWMgaXMgY2FsbGVkIG9ubHkgZm9yIE5VTEwgdHhfcmluZw0KPj4gYW5k IHRodXMgcHJiX3NldHVwX3JldGlyZV9ibGtfdGltZXIgZm9yIE5VTEwgdHhfcmluZyBvbmx5Lg0K Pg0KPkknZCBzYXkgdHhfcmluZyBpcyBmYWxzZSwgcmF0aGVyIHRoYW4gTlVMTC4gSXQncyBub3Qg YSBwb2ludGVyIChoZXJlKS4NCj4NCj4NCj4+IEFuZCBhbHNvIGluIGZ1bmNpdG9uIGluaXRfcHJi X2JkcWMgdGhlcmUgaXMgbm8gdXNhZ2Ugb2YgdHhfcmluZy4NCj4NCj5zLGZ1bmNpdG9uLGZ1bmN0 aW9uLA0KDQpUaGFua3MgZm9yIGZlZWRiYWNrICwgcGxlYXNlIGNoZWNrIGJlbG93IGNoYW5nZWxv ZyBpZiBpdCBsb29rcyBvaywNClRoZW4gaSB3aWxsIHNoYXJlIHVwZGF0ZWQgcGF0Y2g6LQ0KDQp2 MSA9IHJlcGxhY2UgaWYoKS9CVUcgd2l0aCBCVUdfT04oKSBmb3IgdHhfcmluZy4NCg0KU2lnbmVk LW9mZi1ieTogTWFuaW5kZXIgU2luZ2ggPG1hbmluZGVyMS5zQHNhbXN1bmcuY29tPg0KU2lnbmVk LW9mZi1ieTogRnJhbnMgS2xhdmVyIDxmcmFuc2tsYXZlckBnbWFpbC5jb20+DQotLS0NCkNoYW5n ZXMgaW4gdjI6DQoNCiBSZW1vdmUgaGFuZGxpbmcgb2YgdHhfcmluZyBpbiBwcmJfc2V0dXBfcmV0 aXJlX2Jsa190aW1lcg0KIGZvciBUUEFDS0VUX1YzIGJlY2F1c2UgaW5pdF9wcmJfYmRxYyBpcyBj YWxsZWQgb25seSBmb3IgemVybyB0eF9yaW5nIA0KIGFuZCB0aHVzIHByYl9zZXR1cF9yZXRpcmVf YmxrX3RpbWVyIGZvciB6ZXJvIHR4X3Jpbmcgb25seS4NCg0KIEFuZCBhbHNvIGluIGZ1bmN0b24g aW5pdF9wcmJfYmRxYyB0aGVyZSBpcyBubyB1c2FnZSBvZiB0eF9yaW5nLg0KIFRodXMgcmVtb3Zp bmcgdHhfcmluZyBmcm9tIGluaXRfcHJiX2JkcWMuDQoNCiBuZXQvcGFja2V0L2FmX3BhY2tldC5j IHwgICAxNCArKysrKy0tLS0tLS0tLQ0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyks IDkgZGVsZXRpb25zKC0pDQogDQogVGhhbmtzDQogTWFuaW5kZXI= -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Frans Klaver <fransklaver@gmail.com> |
|---|---|
| Date | 2015-06-22 09:10 +0200 |
| Message-ID | <pE41H-4Yf-5@gated-at.bofh.it> |
| In reply to | #1169738 |
Hi, On Mon, Jun 22, 2015 at 8:53 AM, Maninder Singh <maninder1.s@samsung.com> wrote: > Hi Frans, > >>> v1 = replace if()/BUG with BUG_ON() for tx_ring. >>> >>> v2 = >> >>I would keep this below the ---. There's little historical use for >>this version information when it gets merged. >> >>> remove handling of tx_ring in prb_setup_retire_blk_timer >>> for TPACKET_V3 because init_prb_bdqc is called only for NULL tx_ring >>> and thus prb_setup_retire_blk_timer for NULL tx_ring only. >> >>I'd say tx_ring is false, rather than NULL. It's not a pointer (here). >> >> >>> And also in funciton init_prb_bdqc there is no usage of tx_ring. >> >>s,funciton,function, > > Thanks for feedback , please check below changelog if it looks ok, > Then i will share updated patch:- > > v1 = replace if()/BUG with BUG_ON() for tx_ring. > > Signed-off-by: Maninder Singh <maninder1.s@samsung.com> > Signed-off-by: Frans Klaver <fransklaver@gmail.com> No, the Suggested-by: was better for me. You can't go about and add Signed-off-by lines for someone else without permission ;-). > --- > Changes in v2: > > Remove handling of tx_ring in prb_setup_retire_blk_timer > for TPACKET_V3 because init_prb_bdqc is called only for zero tx_ring > and thus prb_setup_retire_blk_timer for zero tx_ring only. > > And also in functon init_prb_bdqc there is no usage of tx_ring. > Thus removing tx_ring from init_prb_bdqc. > > net/packet/af_packet.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) > > Thanks > Maninder No, I didn't make myself clear enough, I'm afraid. The info about the different incarnations of your patch should go below the dashes. The whole "Remove handling ...." text should be your commit message, because that is what you want to see in the commit log. Here's an example: Subject: [RFC PATCH v2] packet: remove handling of tx_ring Remove handling of tx_ring in prb_setup_retire_blk_timer for TPACKET_V3 because init_prb_bdqc is called only for zero tx_ring and thus prb_setup_retire_blk_timer for zero tx_ring only. And also in functon init_prb_bdqc there is no usage of tx_ring. Thus removing tx_ring from init_prb_bdqc. Signed-off-by: Maninder Singh <maninder1.s@samsung.com> Suggested-by: Frans Klaver <fransklaver@gmail.com> --- v1..v2: remove BUG() by removing tx_path diffstat & patch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web