Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1169290 > unrolled thread
| Started by | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| First post | 2015-06-20 07:30 +0200 |
| Last post | 2015-06-20 08:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2] staging: sm750fb: use tabs for indentation Greg KH <gregkh@linuxfoundation.org> - 2015-06-20 07:30 +0200
Re: [PATCH v2] staging: sm750fb: use tabs for indentation Juston Li <juston.h.li@gmail.com> - 2015-06-20 08:00 +0200
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2015-06-20 07:30 +0200 |
| Subject | Re: [PATCH v2] staging: sm750fb: use tabs for indentation |
| Message-ID | <pDjvP-5bV-7@gated-at.bofh.it> |
On Fri, Jun 19, 2015 at 10:13:11PM -0700, Juston Li wrote: > Replace spaces with tabs for indentation to fix the checkpatch.pl warning > 'WARNING: please, no spaces at the start of a line' > > checkpatch doesn't catch comments indented by spaces but I fixed comments > adjacent to warnings as well so they would remain aligned. > > Changes since v1: > fix alignment in ddk750_display.c:154 > didn't remove a space in ddk750_hwi2c.c:48 The version info here should go below the --- line, so it doesn't show up in the changelog itself. third time's a charm? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Juston Li <juston.h.li@gmail.com> |
|---|---|
| Date | 2015-06-20 08:00 +0200 |
| Message-ID | <pDjYS-5Jr-5@gated-at.bofh.it> |
| In reply to | #1169290 |
On Fri, Jun 19, 2015 at 10:21 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > > On Fri, Jun 19, 2015 at 10:13:11PM -0700, Juston Li wrote: > > Replace spaces with tabs for indentation to fix the checkpatch.pl warning > > 'WARNING: please, no spaces at the start of a line' > > > > checkpatch doesn't catch comments indented by spaces but I fixed comments > > adjacent to warnings as well so they would remain aligned. > > > > Changes since v1: > > fix alignment in ddk750_display.c:154 > > didn't remove a space in ddk750_hwi2c.c:48 > > The version info here should go below the --- line, so it doesn't show > up in the changelog itself. > > third time's a charm? Thanks for the tip, resent as v3. *cross fingers* Regards Juston -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web