Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1169619 > unrolled thread

Re: [PATCH] isdn: disable HiSax NetJet driver on microblaze arch

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] isdn: disable HiSax NetJet driver on microblaze arch David Miller <davem@davemloft.net> - 2015-06-21 18:50 +0200
    Re: [PATCH] isdn: disable HiSax NetJet driver on microblaze arch Nicolai Stange <nicstange@gmail.com> - 2015-06-21 20:00 +0200
      Re: [PATCH] isdn: disable HiSax NetJet driver on microblaze arch Jean Delvare <jdelvare@suse.de> - 2015-06-22 13:30 +0200
        Re: [PATCH] isdn: disable HiSax NetJet driver on microblaze arch Nicolai Stange <nicstange@gmail.com> - 2015-06-22 14:40 +0200

#1169619 — Re: [PATCH] isdn: disable HiSax NetJet driver on microblaze arch

From: Nicolai Stange <nicstange@gmail.com>
Date: Wed, 17 Jun 2015 03:05:02 +0200

> Fix an allmodconfig compilation failer on microblaze due to big endian
> architectures being apparently unsupported by the NetJet code:
>   drivers/isdn/hisax/nj_s.c: In function 'setup_netjet_s':
>   drivers/isdn/hisax/nj_s.c:265:2:
>       error: #error "not running on big endian machines now"
> 
> Modify the relevant Kconfig such that the NetJet code is not built on
> microblaze anymore.
> 
> Note that endianess on microblaze is not determined through Kconfig,
> but by means of a compiler provided CPP macro, namely __MICROBLAZEEL__.
> However, gcc defaults to big endianess on that platform.
> 
> Signed-off-by: Nicolai Stange <nicstange@gmail.com>
> ---
>  The maintainer tree listed under "ISDN SUBSYSTEM" in MAINTAINERS does
>  not exist anymore. I created the diff against the Linus tree.

Applied, but we're long overdue for an across-the-board-available
endianness Kconfig option that can flat out be used in these situations.
The current way this is handled is at best, a mess.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1169633

David Miller <davem@davemloft.net> writes:
>> Note that endianess on microblaze is not determined through Kconfig,
>> but by means of a compiler provided CPP macro, namely __MICROBLAZEEL__.
>> However, gcc defaults to big endianess on that platform.
> Applied, but we're long overdue for an across-the-board-available
> endianness Kconfig option that can flat out be used in these situations.
> The current way this is handled is at best, a mess.

Thanks!

Regarding the general Kconfig endianess symbol, I will do another patch
based on the information of
  git grep '_endian\.h' -- arch/
and supply every arch with either of CONFIG_CPU_{LITTLE,BIG}_ENDIAN if
lacking.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1169854

Le Sunday 21 June 2015 à 19:59 +0200, Nicolai Stange a écrit :
> David Miller <davem@davemloft.net> writes:
> >> Note that endianess on microblaze is not determined through Kconfig,
> >> but by means of a compiler provided CPP macro, namely __MICROBLAZEEL__.
> >> However, gcc defaults to big endianess on that platform.
> > Applied, but we're long overdue for an across-the-board-available
> > endianness Kconfig option that can flat out be used in these situations.
> > The current way this is handled is at best, a mess.

I fully agree.

> Thanks!
> 
> Regarding the general Kconfig endianess symbol, I will do another patch
> based on the information of
>   git grep '_endian\.h' -- arch/
> and supply every arch with either of CONFIG_CPU_{LITTLE,BIG}_ENDIAN if
> lacking.

Note that Chen Gang (Cc'd) attempted the same almost a year ago:
http://patchwork.linux-mips.org/patch/7540/
then:
http://marc.info/?t=140958656400002&r=1&w=2

The idea was great IMHO but it did not work out, and I can't remember
why.

-- 
Jean Delvare
SUSE L3 Support

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1169912

Jean Delvare <jdelvare@suse.de> writes:
> Le Sunday 21 June 2015 à 19:59 +0200, Nicolai Stange a écrit :
>> David Miller <davem@davemloft.net> writes:
>>> Applied, but we're long overdue for an across-the-board-available
>>> endianness Kconfig option that can flat out be used in these situations.
>>> The current way this is handled is at best, a mess.
>> 
>> Regarding the general Kconfig endianess symbol, I will do another patch
>> based on the information of
>>   git grep '_endian\.h' -- arch/
>> and supply every arch with either of CONFIG_CPU_{LITTLE,BIG}_ENDIAN if
>> lacking.
>
> Note that Chen Gang (Cc'd) attempted the same almost a year ago:
> http://patchwork.linux-mips.org/patch/7540/
> then:
> http://marc.info/?t=140958656400002&r=1&w=2
>
> The idea was great IMHO but it did not work out, and I can't remember
> why.

Thank you very much for this pointer, Jean!  I've read through these
threads and to summarize, some arch maintainers' main point against that
patchset is that (recent) drivers should generally support both, LE and
BE.

It is interesting to note that Chen Gang had already addressed the very
same issue (Hisax NetJet driver) by the far more general approach
proposed by David Miller here, namely by introducing an
"across-the-board-available endianess Kconfig option".

So unless you really want to have such an option and ping me, I will not
do another patch in the mood of Chen Gang's original one.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web