Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1168734 > unrolled thread

Re: [PATCH v3 1/7] extcon: arizona: Factor out initial GPIO state

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 1/7] extcon: arizona: Factor out initial GPIO state Chanwoo Choi <cwchoi00@gmail.com> - 2015-06-19 14:30 +0200
    Re: [PATCH v3 1/7] extcon: arizona: Factor out initial GPIO state Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-06-19 15:00 +0200

#1168734 — Re: [PATCH v3 1/7] extcon: arizona: Factor out initial GPIO state

Hi Charles,

I'm sorry about lack of my commet on previous patch.
I just want to know the what is meaning of zero(0) index of
"info->micd_modes[0] array"
instead of separate variable (gpio_initial_level).

So, I'd like you to drop this patch on next your patch-set.

Thanks,
Chanwoo Choi

On Fri, Jun 19, 2015 at 7:24 PM, Charles Keepax
<ckeepax@opensource.wolfsonmicro.com> wrote:
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
>  drivers/extcon/extcon-arizona.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index 9262b45..e31613a 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -1135,6 +1135,7 @@ static int arizona_extcon_probe(struct platform_device *pdev)
>         struct arizona *arizona = dev_get_drvdata(pdev->dev.parent);
>         struct arizona_pdata *pdata = &arizona->pdata;
>         struct arizona_extcon_info *info;
> +       int gpio_initial_level;
>         unsigned int val;
>         unsigned int clamp_mode;
>         int jack_irq_fall, jack_irq_rise;
> @@ -1226,8 +1227,9 @@ static int arizona_extcon_probe(struct platform_device *pdev)
>                 info->micd_num_modes = ARRAY_SIZE(micd_default_modes);
>         }
>
> +       gpio_initial_level = info->micd_modes[0].gpio;
>         if (arizona->pdata.micd_pol_gpio > 0) {
> -               if (info->micd_modes[0].gpio)
> +               if (gpio_initial_level)
>                         mode = GPIOF_OUT_INIT_HIGH;
>                 else
>                         mode = GPIOF_OUT_INIT_LOW;
> --
> 1.7.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1168757

On Fri, Jun 19, 2015 at 09:29:34PM +0900, Chanwoo Choi wrote:
> Hi Charles,
> 
> I'm sorry about lack of my commet on previous patch.
> I just want to know the what is meaning of zero(0) index of
> "info->micd_modes[0] array"
> instead of separate variable (gpio_initial_level).
> 
> So, I'd like you to drop this patch on next your patch-set.
> 
> Thanks,
> Chanwoo Choi
> 

:-) And I just spotted this after sending the next version. I
will send another version.

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web