Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1168647 > unrolled thread
| Started by | Johannes Thumshirn <jthumshirn@suse.de> |
|---|---|
| First post | 2015-06-19 11:20 +0200 |
| Last post | 2015-06-19 12:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support Johannes Thumshirn <jthumshirn@suse.de> - 2015-06-19 11:20 +0200
Re: [PATCH 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support Sreekanth Reddy <sreekanth.reddy@avagotech.com> - 2015-06-19 11:30 +0200
Re: [PATCH 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support Johannes Thumshirn <jthumshirn@suse.de> - 2015-06-19 12:00 +0200
| From | Johannes Thumshirn <jthumshirn@suse.de> |
|---|---|
| Date | 2015-06-19 11:20 +0200 |
| Subject | Re: [PATCH 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support |
| Message-ID | <pD0CR-34E-5@gated-at.bofh.it> |
On Thu, Jun 18, 2015 at 03:27:26PM +0530, Sreekanth Reddy wrote:
> Hi,
>
> Any other review comments on this patch. please let us known if any
> changes are required.
>
> Thanks,
> Sreekanth
>
Have you sent a follow up on this I may have missed?
> On Fri, Jun 12, 2015 at 4:46 PM, Sreekanth Reddy
> <sreekanth.reddy@avagotech.com> wrote:
> > Thanks Johannes, we will take care of this point in our current
> > on-development mpt2sas/mpt3sas merging activity.
> >>> diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
[...]
> >>> index 14a781b..c13a365 100644
> >>> --- a/drivers/scsi/mpt3sas/mpt3sas_base.c
> >>> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
> >>> @@ -83,7 +83,7 @@ static int msix_disable = -1;
> >>> module_param(msix_disable, int, 0);
> >>> MODULE_PARM_DESC(msix_disable, " disable msix routed interrupts (default=0)");
> >>>
> >>> -static int max_msix_vectors = 8;
> >>> +static int max_msix_vectors = -1;
> >>> module_param(max_msix_vectors, int, 0);
> >>> MODULE_PARM_DESC(max_msix_vectors,
> >>> " max msix vectors - (default=8)");
^^^^^^^^^^^
> >>
> >> When changing the default value, please also update the description reflecting
> >> this change.
> >>
Thanks
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Sreekanth Reddy <sreekanth.reddy@avagotech.com> |
|---|---|
| Date | 2015-06-19 11:30 +0200 |
| Message-ID | <pD0My-3fQ-21@gated-at.bofh.it> |
| In reply to | #1168647 |
On Fri, Jun 19, 2015 at 2:44 PM, Johannes Thumshirn <jthumshirn@suse.de> wrote: > On Thu, Jun 18, 2015 at 03:27:26PM +0530, Sreekanth Reddy wrote: >> Hi, >> >> Any other review comments on this patch. please let us known if any >> changes are required. >> >> Thanks, >> Sreekanth >> > > Have you sent a follow up on this I may have missed? > >> On Fri, Jun 12, 2015 at 4:46 PM, Sreekanth Reddy >> <sreekanth.reddy@avagotech.com> wrote: >> > Thanks Johannes, we will take care of this point in our current >> > on-development mpt2sas/mpt3sas merging activity. >> >>> diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c > > [...] > >> >>> index 14a781b..c13a365 100644 >> >>> --- a/drivers/scsi/mpt3sas/mpt3sas_base.c >> >>> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c >> >>> @@ -83,7 +83,7 @@ static int msix_disable = -1; >> >>> module_param(msix_disable, int, 0); >> >>> MODULE_PARM_DESC(msix_disable, " disable msix routed interrupts (default=0)"); >> >>> >> >>> -static int max_msix_vectors = 8; >> >>> +static int max_msix_vectors = -1; >> >>> module_param(max_msix_vectors, int, 0); >> >>> MODULE_PARM_DESC(max_msix_vectors, >> >>> " max msix vectors - (default=8)"); > ^^^^^^^^^^^ >> >> >> >> When changing the default value, please also update the description reflecting >> >> this change. Johannes, I didn't notice this previously, I will post next version of this patch by updating the module parameter description Thanks, Sreekanth >> >> > > Thanks > > -- > Johannes Thumshirn Storage > jthumshirn@suse.de +49 911 74053 689 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton > HRB 21284 (AG Nürnberg) -- Regards, Sreekanth -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Johannes Thumshirn <jthumshirn@suse.de> |
|---|---|
| Date | 2015-06-19 12:00 +0200 |
| Message-ID | <pD1fB-3NZ-39@gated-at.bofh.it> |
| In reply to | #1168655 |
On Fri, Jun 19, 2015 at 02:51:00PM +0530, Sreekanth Reddy wrote: > On Fri, Jun 19, 2015 at 2:44 PM, Johannes Thumshirn <jthumshirn@suse.de> wrote: > > On Thu, Jun 18, 2015 at 03:27:26PM +0530, Sreekanth Reddy wrote: > >> Hi, > >> > >> Any other review comments on this patch. please let us known if any > >> changes are required. > >> > >> Thanks, > >> Sreekanth > >> > > > > Have you sent a follow up on this I may have missed? > > > >> On Fri, Jun 12, 2015 at 4:46 PM, Sreekanth Reddy > >> <sreekanth.reddy@avagotech.com> wrote: > >> > Thanks Johannes, we will take care of this point in our current > >> > on-development mpt2sas/mpt3sas merging activity. > >> >>> diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c > > > > [...] > > > >> >>> index 14a781b..c13a365 100644 > >> >>> --- a/drivers/scsi/mpt3sas/mpt3sas_base.c > >> >>> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c > >> >>> @@ -83,7 +83,7 @@ static int msix_disable = -1; > >> >>> module_param(msix_disable, int, 0); > >> >>> MODULE_PARM_DESC(msix_disable, " disable msix routed interrupts (default=0)"); > >> >>> > >> >>> -static int max_msix_vectors = 8; > >> >>> +static int max_msix_vectors = -1; > >> >>> module_param(max_msix_vectors, int, 0); > >> >>> MODULE_PARM_DESC(max_msix_vectors, > >> >>> " max msix vectors - (default=8)"); > > ^^^^^^^^^^^ > >> >> > >> >> When changing the default value, please also update the description reflecting > >> >> this change. > > Johannes, I didn't notice this previously, I will post next version of > this patch by updating the module parameter description No problem :-) > > Thanks, > Sreekanth > >> >> > > > > Thanks > > > > -- > > Johannes Thumshirn Storage > > jthumshirn@suse.de +49 911 74053 689 > > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > > GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton > > HRB 21284 (AG Nürnberg) > > > > -- > > Regards, > Sreekanth -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web