Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1167414 > unrolled thread

Re: [RFC][PATCH 2/5] mm/mempool: allow NULL `pool' pointer in mempool_destroy()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [RFC][PATCH 2/5] mm/mempool: allow NULL `pool' pointer in  mempool_destroy() David Rientjes <rientjes@google.com> - 2015-06-18 01:30 +0200
    Re: [RFC][PATCH 2/5] mm/mempool: allow NULL `pool' pointer in  mempool_destroy() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-06-18 02:00 +0200

#1167414 — Re: [RFC][PATCH 2/5] mm/mempool: allow NULL `pool' pointer in mempool_destroy()

On Tue, 9 Jun 2015, Sergey Senozhatsky wrote:

> mempool_destroy() does not tolerate a NULL mempool_t pointer
> argument and performs a NULL-pointer dereference. This requires
> additional attention and effort from developers/reviewers and
> forces all mempool_destroy() callers to do a NULL check
> 
> 	if (pool)
> 		mempool_destroy(pool);
> 
> Or, otherwise, be invalid mempool_destroy() users.
> 
> Tweak mempool_destroy() and NULL-check the pointer there.
> 
> Proposed by Andrew Morton.
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Reported-by: Andrew Morton <akpm@linux-foundation.org>
> LKML-reference: https://lkml.org/lkml/2015/6/8/583

Acked-by: David Rientjes <rientjes@google.com>

I like how your patch series is enabling us to remove many lines from the 
source code.  But doing s/Reported-by/Suggested-by/ can also make your 
changelog two lines shorter ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1167490

On (06/17/15 16:21), David Rientjes wrote:
[..]
> > Tweak mempool_destroy() and NULL-check the pointer there.
> > 
> > Proposed by Andrew Morton.
> > 
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Reported-by: Andrew Morton <akpm@linux-foundation.org>
> > LKML-reference: https://lkml.org/lkml/2015/6/8/583
> 
> Acked-by: David Rientjes <rientjes@google.com>
> 
> I like how your patch series is enabling us to remove many lines from the 
> source code.  But doing s/Reported-by/Suggested-by/ can also make your 
> changelog two lines shorter ;)
> 

Thanks.

Oh, s/Reported-by/Suggested-by/ looks better, indeed.

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web