Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1167623 > unrolled thread

Re: [PATCH] clk: at91: add generated clock driver

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] clk: at91: add generated clock driver Paul Bolle <pebolle@tiscali.nl> - 2015-06-18 09:20 +0200
    Re: [PATCH] clk: at91: add generated clock driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-06-18 09:40 +0200
      Re: [PATCH] clk: at91: add generated clock driver Paul Bolle <pebolle@tiscali.nl> - 2015-06-18 09:50 +0200
      Re: [PATCH] clk: at91: add generated clock driver Nicolas Ferre <nicolas.ferre@atmel.com> - 2015-06-18 09:50 +0200
        Re: [PATCH] clk: at91: add generated clock driver Paul Bolle <pebolle@tiscali.nl> - 2015-06-18 10:00 +0200

#1167623 — Re: [PATCH] clk: at91: add generated clock driver

On Wed, 2015-06-17 at 15:23 +0200, Nicolas Ferre wrote:

> --- a/arch/arm/mach-at91/Kconfig
> +++ b/arch/arm/mach-at91/Kconfig
 
> +config HAVE_AT91_GENERATED
> +	bool

This will always be 'n'.  

> --- a/drivers/clk/at91/Makefile
> +++ b/drivers/clk/at91/Makefile

> +obj-$(CONFIG_HAVE_AT91_GENERATED)	+= clk-generated.o

And clk-generated.o will never be built.

I think your options are to use
	config HAVE_AT91_GENERATED
		def_bool y

or
	config HAVE_AT91_GENERATED
		bool "Yadda yadda yadda"

or add
	select HAVE_AT91_GENERATED

somewhere (possibly even in a second patch). But as it stands the patch
looks like an elaborate NOP.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1167628

Hi Paul,

On Thu, 18 Jun 2015 09:12:36 +0200
Paul Bolle <pebolle@tiscali.nl> wrote:

> On Wed, 2015-06-17 at 15:23 +0200, Nicolas Ferre wrote:
> 
> > --- a/arch/arm/mach-at91/Kconfig
> > +++ b/arch/arm/mach-at91/Kconfig
>  
> > +config HAVE_AT91_GENERATED
> > +	bool
> 
> This will always be 'n'.  
> 
> > --- a/drivers/clk/at91/Makefile
> > +++ b/drivers/clk/at91/Makefile
> 
> > +obj-$(CONFIG_HAVE_AT91_GENERATED)	+= clk-generated.o
> 
> And clk-generated.o will never be built.
> 
> I think your options are to use
> 	config HAVE_AT91_GENERATED
> 		def_bool y
> 
> or
> 	config HAVE_AT91_GENERATED
> 		bool "Yadda yadda yadda"
> 
> or add
> 	select HAVE_AT91_GENERATED
> 
> somewhere (possibly even in a second patch). But as it stands the patch
> looks like an elaborate NOP.

I guess it will be selected by platforms embedding such clks. We just
have to wait for those platform to reach mainline ;-). 

Best Regards,

Boris
-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1167636

On Thu, 2015-06-18 at 09:33 +0200, Boris Brezillon wrote:
> I guess it will be selected by platforms embedding such clks. We just
> have to wait for those platform to reach mainline ;-). 

So what's the point of this patch at this moment?


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1167638

Le 18/06/2015 09:33, Boris Brezillon a écrit :
> Hi Paul,
> 
> On Thu, 18 Jun 2015 09:12:36 +0200
> Paul Bolle <pebolle@tiscali.nl> wrote:
> 
>> On Wed, 2015-06-17 at 15:23 +0200, Nicolas Ferre wrote:
>>
>>> --- a/arch/arm/mach-at91/Kconfig
>>> +++ b/arch/arm/mach-at91/Kconfig
>>  
>>> +config HAVE_AT91_GENERATED
>>> +	bool
>>
>> This will always be 'n'.  
>>
>>> --- a/drivers/clk/at91/Makefile
>>> +++ b/drivers/clk/at91/Makefile
>>
>>> +obj-$(CONFIG_HAVE_AT91_GENERATED)	+= clk-generated.o
>>
>> And clk-generated.o will never be built.
>>
>> I think your options are to use
>> 	config HAVE_AT91_GENERATED
>> 		def_bool y
>>
>> or
>> 	config HAVE_AT91_GENERATED
>> 		bool "Yadda yadda yadda"
>>
>> or add
>> 	select HAVE_AT91_GENERATED
>>
>> somewhere (possibly even in a second patch). But as it stands the patch
>> looks like an elaborate NOP.
> 
> I guess it will be selected by platforms embedding such clks. We just
> have to wait for those platform to reach mainline ;-). 

Yes, absolutely.

I am in the process, with my colleagues, of building bricks for our
upcoming SoC the sama5d2. So, the basic support for this chip will come
in the next weeks and will select this Kconfig option.

I'd like though that this matter of fact doesn't block this piece of
code from being reviewed or even better merged in order to ease this new
SoC landing...

Bye,
-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1167647

Hi Nicolas,

On Thu, 2015-06-18 at 09:40 +0200, Nicolas Ferre wrote:
> I am in the process, with my colleagues, of building bricks for our
> upcoming SoC the sama5d2. So, the basic support for this chip will come
> in the next weeks and will select this Kconfig option.

Perhaps that could be added, say below the --- marker in the patch.
Maybe I missed something to that effect. Anyhow, I didn't spot in the
patch that this was done deliberately. It had all the looks of a silly
mistake.

> I'd like though that this matter of fact doesn't block this piece of
> code from being reviewed or even better merged in order to ease this new
> SoC landing...

The other side of that is that the sama5d2 might never make it, or take
very long to make it, into mainline. And this would then end up being
yet another chunk of code adding no value to mainline.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web