Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1166358 > unrolled thread
| Started by | Frodo Lai <frodo.lai@gmail.com> |
|---|---|
| First post | 2015-06-16 22:10 +0200 |
| Last post | 2015-06-17 00:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Input: pixcir_i2c_ts - fix receive error Frodo Lai <frodo.lai@gmail.com> - 2015-06-16 22:10 +0200
Re: [PATCH] Input: pixcir_i2c_ts - fix receive error Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-06-17 00:10 +0200
| From | Frodo Lai <frodo.lai@gmail.com> |
|---|---|
| Date | 2015-06-16 22:10 +0200 |
| Subject | [PATCH] Input: pixcir_i2c_ts - fix receive error |
| Message-ID | <pC5lg-4rn-19@gated-at.bofh.it> |
The i2c_master_recv() uses readsize to receive data from i2c but
compares to size of rdbuf which is always 27. This would casue
problem when the max_fingers is not 5. Change the comparison value
to readsize instead.
Signed-off-by: Frodo Lai <frodo_lai@bcmcom.com>
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c
index 2c21071..8f3e243 100644
--- a/drivers/input/touchscreen/pixcir_i2c_ts.c
+++ b/drivers/input/touchscreen/pixcir_i2c_ts.c
@@ -78,7 +78,7 @@ static void pixcir_ts_parse(struct pixcir_i2c_ts_data *tsdata,
}
ret = i2c_master_recv(tsdata->client, rdbuf, readsize);
- if (ret != sizeof(rdbuf)) {
+ if (ret != readsize) {
dev_err(&tsdata->client->dev,
"%s: i2c_master_recv failed(), ret=%d\n",
__func__, ret);
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2015-06-17 00:10 +0200 |
| Message-ID | <pC7dn-787-5@gated-at.bofh.it> |
| In reply to | #1166358 |
On Tue, Jun 16, 2015 at 01:03:04PM -0700, Frodo Lai wrote:
> The i2c_master_recv() uses readsize to receive data from i2c but
> compares to size of rdbuf which is always 27. This would casue
> problem when the max_fingers is not 5. Change the comparison value
> to readsize instead.
>
> Signed-off-by: Frodo Lai <frodo_lai@bcmcom.com>
Applied, thank you.
> ---
> drivers/input/touchscreen/pixcir_i2c_ts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c
> index 2c21071..8f3e243 100644
> --- a/drivers/input/touchscreen/pixcir_i2c_ts.c
> +++ b/drivers/input/touchscreen/pixcir_i2c_ts.c
> @@ -78,7 +78,7 @@ static void pixcir_ts_parse(struct pixcir_i2c_ts_data *tsdata,
> }
>
> ret = i2c_master_recv(tsdata->client, rdbuf, readsize);
> - if (ret != sizeof(rdbuf)) {
> + if (ret != readsize) {
> dev_err(&tsdata->client->dev,
> "%s: i2c_master_recv failed(), ret=%d\n",
> __func__, ret);
> --
> 1.7.9.5
>
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web