Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1166346 > unrolled thread

Re: [PATCH] x86/raid6: correctly check for assembler capabilities

Started by"H. Peter Anvin" <hpa@zytor.com>
First post2015-06-16 21:50 +0200
Last post2015-06-16 23:00 +0200
Articles 6 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] x86/raid6: correctly check for assembler capabilities "H. Peter Anvin" <hpa@zytor.com> - 2015-06-16 21:50 +0200
    Re: [PATCH] x86/raid6: correctly check for assembler capabilities Paul Bolle <pebolle@tiscali.nl> - 2015-06-16 22:00 +0200
      Re: [PATCH] x86/raid6: correctly check for assembler capabilities "H. Peter Anvin" <hpa@zytor.com> - 2015-06-16 22:10 +0200
        Re: [PATCH] x86/raid6: correctly check for assembler capabilities Paul Bolle <pebolle@tiscali.nl> - 2015-06-16 22:40 +0200
          Re: [PATCH] x86/raid6: correctly check for assembler capabilities "H. Peter Anvin" <hpa@zytor.com> - 2015-06-16 22:50 +0200
            Re: [PATCH] x86/raid6: correctly check for assembler capabilities Paul Bolle <pebolle@tiscali.nl> - 2015-06-16 23:00 +0200

#1166346 — Re: [PATCH] x86/raid6: correctly check for assembler capabilities

From"H. Peter Anvin" <hpa@zytor.com>
Date2015-06-16 21:50 +0200
SubjectRe: [PATCH] x86/raid6: correctly check for assembler capabilities
Message-ID<pC51T-3OF-11@gated-at.bofh.it>
On 02/03/2015 01:03 PM, Paul Bolle wrote:
> On Wed, 2015-02-04 at 07:50 +1100, NeilBrown wrote:
>> Actually the prefix of this macro is "CONFIG_AS_", not "CONFIG_" :-)
>> CONFIG_AS_ is reserved for assembly magic, and is never used by the the
>> kconfig system.
>>
>> (Well..... I might have made bits of that up, but "git grep 'config AS_'"
>> doesn't find anything).
> 
> That's correct, there are no Kconfig symbols starting with AS_. But
> still, I would like to hear whether there's a reasonable chance I might
> convince other people to adopt my peeve.
> 
> The thinking behind that peeve is, basically, that where people
> encounter a CONFIG_* macro they should only have to check the .config
> file to see how that macro was evaluated in the build that was used.
> 

There is a hope/intent that eventually the config system will be able to
incorporate toolchain dependencies for a bunch of reasons.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1166349

FromPaul Bolle <pebolle@tiscali.nl>
Date2015-06-16 22:00 +0200
Message-ID<pC5bA-40P-19@gated-at.bofh.it>
In reply to#1166346
On Tue, 2015-06-16 at 12:46 -0700, H. Peter Anvin wrote:
> There is a hope/intent that eventually the config system will be able to
> incorporate toolchain dependencies for a bunch of reasons.

This restarts a four months old thread with a one sentence remark. So
could you please elaborate, because now you've left me and, perhaps, the
other people reading this wondering what "toolchain dependencies"
actually means and what those "bunch of reasons" are.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1166354

From"H. Peter Anvin" <hpa@zytor.com>
Date2015-06-16 22:10 +0200
Message-ID<pC5lf-4rn-7@gated-at.bofh.it>
In reply to#1166349
On 06/16/2015 12:56 PM, Paul Bolle wrote:
> On Tue, 2015-06-16 at 12:46 -0700, H. Peter Anvin wrote:
>> There is a hope/intent that eventually the config system will be able to
>> incorporate toolchain dependencies for a bunch of reasons.
> 
> This restarts a four months old thread with a one sentence remark. So
> could you please elaborate, because now you've left me and, perhaps, the
> other people reading this wondering what "toolchain dependencies"
> actually means and what those "bunch of reasons" are.
> 

Sorry, missed the date on this in my inbox for some reason.

So this related to the CONFIG_AS_ symbols for assembly.  We really would
like to do things like actually adding dependencies on assembler or
compiler support into Kconfig proper, rather than having two independent
mechanisms.  That way we could do, for example:

config RAID6_AVX2
	depends on X86 && AS_AVX2


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1166389

FromPaul Bolle <pebolle@tiscali.nl>
Date2015-06-16 22:40 +0200
Message-ID<pC5Oi-4ZG-33@gated-at.bofh.it>
In reply to#1166354
On Tue, 2015-06-16 at 13:05 -0700, H. Peter Anvin wrote:
> So this related to the CONFIG_AS_ symbols for assembly.  We really would
> like to do things like actually adding dependencies on assembler or
> compiler support into Kconfig proper, rather than having two independent
> mechanisms.  That way we could do, for example:
> 
> config RAID6_AVX2
> 	depends on X86 && AS_AVX2

I have no idea what AS_AVX2 means, sorry. So what would it mean if
someone has a .config with
    CONFIG_AS_AVX2=foo

Ie, what would happen if someone using a toolchain for which that would
not be possible tries to build a kernel with that symbol set? That
person's .config would end up containing
    # CONFIG_AS_AVX2 is not set

or similar, right? 


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1166397

From"H. Peter Anvin" <hpa@zytor.com>
Date2015-06-16 22:50 +0200
Message-ID<pC5XY-5b9-5@gated-at.bofh.it>
In reply to#1166389
On 06/16/2015 01:37 PM, Paul Bolle wrote:
> 
> I have no idea what AS_AVX2 means, sorry. So what would it mean if
> someone has a .config with
>     CONFIG_AS_AVX2=foo
> 
> Ie, what would happen if someone using a toolchain for which that would
> not be possible tries to build a kernel with that symbol set? That
> person's .config would end up containing
>     # CONFIG_AS_AVX2 is not set
> 
> or similar, right? 
> 

Yes, these would be generated, not user input.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1166405

FromPaul Bolle <pebolle@tiscali.nl>
Date2015-06-16 23:00 +0200
Message-ID<pC67E-5mw-13@gated-at.bofh.it>
In reply to#1166397
On Tue, 2015-06-16 at 13:42 -0700, H. Peter Anvin wrote:
> Yes, these would be generated, not user input.

I think someone (Jiri Kosina?) proposed shelling out to set Kconfig
values. I don't think any patches were ever submitted. But I guess
something along those lines would be needed to adopt the .config to the
toolchain at hand. As long as we don't do anything funny once we've
generated the .config file that might just work.

Yes, I know, the devil hides in the details.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web