Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1164917 > unrolled thread

Re: [PATCH 1/1] pcmcia: Fix resource leaks in yenta_probe() and _close()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/1] pcmcia: Fix resource leaks in yenta_probe() and  _close() Dominik Brodowski <linux@dominikbrodowski.net> - 2015-06-14 22:00 +0200

#1164917 — Re: [PATCH 1/1] pcmcia: Fix resource leaks in yenta_probe() and _close()

[Multipart message — attachments visible in raw view] — view raw

On Mon, Jun 15, 2015 at 02:43:59AM +0900, Takeshi Yoshimura wrote:
> There are some resource leaks in yenta_probe() and _close(). I fixed
> the following issues with some code cleanups. Thanks to Dominik's
> suggestions.
> 
> On the error path in yenta_probe():
> - a requested irq is not released
> - yenta_free_resources() and pci_set_drvdata(dev, NULL) are not called
> 
> In yenta_close():
> - kfree(sock) is not called
> - sock->base is always set to non-NULL when yenta_close() is called,
>   therefore the check in yenta_close() is not necessary.
> 
> Signed-off-by: Takeshi Yoshimura <yos@sslab.ics.keio.ac.jp>

Applied to the PCMCIA tree. Many thanks!

	Dominik

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web