Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1164911 > unrolled thread
| Started by | Markus Böhme <markus.boehme@mailbox.org> |
|---|---|
| First post | 2015-06-14 21:00 +0200 |
| Last post | 2015-06-15 05:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] Staging: sm750fb: fix checkpatch.pl indentation warnings Markus Böhme <markus.boehme@mailbox.org> - 2015-06-14 21:00 +0200
Re: [PATCH] Staging: sm750fb: fix checkpatch.pl indentation warnings "Dighe, Niranjan (N.)" <ndighe@visteon.com> - 2015-06-15 05:40 +0200
| From | Markus Böhme <markus.boehme@mailbox.org> |
|---|---|
| Date | 2015-06-14 21:00 +0200 |
| Subject | Re: [PATCH] Staging: sm750fb: fix checkpatch.pl indentation warnings |
| Message-ID | <pBlip-4Jt-3@gated-at.bofh.it> |
> This patch fixes indentation issues by replacing spaces by tabs at > the start of line > > Signed-off-by: Niranjan Dighe <ndighe@visteon.com> > > diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c > index b2bf7e6..c73b74a 100644 > --- a/drivers/staging/sm750fb/ddk750_dvi.c > +++ b/drivers/staging/sm750fb/ddk750_dvi.c > - if(pCurrentDviCtrl->pfnInit != NULL) > + if (pCurrentDviCtrl->pfnInit != NULL) You are fixing a different type of warning here. Please make only one kind of change per patch. Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | "Dighe, Niranjan (N.)" <ndighe@visteon.com> |
|---|---|
| Date | 2015-06-15 05:40 +0200 |
| Message-ID | <pBtpD-8eb-5@gated-at.bofh.it> |
| In reply to | #1164911 |
On Sun, Jun 14, 2015 at 08:45:02PM +0200, Markus Böhme wrote: > >This patch fixes indentation issues by replacing spaces by tabs at > >the start of line > > > >Signed-off-by: Niranjan Dighe <ndighe@visteon.com> > > > >diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c > >index b2bf7e6..c73b74a 100644 > >--- a/drivers/staging/sm750fb/ddk750_dvi.c > >+++ b/drivers/staging/sm750fb/ddk750_dvi.c > > >- if(pCurrentDviCtrl->pfnInit != NULL) > >+ if (pCurrentDviCtrl->pfnInit != NULL) > > You are fixing a different type of warning here. Please make only one > kind of change per patch. > > Regards, > Markus > Hello Markus, Thanks for your review. I will correct and resend a new patch. Please disregard this for the moment. Thanks, Niranjan Dighe-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web