Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1160755 > unrolled thread
| Started by | Stefan Agner <stefan@agner.ch> |
|---|---|
| First post | 2015-06-08 22:10 +0200 |
| Last post | 2015-06-14 13:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v5 1/2] iio: adc: vf610: implement configurable conversion modes Stefan Agner <stefan@agner.ch> - 2015-06-08 22:10 +0200
Re: [PATCH v5 1/2] iio: adc: vf610: implement configurable conversion modes Jonathan Cameron <jic23@kernel.org> - 2015-06-14 13:20 +0200
| From | Stefan Agner <stefan@agner.ch> |
|---|---|
| Date | 2015-06-08 22:10 +0200 |
| Subject | Re: [PATCH v5 1/2] iio: adc: vf610: implement configurable conversion modes |
| Message-ID | <pzbwR-QJ-9@gated-at.bofh.it> |
On 2015-06-08 19:49, Rob Herring wrote: > On Wed, May 27, 2015 at 7:47 AM, Stefan Agner <stefan@agner.ch> wrote: >> Support configurable conversion mode through sysfs. So far, the >> mode used was low-power, which is enabled by default now. Beside >> that, the modes normal and high-speed are selectable as well. >> >> Use the new device tree property which specifies the maximum ADC >> conversion clock frequencies. Depending on the mode used, the >> available resulting conversion frequency are calculated >> dynamically. >> >> Acked-by: Fugang Duan <B38611@freescale.com> >> Signed-off-by: Stefan Agner <stefan@agner.ch> >> --- >> Documentation/ABI/testing/sysfs-bus-iio-vf610 | 7 + >> .../devicetree/bindings/iio/adc/vf610-adc.txt | 9 ++ >> drivers/iio/adc/vf610_adc.c | 146 +++++++++++++++------ >> 3 files changed, 120 insertions(+), 42 deletions(-) >> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-vf610 >> >> diff --git a/Documentation/ABI/testing/sysfs-bus-iio-vf610 b/Documentation/ABI/testing/sysfs-bus-iio-vf610 >> new file mode 100644 >> index 0000000..ecbc1f4 >> --- /dev/null >> +++ b/Documentation/ABI/testing/sysfs-bus-iio-vf610 >> @@ -0,0 +1,7 @@ >> +What: /sys/bus/iio/devices/iio:deviceX/conversion_mode >> +KernelVersion: 4.2 >> +Contact: linux-iio@vger.kernel.org >> +Description: >> + Specifies the hardware conversion mode used. The three >> + available modes are "normal", "high-speed" and "low-power", >> + where the last is the default mode. >> diff --git a/Documentation/devicetree/bindings/iio/adc/vf610-adc.txt b/Documentation/devicetree/bindings/iio/adc/vf610-adc.txt >> index 1a4a43d..3eb40e2 100644 >> --- a/Documentation/devicetree/bindings/iio/adc/vf610-adc.txt >> +++ b/Documentation/devicetree/bindings/iio/adc/vf610-adc.txt >> @@ -11,6 +11,13 @@ Required properties: >> - clock-names: Must contain "adc", matching entry in the clocks property. >> - vref-supply: The regulator supply ADC reference voltage. >> >> +Recommended properties: >> +- fsl,adck-max-frequency: Maximum frequencies according to datasheets operating >> + requirements. Three values are required, depending on conversion mode: >> + - Frequency in normal mode (ADLPC=0, ADHSC=0) >> + - Frequency in high-speed mode (ADLPC=0, ADHSC=1) >> + - Frequency in low-power mode (ADLPC=1, ADHSC=0) > > Why is this "adck" rather than "adc"? That is the name of the clock according to the reference manual and data sheet. > How is this related to today's patch adding min-sample-time? It is related in that this clock is the base to calculate the sampling time, but otherwise not really related. Afaik, not respecting the maximum clock frequency is probably more a issue for the SAR part of the ADC. -- Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2015-06-14 13:20 +0200 |
| Message-ID | <pBe7f-2jh-1@gated-at.bofh.it> |
| In reply to | #1160755 |
On 08/06/15 21:07, Stefan Agner wrote: > On 2015-06-08 19:49, Rob Herring wrote: >> On Wed, May 27, 2015 at 7:47 AM, Stefan Agner <stefan@agner.ch> wrote: >>> Support configurable conversion mode through sysfs. So far, the >>> mode used was low-power, which is enabled by default now. Beside >>> that, the modes normal and high-speed are selectable as well. >>> >>> Use the new device tree property which specifies the maximum ADC >>> conversion clock frequencies. Depending on the mode used, the >>> available resulting conversion frequency are calculated >>> dynamically. >>> >>> Acked-by: Fugang Duan <B38611@freescale.com> >>> Signed-off-by: Stefan Agner <stefan@agner.ch> >>> --- >>> Documentation/ABI/testing/sysfs-bus-iio-vf610 | 7 + >>> .../devicetree/bindings/iio/adc/vf610-adc.txt | 9 ++ >>> drivers/iio/adc/vf610_adc.c | 146 +++++++++++++++------ >>> 3 files changed, 120 insertions(+), 42 deletions(-) >>> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-vf610 >>> >>> diff --git a/Documentation/ABI/testing/sysfs-bus-iio-vf610 b/Documentation/ABI/testing/sysfs-bus-iio-vf610 >>> new file mode 100644 >>> index 0000000..ecbc1f4 >>> --- /dev/null >>> +++ b/Documentation/ABI/testing/sysfs-bus-iio-vf610 >>> @@ -0,0 +1,7 @@ >>> +What: /sys/bus/iio/devices/iio:deviceX/conversion_mode >>> +KernelVersion: 4.2 >>> +Contact: linux-iio@vger.kernel.org >>> +Description: >>> + Specifies the hardware conversion mode used. The three >>> + available modes are "normal", "high-speed" and "low-power", >>> + where the last is the default mode. >>> diff --git a/Documentation/devicetree/bindings/iio/adc/vf610-adc.txt b/Documentation/devicetree/bindings/iio/adc/vf610-adc.txt >>> index 1a4a43d..3eb40e2 100644 >>> --- a/Documentation/devicetree/bindings/iio/adc/vf610-adc.txt >>> +++ b/Documentation/devicetree/bindings/iio/adc/vf610-adc.txt >>> @@ -11,6 +11,13 @@ Required properties: >>> - clock-names: Must contain "adc", matching entry in the clocks property. >>> - vref-supply: The regulator supply ADC reference voltage. >>> >>> +Recommended properties: >>> +- fsl,adck-max-frequency: Maximum frequencies according to datasheets operating >>> + requirements. Three values are required, depending on conversion mode: >>> + - Frequency in normal mode (ADLPC=0, ADHSC=0) >>> + - Frequency in high-speed mode (ADLPC=0, ADHSC=1) >>> + - Frequency in low-power mode (ADLPC=1, ADHSC=0) >> >> Why is this "adck" rather than "adc"? > > That is the name of the clock according to the reference manual and data > sheet. > >> How is this related to today's patch adding min-sample-time? > > It is related in that this clock is the base to calculate the sampling > time, but otherwise not really related. Afaik, not respecting the > maximum clock frequency is probably more a issue for the SAR part of the > ADC. Rob, are you happy with Stefan's responses? > > -- > Stefan > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web