Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1165546 > unrolled thread
| Started by | Kees Cook <keescook@chromium.org> |
|---|---|
| First post | 2015-06-15 22:50 +0200 |
| Last post | 2015-06-15 23:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 0/2] Consolidate redundant register/stack access code Kees Cook <keescook@chromium.org> - 2015-06-15 22:50 +0200
Re: [PATCH 0/2] Consolidate redundant register/stack access code David Long <dave.long@linaro.org> - 2015-06-15 23:00 +0200
| From | Kees Cook <keescook@chromium.org> |
|---|---|
| Date | 2015-06-15 22:50 +0200 |
| Subject | Re: [PATCH 0/2] Consolidate redundant register/stack access code |
| Message-ID | <pBJur-65B-29@gated-at.bofh.it> |
On Mon, Jun 15, 2015 at 9:42 AM, David Long <dave.long@linaro.org> wrote: > From: "David A. Long" <dave.long@linaro.org> > > Move duplicate and functionally equivalent code for accessing registers > and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into > common kernel files. > > Note: Help regression testing s390, hexagon, and sh would be appreciated. > Powerpc builds but I have not verified the functionality. > > David A. Long (2): > Move the pt_regs_offset struct definition from arch to common include > file > Consolidate redundant register/stack access code > > arch/arm/include/asm/ptrace.h | 6 --- > arch/arm/kernel/ptrace.c | 72 +--------------------------------- > arch/hexagon/include/uapi/asm/ptrace.h | 3 -- > arch/powerpc/include/asm/ptrace.h | 38 ------------------ > arch/powerpc/kernel/ptrace.c | 39 +----------------- > arch/s390/include/asm/ptrace.h | 3 -- > arch/s390/kernel/ptrace.c | 70 ++++++++++----------------------- > arch/sh/include/asm/ptrace.h | 44 --------------------- > arch/sh/kernel/Makefile | 2 +- > arch/sh/kernel/ptrace.c | 33 ---------------- > arch/sh/kernel/ptrace_32.c | 2 +- > arch/sh/kernel/ptrace_64.c | 2 +- > arch/x86/include/asm/ptrace.h | 37 ----------------- > arch/x86/kernel/ptrace.c | 39 +----------------- > include/linux/ptrace.h | 51 ++++++++++++++++++++++++ > kernel/ptrace.c | 38 ++++++++++++++++++ > 16 files changed, 116 insertions(+), 363 deletions(-) > delete mode 100644 arch/sh/kernel/ptrace.c I love the deletions:insertions ratio! :) Reviewed-by: Kees Cook <keescook@chromium.org> I wonder why arm64 doesn't define CONFIG_HAVE_REGS_AND_STACK_ACCESS_API? Thanks! -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | David Long <dave.long@linaro.org> |
|---|---|
| Date | 2015-06-15 23:00 +0200 |
| Message-ID | <pBJE6-6lM-9@gated-at.bofh.it> |
| In reply to | #1165546 |
On 06/15/15 16:44, Kees Cook wrote: > On Mon, Jun 15, 2015 at 9:42 AM, David Long <dave.long@linaro.org> wrote: >> From: "David A. Long" <dave.long@linaro.org> >> >> Move duplicate and functionally equivalent code for accessing registers >> and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into >> common kernel files. >> >> Note: Help regression testing s390, hexagon, and sh would be appreciated. >> Powerpc builds but I have not verified the functionality. >> >> David A. Long (2): >> Move the pt_regs_offset struct definition from arch to common include >> file >> Consolidate redundant register/stack access code >> >> arch/arm/include/asm/ptrace.h | 6 --- >> arch/arm/kernel/ptrace.c | 72 +--------------------------------- >> arch/hexagon/include/uapi/asm/ptrace.h | 3 -- >> arch/powerpc/include/asm/ptrace.h | 38 ------------------ >> arch/powerpc/kernel/ptrace.c | 39 +----------------- >> arch/s390/include/asm/ptrace.h | 3 -- >> arch/s390/kernel/ptrace.c | 70 ++++++++++----------------------- >> arch/sh/include/asm/ptrace.h | 44 --------------------- >> arch/sh/kernel/Makefile | 2 +- >> arch/sh/kernel/ptrace.c | 33 ---------------- >> arch/sh/kernel/ptrace_32.c | 2 +- >> arch/sh/kernel/ptrace_64.c | 2 +- >> arch/x86/include/asm/ptrace.h | 37 ----------------- >> arch/x86/kernel/ptrace.c | 39 +----------------- >> include/linux/ptrace.h | 51 ++++++++++++++++++++++++ >> kernel/ptrace.c | 38 ++++++++++++++++++ >> 16 files changed, 116 insertions(+), 363 deletions(-) >> delete mode 100644 arch/sh/kernel/ptrace.c > > I love the deletions:insertions ratio! :) > > Reviewed-by: Kees Cook <keescook@chromium.org> > > I wonder why arm64 doesn't define CONFIG_HAVE_REGS_AND_STACK_ACCESS_API? > That support is added in the patch I sent out after this one (to a different set of recipients). Thanks. > Thanks! > > -Kees > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web