Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1164657 > unrolled thread
| Started by | Christoph Hellwig <hch@infradead.org> |
|---|---|
| First post | 2015-06-13 18:20 +0200 |
| Last post | 2015-06-14 07:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 2/3] vfs, writeback: replace FS_CGROUP_WRITEBACK with MS_CGROUPWB Christoph Hellwig <hch@infradead.org> - 2015-06-13 18:20 +0200
Re: [PATCH 2/3] vfs, writeback: replace FS_CGROUP_WRITEBACK with MS_CGROUPWB Tejun Heo <tj@kernel.org> - 2015-06-14 07:50 +0200
| From | Christoph Hellwig <hch@infradead.org> |
|---|---|
| Date | 2015-06-13 18:20 +0200 |
| Subject | Re: [PATCH 2/3] vfs, writeback: replace FS_CGROUP_WRITEBACK with MS_CGROUPWB |
| Message-ID | <pAWk3-1fM-47@gated-at.bofh.it> |
On Fri, Jun 12, 2015 at 04:57:33PM -0500, Tejun Heo wrote: > FS_CGROUP_WRITEBACK indicates whether a file_system_type supports > cgroup writeback; however, different super_blocks of the same > file_system_type may or may not support cgroup writeback depending on > filesystem options. This patch replaces FS_CGROUP_WRITEBACK with a > kernel-internal super_block->s_flags MS_CGROUPWB. The concatenated > and abbreviated name is for consistency with other MS_* flags. Nak. As the uapi part makes it obvious the MS_ namespace is part of the userspace ABI. Please add a new in-kernel flags field instead. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Date | 2015-06-14 07:50 +0200 |
| Message-ID | <pB8XU-2RL-9@gated-at.bofh.it> |
| In reply to | #1164657 |
Hello, Christoph. On Sat, Jun 13, 2015 at 09:16:08AM -0700, Christoph Hellwig wrote: > On Fri, Jun 12, 2015 at 04:57:33PM -0500, Tejun Heo wrote: > > FS_CGROUP_WRITEBACK indicates whether a file_system_type supports > > cgroup writeback; however, different super_blocks of the same > > file_system_type may or may not support cgroup writeback depending on > > filesystem options. This patch replaces FS_CGROUP_WRITEBACK with a > > kernel-internal super_block->s_flags MS_CGROUPWB. The concatenated > > and abbreviated name is for consistency with other MS_* flags. > > Nak. As the uapi part makes it obvious the MS_ namespace is part > of the userspace ABI. Please add a new in-kernel flags field instead. Are MS_ACTIVE and MS_BORN part of userpace ABI? They seem pretty internal. I don't mind introducing a new internal flag field but it's weird to put this single flag there with other internal flags in ->s_flags. Assuming we add a new field, how do sb->s_iflags and SB_I_XXX sound? Any better suggestions? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web