Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1743301

Re: [kprobes/x86] a19b2e3d78: WARNING:at_kernel/locking/lockdep.c:#trace_hardirqs_off_caller

From Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [kprobes/x86] a19b2e3d78: WARNING:at_kernel/locking/lockdep.c:#trace_hardirqs_off_caller
Date 2017-10-02 22:50 +0200
Message-ID <uwfPg-ur-231@gated-at.bofh.it> (permalink)
References <uvzd7-2so-3@gated-at.bofh.it> <uw3ux-4tG-3@gated-at.bofh.it> <uwfPg-ur-233@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Oct 2, 2017 at 8:46 AM, Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> I'm considering to remove disabling-irq itself from jprobe.
> (Frankly to say, I would like to remove jprobe itself...)

Please please please...

That would be lovely. The jprobe thing is really nasty, and despite
the thing having been around forever (looking at history, it does back
to 2004) there are very few users and they all look dubious to me.

I seriously doubt anybody uses them, and I suspect our current tracing
infrastructure is just *so* much better and more powerful than jprobes
was.

So I'd heartily recommend just getting rid of jprobes. Or at least
trying, and seeing if anybody actually even notices (and then
reverting the removal and looking at what the usage ends up actually
being).

                            Linus

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [kprobes/x86]  a19b2e3d78:  WARNING:at_kernel/locking/lockdep.c:#trace_hardirqs_off_caller Peter Zijlstra <peterz@infradead.org> - 2017-10-02 09:40 +0200
  Re: [kprobes/x86] a19b2e3d78: WARNING:at_kernel/locking/lockdep.c:#trace_hardirqs_off_caller Linus Torvalds <torvalds@linux-foundation.org> - 2017-10-02 22:50 +0200
  Re: [kprobes/x86]  a19b2e3d78:  WARNING:at_kernel/locking/lockdep.c:#trace_hardirqs_off_caller Peter Zijlstra <peterz@infradead.org> - 2017-10-02 22:50 +0200
  Re: [kprobes/x86]  a19b2e3d78:  WARNING:at_kernel/locking/lockdep.c:#trace_hardirqs_off_caller Masami Hiramatsu <mhiramat@kernel.org> - 2017-10-02 22:50 +0200

csiph-web