Re: [PATCH] dt-bindings: fsl-imx-drm: Remove incorrect "@di0" usage

From	Philipp Zabel <p.zabel@pengutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] dt-bindings: fsl-imx-drm: Remove incorrect "@di0" usage
Date	2017-10-02 14:30 +0200
Message-ID	<uw81b-7ep-15@gated-at.bofh.it> (permalink)
References	<uw81c-7ep-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Marco,

On Fri, 2017-09-22 at 15:05 -0300, Marco Franchi wrote:
> Improve the binding example by removing the '@di0' notation, which
> fixes the following build warning:
> 
> Warning (unit_address_vs_reg): Node /display@di0 has a unit name, but 
> no reg property
> 
> Signed-off-by: Marco Franchi <marco.franchi@nxp.com>
> ---
>  Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/imx/fsl-imx-
> drm.txt b/Documentation/devicetree/bindings/display/imx/fsl-imx-
> drm.txt
> index f798547..44814f0 100644
> --- a/Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt
> +++ b/Documentation/devicetree/bindings/display/imx/fsl-imx-drm.txt
> @@ -129,7 +129,7 @@ Optional properties:
>  
>  example:
>  
> -display@di0 {
> +display-di0 {
>  	compatible = "fsl,imx-parallel-display";
>  	edid = [edid-data];
>  	interface-pix-fmt = "rgb24";

Thank you for the patch. We certainly should get rid of the @di0
notation. Since these nodes mostly describe the DISP0 and DISP1 pin
groups controlled by the IOMUXC, I'd prefer to rename this to

-display@di0 {
+disp0 {

instead, if that is fine with you.

I'd also like to move the disp0/disp1 nodes into the SoC dtsi files to
avoid having to duplicate port@0 all over the place.

regards
Philipp

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] dt-bindings: fsl-imx-drm: Remove incorrect "@di0" usage Philipp Zabel <p.zabel@pengutronix.de> - 2017-10-02 14:30 +0200

csiph-web