Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1742682

RE: [PATCH v3 2/8] platform/x86: dell-smbios: Introduce a WMI-ACPI interface

Show all headers | View raw

> -----Original Message-----
> From: Pali Rohár [mailto:pali.rohar@gmail.com]
> Sent: Saturday, September 30, 2017 2:16 AM
> To: Darren Hart <dvhart@infradead.org>
> Cc: Limonciello, Mario <Mario_Limonciello@Dell.com>; Andy Shevchenko
> <andy.shevchenko@gmail.com>; LKML <linux-kernel@vger.kernel.org>;
> platform-driver-x86@vger.kernel.org; Andy Lutomirski <luto@kernel.org>;
> quasisec@google.com
> Subject: Re: [PATCH v3 2/8] platform/x86: dell-smbios: Introduce a WMI-ACPI
> interface
> 
> On Saturday 30 September 2017 02:51:27 Darren Hart wrote:
> > > +DELL SMBIOS DRIVER
> > > +M:	Pali Rohár <pali.rohar@gmail.com>
> > > +M:	Mario Limonciello <mario.limonciello@dell.com>
> > > +S:	Maintained
> > > +F:	drivers/platform/x86/dell-smbios.*
> >
> > Pali, do you agree with this?
> 
> Yes, no problem.
> 
> > > -static int __init dell_smbios_init(void)
> > > +static int dell_smbios_wmi_probe(struct wmi_device *wdev)
> > > +{
> > > +	/* no longer need the SMI page */
> > > +	free_page((unsigned long)buffer);
> > > +
> > > +	/* WMI buffer should be 32k */
> > > +	buffer = (void *)__get_free_pages(GFP_KERNEL, 3);
> >
> > Assuming PAGE_SIZE here (I know, this driver, this architecture,
> > etc...). But, please use get_order() to determine number of pages
> > from a linear size:
> >
> > __get_free_pages(GFP_KERNEL, get_order(32768));
> 
> I agree that specifying size (instead of count) explicitly lead to more
> readable code.
> 

Alright will adjust.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/8] Introduce support for Dell SMBIOS over WMI Mario Limonciello <mario.limonciello@dell.com> - 2017-09-28 06:10 +0200
  [PATCH v3 1/8] platform/x86: wmi: Add new method wmidev_evaluate_method Mario Limonciello <mario.limonciello@dell.com> - 2017-09-28 06:10 +0200
  [PATCH v3 8/8] platform/x86: dell-wmi-smbios: clean up wmi descriptor check Mario Limonciello <mario.limonciello@dell.com> - 2017-09-28 06:10 +0200
    Re: [PATCH v3 8/8] platform/x86: dell-wmi-smbios: clean up wmi  descriptor check Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-10-02 15:20 +0200
      RE: [PATCH v3 8/8] platform/x86: dell-wmi-smbios: clean up wmi  descriptor check <Mario.Limonciello@dell.com> - 2017-10-02 15:30 +0200
  [PATCH v3 2/8] platform/x86: dell-smbios: Introduce a WMI-ACPI interface Mario Limonciello <mario.limonciello@dell.com> - 2017-09-28 06:10 +0200
    Re: [PATCH v3 2/8] platform/x86: dell-smbios: Introduce a WMI-ACPI interface Pali Rohár <pali.rohar@gmail.com> - 2017-09-28 09:00 +0200
      RE: [PATCH v3 2/8] platform/x86: dell-smbios: Introduce a WMI-ACPI  interface <Mario.Limonciello@dell.com> - 2017-09-29 00:50 +0200
        Re: [PATCH v3 2/8] platform/x86: dell-smbios: Introduce a WMI-ACPI  interface Pali Rohár <pali.rohar@gmail.com> - 2017-09-29 09:40 +0200
          RE: [PATCH v3 2/8] platform/x86: dell-smbios: Introduce a WMI-ACPI  interface <Mario.Limonciello@dell.com> - 2017-09-30 22:10 +0200
            Re: [PATCH v3 2/8] platform/x86: dell-smbios: Introduce a WMI-ACPI interface Pali Rohár <pali.rohar@gmail.com> - 2017-09-30 23:10 +0200
    Re: [PATCH v3 2/8] platform/x86: dell-smbios: Introduce a WMI-ACPI  interface Darren Hart <dvhart@infradead.org> - 2017-09-30 03:00 +0200
      Re: [PATCH v3 2/8] platform/x86: dell-smbios: Introduce a WMI-ACPI interface Pali Rohár <pali.rohar@gmail.com> - 2017-09-30 09:20 +0200
        RE: [PATCH v3 2/8] platform/x86: dell-smbios: Introduce a WMI-ACPI  interface <Mario.Limonciello@dell.com> - 2017-09-30 22:00 +0200
  [PATCH v3 7/8] platform/x86: Kconfig: Change the default settings for dell-wmi-smbios Mario Limonciello <mario.limonciello@dell.com> - 2017-09-28 06:10 +0200
  [PATCH v3 5/8] platform/x86: dell-wmi-smbios: introduce character device for userspace Mario Limonciello <mario.limonciello@dell.com> - 2017-09-28 06:10 +0200
    Re: [PATCH v3 5/8] platform/x86: dell-wmi-smbios: introduce  character device for userspace Darren Hart <dvhart@infradead.org> - 2017-09-30 04:10 +0200
      RE: [PATCH v3 5/8] platform/x86: dell-wmi-smbios: introduce character  device for userspace <Mario.Limonciello@dell.com> - 2017-09-30 21:50 +0200
  Re: [PATCH v3 0/8] Introduce support for Dell SMBIOS over WMI Darren Hart <dvhart@infradead.org> - 2017-09-30 04:20 +0200
    RE: [PATCH v3 0/8] Introduce support for Dell SMBIOS over WMI <Mario.Limonciello@dell.com> - 2017-09-30 22:00 +0200

csiph-web