Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1742598
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | "Tobin C. Harding" <me@tobin.cc> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] Staging: rtl8723bs: Remove unnecessary comments. |
| Date | Sat, 30 Sep 2017 13:10:02 +0200 |
| Message-ID | <uvnOG-3lm-9@gated-at.bofh.it> (permalink) |
| References | <uvl0u-1wD-11@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobin.cc; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=faWg+6NZaPGfFf4gvAHuVV2llmK7tsHjx+EGBp0Ps p4=; b=XopN54sdqThlTdnfr040olT605dZz5bqzTUAX628qGywICn1+Tffnh9Nq 654NH8wNuMrWHF90bkqlb7X17JQYEoLe/DIP+ThDzVXiSzjCpdtGrnIyEZod15lA 2JKsDblJ6LvcF5vxZyd4eaG4+ZHJ1SuiJfCTNZztIDFvaS4HxjuTKgf4wuqXDysB psHpTCNuEvNRt1pROUkWGbPH31bwUSHrnvhc7AYSnSAj0aEjW1BtcxdwbT9S16T5 xD7Iwc4/l2QIpNo9KX5tY0KUwDg4/WsQKy9rlnRfegVbpwsk+8gGpxochUTpe9lz 1s7epqcF810zdUvgtQ7MNhXWpeNjg== |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=faWg+6NZaPGfFf4gvA HuVV2llmK7tsHjx+EGBp0Psp4=; b=lKtN6UGwwYjSrbGkQiFJusWHuuFtCLYrYF XP3y/PaiT/D3n5lfzrCEtdEpyErL3Ar/yCnPqnI/MZOl+Wsd3R+fuPbAwJwGjcrY nYbW7ShJJXsShXqTYB1QnCZ5GQZkhrjFxZvhqtsO65neMXZsmFRrFlHlrXj+qn0Z ZQUqLJ9azIiR2hGhOnbJtN1PS+QwJsuiV5iX6gMozbBnp7+A0dL4/U33rl5V5cPW pZkmGW2/lMhREr7J2/5W9lAEVGxpXoZTZqKYWUVC59rjEzx5co/YcDwunQL5Mv0x MNTwC1cVeGhMpjFeFZdZCoN7r6CqHTw45Q7HmfqfsojfB21zw00g== |
| X-Me-Sender | <xms:1XrPWb_5fJSW272vS421FQqObUjoLZhiFtGdtWxv9KkUtXfaqREjPQ> |
| X-Sasl-Enc | /zTYYCMARc3mJcB/wPiOExW8L7tYisEepchQHWBhiyPF 1506769620 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| X-Mailer | Mutt 1.5.24 (2015-08-30) |
| User-Agent | Mutt/1.5.24 (2015-08-30) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 20 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com |
| X-Original-Date | Sat, 30 Sep 2017 21:06:57 +1000 |
| X-Original-Message-ID | <20170930110657.GA25277@eros> |
| X-Original-References | <1506758434-3193-1-git-send-email-shreeya.patel23498@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1742598 |
Show key headers only | View raw
Hi Shreeya,
We don't usually add a period to the subject line for kernel patches. (reason: we only have about
52 characters for the commit brief description so best not to waste any).
On Sat, Sep 30, 2017 at 01:30:34PM +0530, Shreeya Patel wrote:
> This patch removes unnecessary comments which are there
> to explain why call to memset is in comments. Both of the
> comments are not needed as they are not very useful.
You may like to read Documentation/process/submitting-patches.rst (specifically
section 2) for tips on writing your git log.
Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour.
Good luck,
Tobin.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] Staging: rtl8723bs: Remove unnecessary comments. Shreeya Patel <shreeya.patel23498@gmail.com> - 2017-09-30 10:10 +0200
Re: [PATCH v2] Staging: rtl8723bs: Remove unnecessary comments. "Tobin C. Harding" <me@tobin.cc> - 2017-09-30 13:10 +0200
Re: [PATCH v2] Staging: rtl8723bs: Remove unnecessary comments. Shreeya Patel <shreeya.patel23498@gmail.com> - 2017-09-30 13:20 +0200
csiph-web