[PATCH] net: hns3: Fix an error handling path in 'hclge_rss_init_hw()'

From	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Newsgroups	linux.kernel
Subject	[PATCH] net: hns3: Fix an error handling path in 'hclge_rss_init_hw()'
Date	2017-09-30 07:40 +0200
Message-ID	<uviFj-8kJ-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

If this sanity check fails, we must free 'rss_indir'. Otherwise there is a
memory leak.
'goto err' as done in the other error handling paths to fix it.

Fixes: 46a3df9f9718 ("net: hns3: Fix for setting rss_size incorrectly")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
index e0685e630afe..c1cdbfd83bdb 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
@@ -2652,7 +2652,8 @@ static int hclge_rss_init_hw(struct hclge_dev *hdev)
 		dev_err(&hdev->pdev->dev,
 			"Configure rss tc size failed, invalid TC_SIZE = %d\n",
 			rss_size);
-		return -EINVAL;
+		ret = -EINVAL;
+		goto err;
 	}
 
 	roundup_size = roundup_pow_of_two(rss_size);
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: hns3: Fix an error handling path in 'hclge_rss_init_hw()' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-09-30 07:40 +0200
  Re: [PATCH] net: hns3: Fix an error handling path in  'hclge_rss_init_hw()' Yunsheng Lin <linyunsheng@huawei.com> - 2017-09-30 08:20 +0200
  Re: [PATCH] net: hns3: Fix an error handling path in  'hclge_rss_init_hw()' David Miller <davem@davemloft.net> - 2017-10-02 08:00 +0200

csiph-web