Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1742389

Re: [PATCH 1/2] block: genhd: add device_add_disk_with_groups

From Keith Busch <keith.busch@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] block: genhd: add device_add_disk_with_groups
Date 2017-09-30 01:10 +0200
Message-ID <uvczT-4eY-5@gated-at.bofh.it> (permalink)
References <uuMP7-4CX-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, Sep 28, 2017 at 09:36:36PM +0200, Martin Wilck wrote:
> In the NVME subsystem, we're seeing a race condition with udev where
> device_add_disk() is called (which triggers an "add" uevent), and a
> sysfs attribute group is added to the disk device afterwards.
> If udev rules access these attributes before they are created,
> udev processing of the device is incomplete, in particular, device
> WWIDs may not be determined correctly.
> 
> To fix this, this patch introduces a new function
> device_add_disk_with_groups(), which takes a list of attribute groups
> and adds them to the device before sending out uevents.
> 
> Signed-off-by: Martin Wilck <mwilck@suse.com>

Is NVMe the only one having this problem? Was putting our attributes in
the disk's kobj a bad choice?

Any, looks fine to me.

Reviewed-by: Keith Busch <keith.busch@intel.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] block: genhd: add device_add_disk_with_groups Martin Wilck <mwilck@suse.com> - 2017-09-28 21:40 +0200
  [PATCH 2/2] nvme: use device_add_disk_with_groups() Martin Wilck <mwilck@suse.com> - 2017-09-28 21:40 +0200
    RE: [PATCH 2/2] nvme: use device_add_disk_with_groups() "Schremmer, Steven" <Steve.Schremmer@netapp.com> - 2017-09-29 21:30 +0200
    Re: [PATCH 2/2] nvme: use device_add_disk_with_groups() Keith Busch <keith.busch@intel.com> - 2017-09-30 01:10 +0200
  RE: [PATCH 1/2] block: genhd: add device_add_disk_with_groups "Schremmer, Steven" <Steve.Schremmer@netapp.com> - 2017-09-29 21:30 +0200
  Re: [PATCH 1/2] block: genhd: add device_add_disk_with_groups Keith Busch <keith.busch@intel.com> - 2017-09-30 01:10 +0200
  Re: [PATCH 1/2] block: genhd: add device_add_disk_with_groups Christoph Hellwig <hch@lst.de> - 2017-10-01 10:10 +0200

csiph-web